From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754917AbcDMXQx (ORCPT ); Wed, 13 Apr 2016 19:16:53 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:55883 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754773AbcDMXQv (ORCPT ); Wed, 13 Apr 2016 19:16:51 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee691-f795a6d0000012b5-77-570ed3604c98 Content-transfer-encoding: 8BIT Message-id: <570ED35F.8030401@samsung.com> Date: Thu, 14 Apr 2016 08:16:47 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: rjw@rjwysocki.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, linux.amoon@gmail.com, m.reichl@fivetechno.de, tjakobi@math.uni-bielefeld.de, inki.dae@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 6/7] ARM: dts: Add bus nodes using VDD_INT for Exynos542x SoC References: <1460091646-28701-1-git-send-email-cw00.choi@samsung.com> <1460091646-28701-7-git-send-email-cw00.choi@samsung.com> <570CD3AF.8040206@samsung.com> In-reply-to: <570CD3AF.8040206@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42JZI2JSrJtwmS/c4OY+FYv5R86xWvS/Wchq ce7VSkaLSfcnsFi8fmFo0f/4NbPF2aY37BabHl9jtbi8aw6bxefeI4wWM87vY7JYt/EWu8Xt y7wWL4/8YLRYev0ik8XtxhVsFhOmr2WxOHP6EqtF694j7BaH37SzWrSt/sBqsWrXH0YHMY81 89YwerQ097B5XO7rZfK4dafeY+esu+weK5d/YfPYtKqTzWPzknqPf8fYPbZcbWfx6NuyitHj 8ya5AJ4oLpuU1JzMstQifbsEroxJ91axFEw0rng24x1bA+MbjS5GTg4JAROJE4+usELYYhIX 7q1n62Lk4hASWMEosWnqNFaYov8TFrFCJGYxSnydv5IJJMErICjxY/I9li5GDg5mAXmJI5ey QcLMAuoSk+YtYoaof8AosarjISNEvZbE9sZuFhCbRUBV4v3vbWwgNhtQfP+LG2wgc0QFIiS6 T1SChEUEVjNK3D8WCTKHWWAts8Sr9kawg4QFgiWWrHkBdekiRokD5z+DJTgFtCUaGk4zgSQk BD5wSHSePsQKsU1A4tvkQ2CXSgjISmw6wAzxmaTEwRU3WCYwis1C8s8shH9mIflnASPzKkbR 1ILkguKk9CJTveLE3OLSvHS95PzcTYzARHL637OJOxjvH7A+xCjAwajEw3thDW+4EGtiWXFl 7iFGU6AjJjJLiSbnA9NVXkm8obGZkYWpiamxkbmlmZI4r470z2AhgfTEktTs1NSC1KL4otKc 1OJDjEwcnFINjPtf7456/dWKVy5n0ucHs80lfxQmdHisnO7GWTtTO+fhUmYF/z0NfF8cbL5X 8354wlW5MIXx2Wk/ke9sHtEZIaEezPPFtEvPMj57eX7OukJbFVfPOUonvzr+tVjNWFj3Niv0 kbNNCd/BmWZuaSbLrJL+LmrReLSLM81o1fOstHN3xHZeOeyUpMRSnJFoqMVcVJwIAKNMYlEf AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJKsWRmVeSWpSXmKPExsVy+t9jQd2Ey3zhBncWyFjMP3KO1aL/zUJW i3OvVjJaTLo/gcXi9QtDi/7Hr5ktzja9YbfY9Pgaq8XlXXPYLD73HmG0mHF+H5PFuo232C1u X+a1eHnkB6PF0usXmSxuN65gs5gwfS2LxZnTl1gtWvceYbc4/Kad1aJt9QdWi1W7/jA6iHms mbeG0aOluYfN43JfL5PHrTv1Hjtn3WX3WLn8C5vHplWdbB6bl9R7/DvG7rHlajuLR9+WVYwe nzfJBfBENTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl 5gA9rKRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHMmHRvFUvBROOKZzPe sTUwvtHoYuTkkBAwkfg/YRErhC0mceHeerYuRi4OIYFZjBJf569kAknwCghK/Jh8j6WLkYOD WUBe4silbJAws4C6xKR5i5gh6h8wSqzqeMgIUa8lsb2xmwXEZhFQlXj/exsbiM0GFN//4gYb yBxRgQiJ7hOVIGERgdWMEvePRYLMYRZYyyzxqr0R7CBhgWCJJWteQB20iFHiwPnPYAlOAW2J hobTTBMYgc5EuG8Wwn2zkNy3gJF5FaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZwsnom tYPx4C73Q4wCHIxKPLwX1vCGC7EmlhVX5h5ilOBgVhLhfXqeL1yINyWxsiq1KD++qDQntfgQ oynQgxOZpUST84GJNK8k3tDYxMzI0sjc0MLI2FxJnPfx/3VhQgLpiSWp2ampBalFMH1MHJxS DYwa/kYZx3MOCHYKzZpRIsjY/lCDJ25yqi93Qoqt4R/r2eVi76Mqw+Wfsu/Rvzxvj4H4uhsL XU6tXVH5WexxgKr96rAT4vJTV2x8rjP548cal4DIrnnm2pkX+t2OWpx0T1nDvaG+9qznodhd DgHhWzTFhCMn+7JOCJb4Ns1Dh23LRtXWoPVJoUosxRmJhlrMRcWJAA85xahsAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 04월 12일 19:53, Krzysztof Kozlowski wrote: > On 04/08/2016 07:00 AM, Chanwoo Choi wrote: >> This patch adds the AMBA bus nodes using VDD_INT for Exynos542x SoC. >> Exynos542x has the following AMBA buses to translate data between >> DRAM and sub-blocks. >> >> Following list specifies the detailed correlation between sub-block and clock: >> - CLK_DOUT_ACLK400_WCORE clock for WCORE's AXI >> - CLK_DOUT_ACLK100_NOC for NoC (Network on Chip)'s AXI >> - CLK_DOUT_PCLK200_FSYS for FSYS's APB >> - CLK_DOUT_ACLK200_FSYS for FSYS's AXI >> - CLK_DOUT_ACLK200_FSYS2 for FSYS2's AXI >> - CLK_DOUT_ACLK333 for MFC's AXI >> - CLK_DOUT_ACLK266 for GEN's AXI >> - CLK_DOUT_ACLK66 for PERIC/PERIR's AXI >> - CLK_DOUT_ACLK333_G2D for G2D's AXI >> - CLK_DOUT_ACLK266_G2D for ACP's AXI >> - CLK_DOUT_ACLK300_JPEG for JPEG's AXI >> - CLK_DOUT_ACLK166 for JPEG's APB >> - CLK_DOUT_ACLK300_DISP1 for FIMD's AXI >> - CLK_DOUT_ACLK400_DISP1 for DISP1's AXI >> - CLK_DOUT_ACLK300_GSCL for GSCL Scaler's AXI >> - CLK_DOUT_ACLK400_MSCL for MSCL's AXI >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm/boot/dts/exynos5420.dtsi | 371 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 371 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi >> index d80f3b66f017..1340024fa882 100644 >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> @@ -1224,6 +1224,377 @@ >> power-domains = <&disp_pd>; >> #iommu-cells = <0>; >> }; >> + >> + bus_wcore: bus_wcore { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK400_WCORE>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_wcore_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_noc: bus_noc { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK100_NOC>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_noc_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_fsys_apb: bus_fsys_apb { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_PCLK200_FSYS>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_fsys_apb_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_fsys: bus_fsys { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK200_FSYS>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_fsys_apb_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_fsys2: bus_fsys2 { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK200_FSYS2>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_fsys2_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_mfc: bus_mfc { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK333>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_mfc_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_gen: bus_gen { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK266>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_gen_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_peri: bus_peri { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK66>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_peri_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_g2d: bus_g2d { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK333_G2D>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_g2d_acp: bus_g2d_acp { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK266_G2D>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_acp_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_jpeg: bus_jpeg { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK300_JPEG>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_jpeg_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_jpeg_apb: bus_jpeg_apb { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK166>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_jpeg_apb_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_disp1_fimd: bus_disp1_fimd { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK300_DISP1>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_disp1_fimd_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_disp1: bus_disp1 { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK400_DISP1>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_disp1_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_gscl_scaler: bus_gscl_scaler { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK300_GSCL>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_gscl_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_mscl: bus_mscl { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&clock CLK_DOUT_ACLK400_MSCL>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_mscl_opp_table>; >> + status = "disabled"; >> + }; >> + >> + bus_wcore_opp_table: opp_table2 { >> + compatible = "operating-points-v2"; >> + >> + opp00 { >> + opp-hz = /bits/ 64 <84000000>; >> + opp-microvolt = <925000>; >> + }; >> + opp01 { >> + opp-hz = /bits/ 64 <111000000>; >> + opp-microvolt = <950000>; >> + }; >> + opp02 { >> + opp-hz = /bits/ 64 <222000000>; >> + opp-microvolt = <950000>; >> + }; >> + opp03 { >> + opp-hz = /bits/ 64 <333000000>; >> + opp-microvolt = <950000>; >> + }; >> + opp04 { >> + opp-hz = /bits/ 64 <400000000>; >> + opp-microvolt = <987500>; >> + }; >> + }; >> + >> + bus_noc_opp_table: opp_table3 { >> + compatible = "operating-points-v2"; >> + >> + opp00 { >> + opp-hz = /bits/ 64 <66000000>; > > 67000000 so it won't be round down? I'll change it. 66000000 -> 67000000. > > Beside that looks good. I am assuming the same apply strategy - I can > take the DTS changes the bindings got accepted. > > Reviewed-by: Krzysztof Kozlowski Thanks for the review. Best Regards, Chanwoo Choi