From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753753AbcDNFsd (ORCPT ); Thu, 14 Apr 2016 01:48:33 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:55449 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044AbcDNFsb convert rfc822-to-8bit (ORCPT ); Thu, 14 Apr 2016 01:48:31 -0400 X-AuditID: cbfee68d-f79e86d0000012da-ef-570f2f266673 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <570F2F26.9030408@samsung.com> Date: Thu, 14 Apr 2016 14:48:22 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , myungjoo.ham@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: rjw@rjwysocki.net, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, linux.amoon@gmail.com, m.reichl@fivetechno.de, tjakobi@math.uni-bielefeld.de, inki.dae@samsung.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/7] ARM: dts: Add NoC Probe dt node for Exynos542x SoC References: <1460091646-28701-1-git-send-email-cw00.choi@samsung.com> <1460091646-28701-4-git-send-email-cw00.choi@samsung.com> <570CAE67.4020001@samsung.com> In-reply-to: <570CAE67.4020001@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0iTYRTGefdd9mkOv3Tq2yCjdVEUNa+9VkQhyBcGBUIr/9FpHyrqlE0l SfCWWt4viTLMUnPzMoum4AWvU8TQzFp5v6Ek5kaIZmmKNTcD/3s45zznOT84FGalIARUpCSe lUrE0ULSHFfxvaQuF90sRZfSh6+gl4NjBCrUVxNobL0BoJLFIhzp1txR4YoOQx/S9VykXpkg kLazkkRb+YMAVXzs4aA372a4aFbLQ98HdwCqm/zEQbNp9SQqKm/G0ejIZwJldg9y0YA+m0BZ TRsEauzcBzdsGVWVCjBPMvJIRluQz2Fm5lKYDvk8l2lQ/iQZdeMzkml5ncIcDHGZ1q/ZOFPQ 2giYLbX9XYsg82sP2ejIRFbqdj3EPGKiagqPa7J4lClXclPBhlkOMKMg7QXLVGrcpG3h+MJb MgeYU1Z0PYDdeRWc/0ND2i7M1KgD8M9IBnnY4NEn4U7pgtGN0Q6wpKoGM2k+bNftEybtDBXV uiPzEoB5i4ojsxOsXG4ymnH6Aiwr6TWaSUO9d23KMENRNvR9mDucdFjm000ALg49ONyD0c0Y XM9OMwZY0wEwY3ebMAXUAPj7h9K41MyQ3DbbZuSB9AYFV59OA1MaDX+VavDDBEifhuo+zIR5 CvbXT+FFwE5+DE5+DE5+DE5+DO4VwBuBDRsXFicLDZe6u8rEMbIESbhrWGyMGhjeZ+RgNb8d zPZd1QCaAkIL3riKJ7IixImypBgN8DZcVIwJbMJiDR8niQ929/TxQN5e3p4el319hHa8s4Ld QCs6XBzPRrFsHCsNliZEszIN4FBmglQgOfiiuq0IWL6ZFhM1nLA3UNcfCvXCzpfnbp3p+dt6 Z5tul216iSwe39NpfZfy7DmksHyOdpzyf75u6xJSURyUkOUo8avK9/5W69y15r+q2VvyGxXp k0l+4PsXrsW1XLmkUmCr6EnO7Z7eXK+ftxbFnle2yDti505YTjrwh3KFuCxC7O6ESWXif/4W ckw5AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBKsWRmVeSWpSXmKPExsVy+t9jAV01ff5wgxf3jCzmHznHatH/ZiGr xblXKxktJt2fwGLx+oWhRf/j18wWZ5vesFtsenyN1eLyrjlsFp97jzBazDi/j8li3cZb7Ba3 L/NavDzyg9Fi6fWLTBa3G1ewWUyYvpbF4szpS6wWrXuPsFscftPOatG2+gOrxapdfxgdxDzW zFvD6NHS3MPmcbmvl8nj1p16j52z7rJ7rFz+hc1j06pONo/NS+o9/h1j99hytZ3Fo2/LKkaP z5vkAniiGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0y c4AeVlIoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jBm3JhwmLmgkafi13Kx BsZjnF2MnBwSAiYSxy7vYYawxSQu3FvP1sXIxSEksJRR4tfpZjaQBK+AoMSPyfdYuhg5OJgF 5CWOXMoGCTMLqEtMmreIGaL+AaNEz/1lUPVaEnMerWYBsVkEVCWmTtoPtoANKL7/xQ02kDmi AhES3ScqQcIiAqsZJe4fiwSZwyywllniVXsjK0hCWMBbovnnV1aIBYsYJb6/Ww42lFNAW2L7 7e1sExgFZiG5bxbCfbOQ3LeAkXkVo0RqQXJBcVJ6rmFearlecWJucWleul5yfu4mRnCqeia1 g/HgLvdDjAIcjEo8vBfW8IYLsSaWFVfmHmKU4GBWEuG9Js8fLsSbklhZlVqUH19UmpNafIjR FOjBicxSosn5wDSaVxJvaGxiZmRpZG5oYWRsriTO+/j/ujAhgfTEktTs1NSC1CKYPiYOTqkG xqPlUWUuuakLnv+oi30qrdzMfS/83vqc45kv9jB215x33jXH6fvirzIfP6kcdvfIEts1JXb9 spyWxzdnL7ZiPq+47f3VKazmEd8vaKepsEzbtSpg9k2DzSEt3h8Sfqb8VHv6lOmvRWS0pESW grTIt6wQ40S2tuDXBsnhQouuMR693fF0h2CDoxJLcUaioRZzUXEiAHnydZxrAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 04월 12일 17:14, Krzysztof Kozlowski wrote: > On 04/08/2016 07:00 AM, Chanwoo Choi wrote: >> This patch adds the NoCP (Network on Chip Probe) Device Tree node >> to measure the bandwidth of memory and g3d in Exynos542x SoC. >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm/boot/dts/exynos5420.dtsi | 36 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi >> index 7b99cb58d82d..d80f3b66f017 100644 >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> @@ -294,6 +294,42 @@ >> }; >> }; >> >> + nocp_mem0_0: nocp_mem0_0@10CA1000 { > > The node name should describe general class of device, so: > > nocp_mem0_0: nocp@10CA1000 { > ... > } > ? I'll modify it. > >> + compatible = "samsung,exynos5420-nocp"; >> + reg = <0x10CA1000 0x200>; >> + status = "disabled"; >> + }; >> + >> + nocp_mem0_1: nocp_mem0_1@10CA1400 { >> + compatible = "samsung,exynos5420-nocp"; >> + reg = <0x10CA1400 0x200>; >> + status = "disabled"; >> + }; >> + >> + nocp_mem0_2: nocp_mem0_2@10CA1800 { > > Shouldn't it be nocp_mem1_0? I was mistaken. I'll fix it. > >> + compatible = "samsung,exynos5420-nocp"; >> + reg = <0x10CA1800 0x200>; >> + status = "disabled"; >> + }; >> + >> + nocp_mem0_3: nocp_mem0_3@10CA1C00 { > > Shouldn't it be nocp_mem1_1? ditto. Best Regards, Chanwoo Choi