From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753039AbcDNGKg (ORCPT ); Thu, 14 Apr 2016 02:10:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:47557 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbcDNGKf (ORCPT ); Thu, 14 Apr 2016 02:10:35 -0400 Subject: Re: [PATCHv2 1/2] target: make target db location configurable To: Lee Duncan , linux-scsi@vger.kernel.org, nab@linux-iscsi.org, target-devel@vger.kernel.org References: <5f4f1bc2ac2177a37432f0afd22f16ddf65e9e9b.1460577841.git.lduncan@suse.com> Cc: linux-kernel@vger.kernel.org, hch@infradead.org, agrover@redhat.com, jxm@netiant.com From: Hannes Reinecke Message-ID: <570F3458.8010109@suse.de> Date: Thu, 14 Apr 2016 08:10:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <5f4f1bc2ac2177a37432f0afd22f16ddf65e9e9b.1460577841.git.lduncan@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/13/2016 10:25 PM, Lee Duncan wrote: > This commit adds the read-write attribute "dbroot", > in the top-level CONFIGFS (core) target directory, > normally /sys/kernel/config/target. This attribute > defaults to "/var/target" but can be changed by > writing a new pathname string to it. Changing this > attribute is only allowed when no fabric drivers > are loaded and the supplied value specifies an > existing directory. > > Target modules that care about the target database > root directory will be modified to use this > attribute in a future commit. > > Signed-off-by: Lee Duncan > --- > drivers/target/target_core_configfs.c | 51 +++++++++++++++++++++++++++++++++++ > drivers/target/target_core_internal.h | 6 +++++ > 2 files changed, 57 insertions(+) > > diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c > index 713c63d9681b..bfedbd92b77f 100644 > --- a/drivers/target/target_core_configfs.c > +++ b/drivers/target/target_core_configfs.c > @@ -99,6 +99,56 @@ static ssize_t target_core_item_version_show(struct config_item *item, > > CONFIGFS_ATTR_RO(target_core_item_, version); > > +char db_root[DB_ROOT_LEN] = DB_ROOT_DEFAULT; > +static char db_root_stage[DB_ROOT_LEN]; > + > +static ssize_t target_core_item_dbroot_show(struct config_item *item, > + char *page) > +{ > + return sprintf(page, "%s\n", db_root); > +} > + > +static ssize_t target_core_item_dbroot_store(struct config_item *item, > + const char *page, size_t count) > +{ > + ssize_t read_bytes; > + struct file *fp; > + > + if (!list_empty(&g_tf_list)) { > + pr_err("db_root: cannot be changed: target drivers registered"); > + return -EINVAL; > + } Locking? Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)