From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752928AbcDNG2Z (ORCPT ); Thu, 14 Apr 2016 02:28:25 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:47866 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751384AbcDNG2V convert rfc822-to-8bit (ORCPT ); Thu, 14 Apr 2016 02:28:21 -0400 X-AuditID: cbfee68f-f79c86d0000012ad-f9-570f3882415a MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <570F3881.9000100@samsung.com> Date: Thu, 14 Apr 2016 15:28:17 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Tomasz Figa , Krzysztof Kozlowski Cc: MyungJoo Ham , Kyungmin Park , Kukjin Kim , Sylwester Nawrocki , "Rafael J. Wysocki" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , linux.amoon@gmail.com, m.reichl@fivetechno.de, Tobias Jakobi , InKi Dae , linux-kernel , "linux-pm@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , linux-arm-kernel , devicetree Subject: Re: [PATCH 5/7] clk: samsung: exynos542x: Add the clock id for ACLK References: <1460091646-28701-1-git-send-email-cw00.choi@samsung.com> <1460091646-28701-6-git-send-email-cw00.choi@samsung.com> <570CDB16.2050001@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEKsWRmVeSWpSXmKPExsWyRsSkULfJgj/c4MtsSYv5R86xWvS/Wchq ce7VSkaLSfcnsFi8fmFo0f/4NbPF2aY37BabHl9jtbi8aw6bxefeI4wWM87vY7JYt/EWu8Xt y7wWL4/8YLRYev0ik8XtxhVsFhOmr2WxOHP6EqtF694j7BaH37SzWrSt/sBqsWrXH0YHMY81 89YwerQ097B5XO7rZfK4dafeY+esu+weK5d/YfPYtKqTzWPzknqPf8fYPbZcbWfx6NuyitHj 8ya5AJ4oLpuU1JzMstQifbsEroxLnx+zFnznrPi2/C9jA+Nkji5GTg4JAROJqd8b2CFsMYkL 99azdTFycQgJrGCUuLvnO2sXIwdY0c7XyhDxWYwSG5q7GUEaeAUEJX5MvscCUsMsoC4xZUou SJhZQESieep/NghbW2LZwtfMEL0PGCX2tP+G6tWSmDNlF9hiFgFVid49/8HibEDx/S9usIHM FBWIkOg+UQliigCZjc98QMYwC1xmk/j6fxkrSLmwgI/E3/V/oOa/ZJS4sxtiDqdAsMTsfxNY QRISAi84JM7uuMgGsUxA4tvkQywQj8lKbDrADPG8pMTBFTdYJjCKz0Ly2iyE12YheW0WktcW MLKsYhRNLUguKE5KLzLWK07MLS7NS9dLzs/dxAhMOqf/PevfwXj3gPUhRgEORiUe3gtreMOF WBPLiitzDzGaAh00kVlKNDkfmNrySuINjc2MLExNTI2NzC3NlMR5F0r9DBYSSE8sSc1OTS1I LYovKs1JLT7EyMTBKdXAuP/nIeuY7X1VH99wudhK+J7j6rNf+PZ9jYP2pdQuL/HbnFr+Bv13 b5SF5fVzzRbk0ZKOdLgr+n2uztY7zFY17kc64luXasx8dzR3U3vC38x3ZoZ60uzsMa1aS35K rkyQnvUklMdpTvdCt56gVBtf5YDtmmoHX5yYeOrvEX6WzR1S8jH/bVYqsRRnJBpqMRcVJwIA cd5zJDUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCKsWRmVeSWpSXmKPExsVy+t9jQd0mC/5wg81ThSzmHznHatH/ZiGr xblXKxktJt2fwGLx+oWhRf/j18wWZ5vesFtsenyN1eLyrjlsFp97jzBazDi/j8li3cZb7Ba3 L/NavDzyg9Fi6fWLTBa3G1ewWUyYvpbF4szpS6wWrXuPsFscftPOatG2+gOrxapdfxgdxDzW zFvD6NHS3MPmcbmvl8nj1p16j52z7rJ7rFz+hc1j06pONo/NS+o9/h1j99hytZ3Fo2/LKkaP z5vkAniiGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0y c4AeVlIoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jBmbF30l6XgKWfF5b+W DYyNHF2MHBwSAiYSO18rdzFyApliEhfurWfrYuTiEBKYxSixobmbESTBKyAo8WPyPRaQemYB eYkjl7IhTHWJKVNyIcofMErsaf8NVa4lMWfKLnYQm0VAVaJ3z3+wOBtQfP+LG2wgvaICERLd JypBTBEgs/GZD8gYZoHLbBJf/y9jBSkXFvCR+Lv+DzPE/JeMEnd2Q8zhFAiWmP1vAusERqAj Ea6bhXDdLITrFjAyr2KUSC1ILihOSs81zEst1ytOzC0uzUvXS87P3cQITlHPpHYwHtzlfohR gINRiYf3whrecCHWxLLiytxDjBIczEoivLON+MOFeFMSK6tSi/Lji0pzUosPMZoCvTeRWUo0 OR+YPvNK4g2NTcyMLI3MDS2MjM2VxHkf/18XJiSQnliSmp2aWpBaBNPHxMEp1cA4M/Gw2oMv 7ypE/Vd+vraEX43t8Y7Lf7YfdwsS74kMEDnyTLBb5Enx3LkWGukNcVnG516FKGQYuYa1r110 YaregfJ75xjjg5S/TzLSjE9+cP/b9b25b9+wZy6c8ffhw1kZ197pNv/9Us61ffuWi0at+aqP ct5d1Qx7sUEx879hvIZO85wDTVsrlViKMxINtZiLihMBVyCIX2cDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomasz and Krzysztof, On 2016년 04월 13일 15:20, Tomasz Figa wrote: > 2016-04-12 14:25 GMT+03:00 Krzysztof Kozlowski : >> On 04/08/2016 07:00 AM, Chanwoo Choi wrote: >>> This patch adds the clock id for ACLK clock which is source clock of AMBA AXI >>> Bus. This clock should be handled in Bus frequency scaling driver. >>> >>> Signed-off-by: Chanwoo Choi >>> --- >>> drivers/clk/samsung/clk-exynos5420.c | 85 +++++++++++++++++++++++------------- >>> 1 file changed, 55 insertions(+), 30 deletions(-) >> >> The IDs itself look good but you are not adding only clock ID. You are >> changing all of them from NULL-flags to CLK_SET_RATE_PARENT. This should >> be explained in the commit message why you need it. Probably it should >> be also in separate commit. > > +1. And CLK_SET_RATE_PARENT for a clock which has a mux as its parent > is a bit suspicious, so I'd like to know the rationale for each single > clock with CLK_SET_RATE_PARENT being added. This patch don't need the CLK_SET_RATE_PARENT flag. As Tomasz's comment, the mux of divider's parent don't need this flag. Sorry for confusion. I'll drop the CLK_SET_RATE_PARENT flag. Best Regards, Chanwoo Choi