From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arm@kernel.org, robh@kernel.org,
Andre Przywara <andre.przywara@arm.com>,
Russell King <linux@arm.linux.org.uk>,
Chen-Yu Tsai <wens@csie.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP
Date: Thu, 14 Apr 2016 09:47:46 +0100 [thread overview]
Message-ID: <570F5932.2020809@arm.com> (raw)
In-Reply-To: <20160413200735.GC4005@lukather>
On 13/04/16 21:07, Maxime Ripard wrote:
> Hi,
>
> On Wed, Apr 13, 2016 at 04:59:27PM +0100, Suzuki K Poulose wrote:
>> The sunxi-nmi and sun4i irq chips are selected by ARCH_SUNXI on both arm
>> and arm64 (recently added). However on arm64, we don't explicitly select
>> GENERIC_IRQ_CHIP which is required by the sunxi-nmi irq chip driver and
>> causes build breaks on 4.6-rc1 :
>> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
>> index b03cfcb..c9626f4 100644
>> --- a/drivers/irqchip/Makefile
>> +++ b/drivers/irqchip/Makefile
>> @@ -19,8 +19,8 @@ obj-$(CONFIG_CLPS711X_IRQCHIP) += irq-clps711x.o
>> obj-$(CONFIG_OR1K_PIC) += irq-or1k-pic.o
>> obj-$(CONFIG_ORION_IRQCHIP) += irq-orion.o
>> obj-$(CONFIG_OMAP_IRQCHIP) += irq-omap-intc.o
>> -obj-$(CONFIG_ARCH_SUNXI) += irq-sun4i.o
>> -obj-$(CONFIG_ARCH_SUNXI) += irq-sunxi-nmi.o
>> +obj-$(CONFIG_SUNXI_IRQCHIP) += irq-sun4i.o
>> +obj-$(CONFIG_SUNXI_IRQCHIP) += irq-sunxi-nmi.o
>
> Those are two different drivers, that should be selected by different
> SoCs (MACH_SUN4I and MACH_SUN5I for the former, SUN6I, SUN7I and SUN8I
> for the latter)
OK. I had thought about that, but wasn't sure who needs what. So went with
what existed already. I can respin it.
Cheers
Suzuki
next prev parent reply other threads:[~2016-04-14 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 15:59 [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP Suzuki K Poulose
2016-04-13 16:18 ` Marc Zyngier
2016-04-13 20:07 ` Maxime Ripard
2016-04-14 8:47 ` Suzuki K Poulose [this message]
2016-04-14 8:56 ` Suzuki K Poulose
2016-04-14 9:15 ` Andre Przywara
2016-04-14 17:12 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570F5932.2020809@arm.com \
--to=suzuki.poulose@arm.com \
--cc=andre.przywara@arm.com \
--cc=arm@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).