From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754762AbcDNI5K (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Apr 2016 04:57:10 -0400
Received: from foss.arm.com ([217.140.101.70]:40597 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752091AbcDNI5I (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Apr 2016 04:57:08 -0400
Subject: Re: [PATCH v2] sunxi-irq: Fix Kconfig dependency on GENERIC_IRQ_CHIP
To: Maxime Ripard <maxime.ripard@free-electrons.com>
References: <1460563167-18517-1-git-send-email-suzuki.poulose@arm.com>
 <20160413200735.GC4005@lukather> <570F5932.2020809@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        arm@kernel.org, robh@kernel.org,
        Andre Przywara <andre.przywara@arm.com>,
        Russell King <linux@arm.linux.org.uk>, Chen-Yu Tsai <wens@csie.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>
From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
Message-ID: <570F5B5B.90302@arm.com>
Date: Thu, 14 Apr 2016 09:56:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <570F5932.2020809@arm.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14/04/16 09:47, Suzuki K Poulose wrote:
> On 13/04/16 21:07, Maxime Ripard wrote:
>> Hi,
>>
>> On Wed, Apr 13, 2016 at 04:59:27PM +0100, Suzuki K Poulose wrote:
>>> The sunxi-nmi and sun4i irq chips are selected by ARCH_SUNXI on both arm
>>> and arm64 (recently added). However on arm64, we don't explicitly select
>>> GENERIC_IRQ_CHIP which is required by the sunxi-nmi irq chip driver and
>>> causes build breaks on 4.6-rc1 :
>
>>> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
>>> index b03cfcb..c9626f4 100644
>>> --- a/drivers/irqchip/Makefile
>>> +++ b/drivers/irqchip/Makefile
>>> @@ -19,8 +19,8 @@ obj-$(CONFIG_CLPS711X_IRQCHIP)        += irq-clps711x.o
>>>   obj-$(CONFIG_OR1K_PIC)            += irq-or1k-pic.o
>>>   obj-$(CONFIG_ORION_IRQCHIP)        += irq-orion.o
>>>   obj-$(CONFIG_OMAP_IRQCHIP)        += irq-omap-intc.o
>>> -obj-$(CONFIG_ARCH_SUNXI)        += irq-sun4i.o
>>> -obj-$(CONFIG_ARCH_SUNXI)        += irq-sunxi-nmi.o
>>> +obj-$(CONFIG_SUNXI_IRQCHIP)        += irq-sun4i.o
>>> +obj-$(CONFIG_SUNXI_IRQCHIP)        += irq-sunxi-nmi.o
>>
>> Those are two different drivers, that should be selected by different
>> SoCs (MACH_SUN4I and MACH_SUN5I for the former, SUN6I, SUN7I and SUN8I
>> for the latter)
>
> OK. I had thought about that, but wasn't sure who needs what. So went with
> what existed already. I can respin it.

As a follow up question, what does the arm64 port need ? just sunxi-nmi ? or both ?
I would be happy if someone who has better understanding of the dependencies can fix
it up, rather than me trying to figure out all the dependencies.

Cheers
Suzuki