From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755497AbcDNQqz (ORCPT ); Thu, 14 Apr 2016 12:46:55 -0400 Received: from foss.arm.com ([217.140.101.70]:44438 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753116AbcDNQqy (ORCPT ); Thu, 14 Apr 2016 12:46:54 -0400 Subject: Re: [PATCH v2 2/3] devicetree: leds: Introduce "panic-indicator" optional property To: Ezequiel Garcia , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <1460570899-24642-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1460570899-24642-3-git-send-email-ezequiel@vanguardiasur.com.ar> Cc: Mark Rutland , Pawel Moll , Ian Campbell , Rob Herring , Richard Purdie , Kumar Gala , Jacek Anaszewski From: Robin Murphy Message-ID: <570FC973.2040708@arm.com> Date: Thu, 14 Apr 2016 17:46:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460570899-24642-3-git-send-email-ezequiel@vanguardiasur.com.ar> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ezequiel, On 13/04/16 19:08, Ezequiel Garcia wrote: > It's desirable to specify which LEDs are to be blinked on a kernel > panic. Therefore, introduce a devicetree boolean property to mark > which LEDs should be treated this way, if possible. > > Signed-off-by: Ezequiel Garcia > --- > Documentation/devicetree/bindings/leds/common.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index 68419843e32f..7b646a7808ce 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -37,6 +37,9 @@ Optional properties for child nodes: > property is mandatory for the LEDs in the non-flash modes > (e.g. torch or indicator). > > +- panic-indicator : This properties specifies that the LED should be used, s/properties/property/ Maybe phrasing it as "should also be used" might make the intention a bit clearer, as well. Robin. > + if at all possible, as a panic indicator. > + > Required properties for flash LED child nodes: > - flash-max-microamp : Maximum flash LED supply current in microamperes. > - flash-max-timeout-us : Maximum timeout in microseconds after which the flash >