From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-kernel@vger.kernel.org, rjendra@qti.qualcomm.com
Subject: Re: [PATCH v1 3/3] nvmem: core: fix regmap accessor usage
Date: Thu, 14 Apr 2016 17:48:37 +0100 [thread overview]
Message-ID: <570FC9E5.2050209@linaro.org> (raw)
In-Reply-To: <20160414151815.GG18024@sirena.org.uk>
On 14/04/16 16:18, Mark Brown wrote:
> On Thu, Apr 14, 2016 at 01:35:03PM +0100, Srinivas Kandagatla wrote:
>
>> I totally agree that there is an abstraction failure here in both sides. It
>> should be fixed. moving to using bulk apis would solve the nvmem problem for
>> now. But for long term, using regmap should be totally removed from nvmem
>> and directly use the reg read/write callbacks from nvmem providers, This
>> would be much robust solution. This was indeed Maxime's first proposal. I
>> will try to fix it up and see how it looks without regmap.
>
> OK, so just replacing all the _raw_ calls with _bulk_ for now? If
> you're doing that watch out for the fact that the reads come back native
> endian which might upset things.
Yep, that would confuse users. I think its better I do a long term
solution of regmap replacement with callbacks before someone else starts
reporting issues.
--srini
>
prev parent reply other threads:[~2016-04-14 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 17:39 [PATCH v1 0/3] nvmem: core: fix regmap accessor usage Srinivas Kandagatla
2016-04-13 17:39 ` [PATCH v1 1/3] regmap: add regmap_can_raw_read() api Srinivas Kandagatla
2016-04-14 5:58 ` Mark Brown
2016-04-13 17:39 ` [PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header Srinivas Kandagatla
2016-04-14 6:45 ` Mark Brown
2016-04-13 17:39 ` [PATCH v1 3/3] nvmem: core: fix regmap accessor usage Srinivas Kandagatla
2016-04-14 6:42 ` Mark Brown
2016-04-14 12:35 ` Srinivas Kandagatla
2016-04-14 15:18 ` Mark Brown
2016-04-14 16:48 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570FC9E5.2050209@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=rjendra@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).