From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932344AbcDNSz4 (ORCPT ); Thu, 14 Apr 2016 14:55:56 -0400 Received: from mail-bl2on0054.outbound.protection.outlook.com ([65.55.169.54]:35616 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753402AbcDNSzx (ORCPT ); Thu, 14 Apr 2016 14:55:53 -0400 X-Greylist: delayed 10524 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Apr 2016 14:55:52 EDT Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-5dfff70000000be7-6b-570fe768ecce Subject: Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg() To: Dan Carpenter , "James E.J. Bottomley" References: <20160414182034.GA32469@mwanda> CC: "Martin K. Petersen" , Hannes Reinecke , Johannes Thumshirn , Ewan Milne , , , From: Bart Van Assche Message-ID: <570FE7AC.9000309@sandisk.com> Date: Thu, 14 Apr 2016 11:55:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160414182034.GA32469@mwanda> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42JZI8azSDfjOX+4wesv0hav/01nsVi2Mtpi z6JJTBarJuZZPO6awWqx9Za0xeVdc9gsuq/vYLNYfvwfkwOnx4NDm1k8Pj69xeLxft9VNo/N p6s9Pm+SC2CN4rJJSc3JLEst0rdL4Mp4tPM1U8FqzorJ22YxNTBeZO9i5OSQEDCRWHPqE1MX IxeHkMBcJonVL26yQzg7GCV2LP/LDFP1t+EbK0RiKaPEzF1bwNqFBbwlepa9YQSxRQQSJFa/ XMgGYgsJaEscuLKXEaSBWaCVSeJG02awBJuAkcS39zNZuhg5OHgFtCSWrwXrZRFQlXiy/AaY LSoQIbF63TWwxbwCghInZz5hAbE5BXQkJi38CtbKLGAv8WBrGUiYWUBeYvvbOcwgqyQErrJK XPhyigniBnWJk0vmM01gFJ6FZNQshPZZSNoXMDKvYhTLzcwpzk1PLTA01StOzEvJLM7WS87P 3cQIiZ7MHYx3n3gfYhTgYFTi4X1Qwx8uxJpYVlyZe4hRgoNZSYT3yQOgEG9KYmVValF+fFFp TmrxIUZpDhYlcV63e1/ChATSE0tSs1NTC1KLYLJMHJxSDYw6sa9VkztfWgkEHm58Fd+stvnr B7fY7+fVJa8yTJhkGV8bM/e+x7rSQ/qrJtsLz0wN/f3ke+TSGx/S7F5LltWc09FJtzBpNXS8 nage8W1D3KE5M/V2vgt7/e2F3KmOd/v+Nhiffy6d8t2QWa3KQemsp+Li/Y8PTzyfKe7ad4XF fHr0FxP1iD9KLMUZiYZazEXFiQDD5cFPmgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHJMWRmVeSWpSXmKPExsXCtZEjRXfNc/5wgwMtihav/01nsVi2Mtpi z6JJTBarJuZZPO6awWqx9Za0xeVdc9gsuq/vYLNYfvwfkwOnx4NDm1k8Pj69xeLxft9VNo/N p6s9Pm+SC2CN4rJJSc3JLEst0rdL4Mp4tPM1U8FqzorJ22YxNTBeZO9i5OSQEDCR+NvwjbWL kYtDSGAxo8Szvd/YQBLCAt4SPcveMILYIgIJEkdPTmcCsYUEtCUOXNnLCNLALPCfUeLU8Waw BjYBI4lv72eydDFycPAKaEksXwvWyyKgKvFk+Q0wW1QgQmL1umvMIDavgKDEyZlPWEBsTgEd iUkLv4LZzAK2Enfm7maGsOUltr+dwzyBkW8WkpZZSMpmISlbwMi8ilEsNzOnODc9s8DQUK84 MS8lszhbLzk/dxMjOIQ5I3cwPp1ofoiRiYNTqoFRVSHeuPZdd62tcGpg1OkogUK2bKmzgU9K Co28z79tCvy7c9qBuY6KFvU/LI4oyRTpyb4P9DE4l6Bc8mOrxzsG/9P6X1mcufu7U+sWxDIf 0Xz5oEDsK6vVg3TzGc97OG7IBPAZFe91DV+ecf/s+w3f1jzbcm5Oh/+WJC4JhRq2GqVIwUvT 25RYijMSDbWYi4oTATyRI6gRAgAA X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(377454003)(24454002)(230700001)(54356999)(76176999)(87266999)(50986999)(4326007)(2906002)(36756003)(189998001)(5008740100001)(106466001)(65816999)(6806005)(23746002)(586003)(86362001)(53416004)(50466002)(65806001)(87936001)(19580395003)(19580405001)(80316001)(2270400002)(11100500001)(33656002)(2950100001)(1220700001)(4001350100001)(92566002)(1096002)(47776003)(5001770100001)(5003600100002)(81166005)(77096005)(65956001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0201MB1869;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD054;1:uxEaEU+EI0rDRkrnZU/GITQOgWle8oWz+zycHRR9VCMBBdF+FR3RPPqWX0iEccfamg7pInNg/VCWbqZf16c7jQ4/euP9CLh24TpsOFx69mTZxfKjfw0YFp74sUgFWRW0mhsfYuAJ8q3ObaMkExiKXeHKda0VcYpHhT+HOss7bpK9idXYIJaw15YPW+wLFm5KO6PFpuLq/dvIgQiCUM4l/xvG3xw4iWuDRKfoP2BYzpKXIr+1jVHE77+nahSYGq7ufI10lVtCl7zUNs/NqX0O+6MykdjtXHojKCifugtiA5YorRQ0obn3dUoLrY4c1dQum5XmiG5B3+clrSddW6Wc+BwjWEN1uLYZFE+U9TP7JuGpWwg81LTCG2O8zhh7+vpV7ZdwvA+wnV75tCZQfANQw7CU5rZDMdPUM4K95lkgmnTes9aK6WbDCTX/2WwhzxmP+MIOzPiUUn2VI1QKDnvEFYvcX4ruVjn9w3sADID9qS4= X-MS-Office365-Filtering-Correlation-Id: c13df200-4c9b-4609-91a5-08d3649664e5 X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1869;2:jCvFGD7X/FC4z+7+4OqOoUxYIpkN3q3tAt/qW7hEk5dYOF6k7i64Wx91Kbpy3WyqpgdzxX3WFs/rcw+TRJHHVgW1BOpYp7R7Ixh1V1j6Kh38WeTciZY1h3dvBdsqUN5pCNEVgFaPAI8mk5FaR7x0xzFJsqMPC3Bm2KsCYWTMVu5nuCl8hZZt4QRR7JWUyYo1;3:R0SbNSA15EU2JOyh6RygN3XYaIy0hItj924mqimVCaEbnu4ANHT6ZGcuGef93z3gcH2Uww8UtytoaeU15Afvf3XdGzo8ss8jo0ERh+V+WzloVFRy1IsjbPEG/bNtg52OJxjZMJvMwbe3u/z8Fxad64F3AGEtBZuj8XzCidrjq4dgF/27jE2L5+0sKLaGJ8FCGQP/wWWvZrqFwG/6vApmXNL0qHJXtMaeNORlMhur+uIrtKJ3/9VHCrwK2W6P5iCpa+tkxh7I76IGawkLKQtOpQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN1PR0201MB1869; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1869;25:9QzZ4RwxcneZ2xsfkOXRCiRsKjvR3DfNNxapjVqWxzU9TkoaU1RovsGHAhI7KikHzTidGgl5vbUxKGY5m2+A0yoBm4FEiguyBtynQG/1UbnpHW3GWJOxXHEhfN+JG8WKRztLnapN3wBioQZ9V7xL/en2N55h+tb35iQXZv0CcncE8ue61trNhBEtTVMA93XPn+v9e9vsBF6cTkgZK9LAGF0WnZ6WEzgZA4EPGqo4vbUsmQldHYbU3eYdbNiXtN3jJfNUOGkTiAgBufe3Yh54joM3ldWY+L6Vo0HMbKPStI/OREhctHtyld9zoDcAP3VuW2NCOdEgAzSrRWTP39WdzI1Qm3OFeqWdsU6ny/0f4pIqVKYqP24MFZ/kVJM1WQMZS8cFgR2gMqoFbOP1SMoa7Wi+B/zgXsU3LBH8IWjO4fplxNJnv/JfoHG85kjIgnCf7XgBloAXJC1F6Lryf6atUSYRC3EGpId87lFlqSITzVD3R64453Ih2lmRaBQmBQ2SQfzf7Chw3gSBmsobWCgrIbbsiWWEQ9uCatYPHDyMuwk/JNJa/5YqUkF3YGy7vLCagCRUUp/qU6jrZLTyxyx26oG8xB7Yithobjp3j0TOYSc8f1hryDlQ/0nFRrPpa8gqq8/fqu/mdJOXhk1EZfwtgBD6QEMqRRFDcq1qdky+JK8Q8gdcK3HXJ/anfeSMVcWi X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1869;20:izqAJ9kq9rAoLpUPHEl+zQu9Eol/rJBnfN661hSLoIyokijivfBG/5taUaVmoxFrE6cr37maKDgAN2W68jSlbdWiZVAi/jDt5BT6FnlWAJ+H0V3ykd/RpeU7aD6rjo/kDxJzfAjx0i9jE1m42fjR3GcqFuNNgmN2NNMe6sj4Y81i5EMEctDnGaU8mFM/AOjlIw7eSBagR1eL3tBaTGJKcIvsD77x7kjlMhf4GK7xw+UEwEPTZvia59iD0cR/t+8uNE61WAFW6ApXnlEYa6FoAs4k8Gwc6CgC70koQJoEpMINl2TG3HYnISY6UikVwyn/fPYeN9HMV9Bfpyw7odHsXjutLtUNEBAvMnE4eXO29HYOo7X5f8Y2oRYwjMJf8sb2gIjTBtaEJD/RqfFoba/uncC6YAdDwUyRN8dN9NSihAgH+BEs6LYgwX75rOvLo9i8EIv+bsX/oBn6wI02oxT8+nc7rUU5Sy/vuhkwdz9pWacLNtCn2+3S+pS+DLlgWMCM;4:y75oDrX/l/VYjrMi0RwveU0li+HkcU3MNbuAI46q+Pgg2oIy1lJH7YlVb1pWUB7eqjykDk2tZXOZg1gN0SizkL4m/97Qx8YuZ9kylzyRnf1PYZzB19iicdXul1h8IHivR7xWCi1uuouUcr5pCB+69eRlFZOXqdiiYIA4lSYym0SFH/VpWTCrkszm7qXth88fn2Lb0AnEV/tXjk9q3RGcIvkwn1lj6QYdqMeCdzlTcqbnFKZbYaxUWNaiuT/zxsrod+ir43GfUhk9FSA9p08waGmiqc2YQvATt1fCwimBQOGznoWecuiu+cB/cmdfx2LH0Wz98fB9jwtnn12b8cH9TIsKBX5CDY3QvNgNGGyjYY00VxujxV6iiunBldcXBqTpi2P0bhJTLB+Lt/Y8AeV9LjtLy1HvyyuKZfHRiySpB8Q= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(13018025)(5005006)(13016025)(3002001)(10201501046)(6055026);SRVR:SN1PR0201MB1869;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0201MB1869; X-Forefront-PRVS: 0912297777 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR0201MB1869;23:ascmU2fKMlzHXyQwlIeYmtB422GwVyg6lzf?= =?Windows-1252?Q?OF5ETiGatdoZUxgokantR2S6GehfgUX2RtFodC3NLon+sFDBY8sxm5mk?= =?Windows-1252?Q?dNNpcV/W7cJ/VekEAp3VCuqGxo+UEXnkT8/In+9CBuOm6+Zbl3UtGe0W?= =?Windows-1252?Q?6qB62Y0/0yankZz+vaH7jMQJd277JdH3PpgeHJ53Y8Y038aOt0vPSWMc?= =?Windows-1252?Q?CKlpFsUcTbvHxgaL7bGkC/SVQ3Cq8kuxb7olGtYxHDV7bCdcGrGY4cWx?= =?Windows-1252?Q?2YRTBcJnRHIDXYQKLAgm4F2VFywQAc/rcUaVyxKD5ClSV1I3BtkLEUSS?= =?Windows-1252?Q?kgc7nXfb/xloXj/sSAyhaZ2V5Z5GMCnIf18uMsSP36Gi3bbv59uAvJMi?= =?Windows-1252?Q?jNMc8jrvnp2PNm7ThLoOUqaUrtVyKc4N9Fl+foiHLuZgZEVSPtCQHm9X?= =?Windows-1252?Q?tU17qVQ/6cp5gIJlkvwuji1JEyD+1VBVInQO2YSZkZv69P7znBRfXPi+?= =?Windows-1252?Q?aSRVhTx6hF1KtrKUixYj5wJKY8p1LgkXpbqkO6ZkKgOX9CM/3SPMQEVl?= =?Windows-1252?Q?9Kn3a4An/H66B+b/W0KFDcf8gCkQOb4MeYkoY+1RcjgjDH+heS8rXkem?= =?Windows-1252?Q?c/vviguKvUNHhaT44hicJFFD7wD2HMfOFqpnnkybdgYPmjdBrqTvU3MJ?= =?Windows-1252?Q?QY/1xyVHhr/sz+YH4bXQvoGmWJ2s7yIFjn9mfhHEwzcaFkbOyQuHcR6H?= =?Windows-1252?Q?6OXHkufEB585PWCTkOanYPKcqn5zeVvF5uKdo9P8W1T9TK/v3xEt5dT9?= =?Windows-1252?Q?ULc40CiQ2up3pREj525YNTvS/2Cd9KvH+SNLiyKDwqV/+S8qV4PaR/KO?= =?Windows-1252?Q?oYLbmQHB7rwCBrOtGc14Oruke41/Gp8clEKmF8ARO9zdwIgJ+mMc7W6u?= =?Windows-1252?Q?2ZOS5nJNidn1mcX4ZRSgdQavGj/uLmhvZaVLdE62k1BqGl2YlbRBBvCP?= =?Windows-1252?Q?OZp1Ixdn9SachQkWx4WPyBHbzSw9xBiG68LFNvCUtUbxpN8gUD6g+BE3?= =?Windows-1252?Q?T5TgPZen8vvkDWkWtAKSUct9Wvr6Zmq7QwR7senYdPfi/PTyL4GSZeFg?= =?Windows-1252?Q?Kvj8pyV2nkgVRL/ZzkXsUrvms+iS7vvn8Oqg7cIlQ02LqES9yvTWw5BJ?= =?Windows-1252?Q?TGZ/Wg+kB/bjb9byMGPQNu4es22GU4SIh1ABMjLD4yrmk9qjWj/ZCZ0i?= =?Windows-1252?Q?xoBQp3WxPKxdhGjCaNA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1869;5:j32ym/XBbvFKBxpXBuLMA1HKdMf5LzKDOIrYY1MqMTcJb6wIlyVSjXtazv51Pa0STc9nQZ3Syg1KqITzW/kELwJuAnZRzzmlrFcxsAcz7BOniLUIi7hBR/q5DWU7yW2U6ksuvAMe7wyA7RvMSvUJCQ==;24:nfAr9k0AwmBVJM0UT0PBCP0f2xIeBpzgpivD7N+F5rPh/fYRdAgmhO6mm1lSMoklzl7fsO5yEDFLgedQl8bkqqeaGIiniGdy7RqfBk1S77A=;20:R23S6R6lbkUr7a4zh9sJlXgus7IqCm8KzZydHC/vcV9DueENgaoxwKLfptyRTk/c32Ma5RvvOARx8BG4R6YPP7V7Rg27otBNiD6DcSkRIt0H4zpD2GD4cWXOoVo75yOno5EbMCUC9Yg2icN6M9syzwtvoli5AVl2tJ2t+KPk8Tf6aigPU/2biEuJjyWn0M5f8DKTIZUY0sKK85QqkbDOpOhz98waTY9FsSj2M1QQU33UhVua+g1VTGpb2/CQ1F89 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2016 18:55:41.4663 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1869 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/14/2016 11:20 AM, Dan Carpenter wrote: > It's possible to use "err" without initializing it. If it happens to be > a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Van Assche > pointed out that we should probably re-initialize it for every iteration > through the retry loop. > > Signed-off-by: Dan Carpenter > --- > v2: The first version just initialized it at the start of the function. > > diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c > index 8eaed05..a655cf2 100644 > --- a/drivers/scsi/device_handler/scsi_dh_alua.c > +++ b/drivers/scsi/device_handler/scsi_dh_alua.c > @@ -532,6 +532,7 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg) > return SCSI_DH_DEV_TEMP_BUSY; > > retry: > + err = 0; > retval = submit_rtpg(sdev, buff, bufflen, &sense_hdr, pg->flags); > > if (retval) { Although I would have preferred that that initialization would have been closer to the other 'err' assignments this patch looks fine to me. If this patch does not get integrated in kernel v4.6 a "Cc: stable" tag will be needed. Bart.