From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753848AbcDOJDx (ORCPT ); Fri, 15 Apr 2016 05:03:53 -0400 Received: from mail-by2on0078.outbound.protection.outlook.com ([207.46.100.78]:54855 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753789AbcDOJDr (ORCPT ); Fri, 15 Apr 2016 05:03:47 -0400 Authentication-Results: collabora.co.uk; dkim=none (message not signed) header.d=none;collabora.co.uk; dmarc=none action=none header.from=amd.com; Subject: Re: [RFC 1/8] dma-buf/fence: add fence_collection fences To: Gustavo Padovan , , , Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Rob Clark , Greg Hackmann , John Harrison , , , , , Maarten Lankhorst , Gustavo Padovan References: <1460683781-22535-1-git-send-email-gustavo@padovan.org> <1460683781-22535-2-git-send-email-gustavo@padovan.org> <20160415080254.GQ2510@phenom.ffwll.local> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <5710AE61.9040308@amd.com> Date: Fri, 15 Apr 2016 11:03:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160415080254.GQ2510@phenom.ffwll.local> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2a02:908:1250:ae81:a009:99b1:caa5:4f17] X-ClientProxiedBy: AM3PR01CA057.eurprd01.prod.exchangelabs.com (10.141.191.47) To SN1PR12MB0141.namprd12.prod.outlook.com (10.162.3.140) X-MS-Office365-Filtering-Correlation-Id: 17389790-94a3-4774-1dc6-08d3650cd8da X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0141;2:d0kbRhmCHzWE1pzm6JYO4QRCU2/a2AGyF3/umIb5MpaogK7oXmKaIZc3E6MugdiwjDv8IV1jlqOh6demwi3txodV3QQrNkuKpAIWRk1uQBXn/5AuYWdEICTr88Wq0u7av1a+fCz8OQtPACeF02uhPVJXlNhieQZkGgg086Zs02rTkcPOIM18wGA8nnCZFd0f;3:OBJZVWizWVILXZn1C/P8d8XJ2xlNXB6kLv0NiTvE93tBGWW8zylg2FWk3+5D7WNLvf6yDUJ8plvnQypONIVP/XAglhRCLOeoPoUUfxWfZqVnjzOfco/F4PHOnAGI7d4+;25:XD/f4fZzvfObRPw5YIi3mwrWT3eWSlX/c8bU9/w6Qik9pea3gwTSuWOI4d8YSUWPRFs65UoPk+1LiDuvheuxdFqS2VUS9JJpQdedICpwlWo0vhczQaq54jXcLPMkwP/NwbKzlLCTb3HcKfH7VWicJ7oJLKrBaE9Aqq91cYAEHXOiNVMXO1USeAmDWnEg64ov31RcoaAecXjFVxXno54sscrnhnZ5IW7SQao7Q07Hr+VTgMtYtzzbyM2hhCxgq02hN0NFvRevRQ9fhtjHBsdraQHap6ohOwA8vHCCaP0ixch4UWV3nr3U1qMiaEb6PFDlSjpc35MiinsvG3ZfrBWzDw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0141; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0141;20:uNwj4bk2VTh3/mBkiX0KIwZo4wqYmpu+iqaJSCZK/5nV+yv5hWQ2jgClwTcFkU+aexkVV9FbRd6kjNb2PRE8plvVXPX3tM9iuUSCI4dyZOEJw78zDWbaDbG06nb5sITKqv41F//6jdNMdPmWUiE4Yrk202FbppMg8r63ibKehsDdGL4FtF23m0DQG4gQrhZ0byemvDkXJZRdCP2aDSSFhrH1hBmpt9Yo4W/YCY/9LLeoAPX/eiOaqUHlxyt7AtASct8n3FPt4hOsvEYf2Y8+BV9klk6bio6+IrwEyDQeXdxwVXfXGH4Y17icTgG1iYzlhxMAQ2sRublroQid7x83HiWDABIsEmUDt6fCt9CU5Q/Fl+a28igZty/yKfhegFugRkxVddjeFqQABjkxWk4vX5cLJ3GeReT1hmFl+6JjQZ+IPRI0fq4/Lh07THsExP/RiImbgFu8oTbwUSgAFPU9aFOIrTrlvkQhOgBMtUftBaS+EcfegVzaN6iR8LE/bki8;4:bGi2tneT/tny3lqV515yuBGwkuJg3pSAuWxpoC+FPze3/sG7QFZP3MllNUvGrWC0PwzyPfmco61WyZTYhThi4mZssLumLOD5uou03Cpi+legBgE0uRyqyq+Y2KbIZAabJuFL6+vd8REuhoQf8rdP+GMUlkbKCjxHCubN0gvgEVlx7F4e0k2z3RnSkGGjyY8XLfQBTCj7Fl6Qm29/0Xm6fbEZfg37Uw6q2/Ei/tjrQs2yGCrtclGR9nIBGvMeThQVkBBd+yXuKYxFzgnZjpg9d6oggu18IRKCh2wR0IlDG/WcGIhqN6gzqhjZ5AQVUF+mgH63NNgqxtAnPJevmFUvBilmWXM6uG1/Z95J6lbfAbvMB/2vHf0091LjqaFpKNlltsFHi5V69K3vjKm/wOhh2wbM1UfzPPNUF1uep/g3YNY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521026)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:SN1PR12MB0141;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0141; X-Forefront-PRVS: 0913EA1D60 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(5001770100001)(42186005)(64126003)(33656002)(5004730100002)(4001350100001)(59896002)(2950100001)(23676002)(50466002)(586003)(86362001)(2201001)(65956001)(65806001)(2906002)(1096002)(189998001)(6116002)(5008740100001)(47776003)(81166005)(77096005)(230700001)(83506001)(80316001)(19580405001)(54356999)(87266999)(50986999)(65816999)(76176999)(19580395003)(107886002)(92566002)(36756003)(921003)(2004002)(3826002)(1121003)(2101003)(83996005);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0141;H:[IPv6:2a02:908:1250:ae81:a009:99b1:caa5:4f17];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTQxOzIzOkovVlZHVlJwRklaVzAyNzJ1dFZLZ3NWOFlD?= =?utf-8?B?OExXU0VwZ0ltYitkKzA1TUl3NmpNVnl5V3U0MFFLbWkrVHorbGZjb3hkZGlV?= =?utf-8?B?a1AySEZjNlpVTjFwZThxd1o2MzUwL0Z1aWhoaEhEZmhLdW9oUDJrZytMdWJw?= =?utf-8?B?SFZGaDFoWUlqU0RQTFdZT3A3L3YvVzZPNUtMdGw2NXJQaEVBMHRsTWl6WnZR?= =?utf-8?B?d284TUlENW0xVFBUczhXYVVNVHVFMGlzSG9uWWRJaTN3ZFN1MlVpbXlvVUdQ?= =?utf-8?B?aDJmcWJscnlZQXBWeS91N0lSN3BSSEExNlpWV0J4NCtZSGQrSTRWY2FWVlRk?= =?utf-8?B?bW5YcHZnTUtuWGV1VmpYeDAvTHlqZ3BBNm5BNlZOTmkvZFMrZGtkTit4Tlli?= =?utf-8?B?SHBNWXpveFgrYTVtUDRhNFo0SnZaT3ZZMkhoYytzOHZKd1ArOGt1eWpHeFFY?= =?utf-8?B?VWR4a1R2RGl2ckZ4dlJSZE0xZ1BDOVI2RzlYV29pODE1SysycDNNQWFqSEFF?= =?utf-8?B?aG9kQVFzT2NEaWNEMTg1R3pna2QwZ2EvQmVTdDd3VXNTa2dOWDh4SWNnOWJW?= =?utf-8?B?Uk1TTmU5N1pOeHhXb1pzUWdRZFFGMGhZM1lSNTlJd043QjU2WktNRnJNYXJM?= =?utf-8?B?cVR0M3l6STBDK240ZlhiS2ZFYTB6UFhaaC9lMldjL294UEVkR1B4T2p4MG5X?= =?utf-8?B?MWZtVEQzQXIzT0hLd2dwQU56OXJTalpTc1dyaTkzTkp6bHNvNEtmRUpPVUFB?= =?utf-8?B?bTFHd1FVUUVEU0JBa0pjMlJGMzE1NmtKWHFFMzgrK01Ka0pFZWgwQnMxdm5T?= =?utf-8?B?QnEwdi9qbVpZcUFmb1I5a3AzbmE3TFVQU2gxUGFDNFUvN1RxRDJRdVIxQXR5?= =?utf-8?B?d2F3RHFZZGxObE5qa201WmN3YzBxdjdBV1hqL1dQSE5JZlcvMUdQTVNLbWk0?= =?utf-8?B?SDJuanZTa0VXK3lTY2VDUGhJQXBMUTIzYTVtcUpYWC9sUVByNTZ6MC9NanNs?= =?utf-8?B?UGoxWjFieTVQQzdIc05sZys0M0FKdk1mR3pUZlNNVmRyeXFxRW5RMWdQSGd6?= =?utf-8?B?RVlMcHdFaTNTWllBT2pGeDBFbGJCUjZHUjFNQ0hZSWZ6ZmhETlZIS3p3MVFW?= =?utf-8?B?Uzh3OTgvU3c0bEFoeFBnb2puMXRmNjJGck9nUlV0algxVWUyOWkzY2lXYTNN?= =?utf-8?B?NjVJM0FhaXE2dWIrdi9KQWpDWHJQRWVUK2Y1RGdNMkNRak5xNVEwQjNPNFdX?= =?utf-8?B?R0tRMWwrbldkU2pIa2pINm9JOFJKb2lhSFdXZHp4eDFYT1ljOGlBTWxEbnFI?= =?utf-8?B?b05NVDdsMzQ5YzA0c05jNC95b09zOWJadkd4bFZxTS9oZVpyYzVPN2N0TEtj?= =?utf-8?B?cUZlVDBxc0x5QVFZdG5nZUl0VDJicmdHU1A2VGZSQkxXblZZeEtscXArU2Nh?= =?utf-8?B?Mlp4TXc4a0VJU2RQeVBwZXIwNWFDNjcxU1NEQkZqUk1kVzh2WFBTWC9Cczlu?= =?utf-8?B?UGw0Nnpzb0wwSmdnTW9iYUUzam0rcXdTVFExMEVjREJFQWc2VFZ1Zkw5eGh1?= =?utf-8?B?UWgvVHJBR2svemY2OThMNVMwcTBobmc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0141;5:4kia3O8NhSLMD0z19MFu0UVa1xCYkJIGPj7PNDXCtphTuS6Hw+jJnavMZobczOqQJ/uuQhn2NvHyA8TLohtriHJwPLy4mty3MHJKBp6WXkTKlvsbxlidRMrwDMTGVnTLpPn12wOzqKGmOBsHpCFnUA==;24:ZTEyilFVSXeSId8eKWrAHfGQEf/o6zYkcoNTvdhu7nx0s1s095qYd8nJksn69I5u9LxeMRhs3jPiCTjWuZvrAs1R+cMUTn4jeI34xSeyrN4=;20:GCcO2rGJyCTQyFAQoDc82h5UtgCS2OikxfHl3gCjBwF8hlRqjAry4+noztq5y/EyAg+Vce+ydNqv5OzSsdDwXGS2jSDXNlKXz85A+qYy75PUINjVPetRVsyL8QbYD7Afb076+LQH/sl7P5ImP3Mw91LWgQyRRuRmm1x4Vlcqljj+/kmkXWFb9TW0duFbQpcYP3UAB0T+j0xkHRGiLxa8Ae9Rrq2Wnq80hAvIBkUgfSF+3fNJV+NreVeGmN5R4sxT SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2016 09:03:41.4057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.04.2016 um 10:02 schrieb Daniel Vetter: > On Thu, Apr 14, 2016 at 06:29:34PM -0700, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> struct fence_collection inherits from struct fence and carries a >> collection of fences that needs to be waited together. >> >> It is useful to translate a sync_file to a fence to remove the complexity >> of dealing with sync_files from DRM drivers. So even if there are many >> fences in the sync_file that needs to waited for a commit to happen >> drivers would only worry about a standard struct fence.That means that no >> changes needed to any driver besides supporting fences. >> >> fence_collection's fence doesn't belong to any timeline context. >> >> Signed-off-by: Gustavo Padovan >> --- >> drivers/dma-buf/Makefile | 2 +- >> drivers/dma-buf/fence-collection.c | 138 +++++++++++++++++++++++++++++++++++++ >> drivers/dma-buf/fence.c | 2 +- >> include/linux/fence-collection.h | 56 +++++++++++++++ >> include/linux/fence.h | 2 + >> 5 files changed, 198 insertions(+), 2 deletions(-) >> create mode 100644 drivers/dma-buf/fence-collection.c >> create mode 100644 include/linux/fence-collection.h >> >> diff --git a/drivers/dma-buf/Makefile b/drivers/dma-buf/Makefile >> index 43325a1..30b8464 100644 >> --- a/drivers/dma-buf/Makefile >> +++ b/drivers/dma-buf/Makefile >> @@ -1,3 +1,3 @@ >> -obj-y := dma-buf.o fence.o reservation.o seqno-fence.o >> +obj-y := dma-buf.o fence.o reservation.o seqno-fence.o fence-collection.o >> obj-$(CONFIG_SYNC_FILE) += sync_file.o sync_timeline.o sync_debug.o >> obj-$(CONFIG_SW_SYNC) += sw_sync.o >> diff --git a/drivers/dma-buf/fence-collection.c b/drivers/dma-buf/fence-collection.c >> new file mode 100644 >> index 0000000..8a4ecb0 >> --- /dev/null >> +++ b/drivers/dma-buf/fence-collection.c >> @@ -0,0 +1,138 @@ >> +/* >> + * fence-collection: aggregate fences to be waited together >> + * >> + * Copyright (C) 2016 Collabora Ltd >> + * Authors: >> + * Gustavo Padovan >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License version 2 as published by >> + * the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, but WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> + * more details. >> + */ >> + >> +#include >> +#include >> +#include >> + >> +static const char *fence_collection_get_driver_name(struct fence *fence) >> +{ >> + struct fence_collection *collection = to_fence_collection(fence); >> + struct fence *f = collection->fences[0].fence; >> + >> + return f->ops->get_driver_name(fence); >> +} I would rather return some constant name here instead of relying that the collection already has a fence added and that all fences are from the same driver. >> + >> +static const char *fence_collection_get_timeline_name(struct fence *fence) >> +{ >> + return "no context"; >> +} >> + >> +static bool fence_collection_enable_signaling(struct fence *fence) >> +{ >> + struct fence_collection *collection = to_fence_collection(fence); >> + >> + return atomic_read(&collection->num_pending_fences); >> +} >> + >> +static bool fence_collection_signaled(struct fence *fence) >> +{ >> + struct fence_collection *collection = to_fence_collection(fence); >> + >> + return (atomic_read(&collection->num_pending_fences) == 0); >> +} >> + >> +static void fence_collection_release(struct fence *fence) >> +{ >> + struct fence_collection *collection = to_fence_collection(fence); >> + int i; >> + >> + for (i = 0 ; i < collection->num_fences ; i++) { >> + fence_remove_callback(collection->fences[i].fence, >> + &collection->fences[i].cb); >> + fence_put(collection->fences[i].fence); >> + } >> + >> + fence_free(fence); >> +} >> + >> +static signed long fence_collection_wait(struct fence *fence, bool intr, >> + signed long timeout) >> +{ >> + struct fence_collection *collection = to_fence_collection(fence); >> + int i; >> + >> + for (i = 0 ; i < collection->num_fences ; i++) { >> + timeout = fence_wait(collection->fences[i].fence, intr); >> + if (timeout < 0) >> + return timeout; >> + } >> + >> + return timeout; >> +} >> + >> +static const struct fence_ops fence_collection_ops = { >> + .get_driver_name = fence_collection_get_driver_name, >> + .get_timeline_name = fence_collection_get_timeline_name, >> + .enable_signaling = fence_collection_enable_signaling, >> + .signaled = fence_collection_signaled, >> + .wait = fence_collection_wait, >> + .release = fence_collection_release, >> +}; >> + >> +static void collection_check_cb_func(struct fence *fence, struct fence_cb *cb) >> +{ >> + struct fence_collection_cb *f_cb; >> + struct fence_collection *collection; >> + >> + f_cb = container_of(cb, struct fence_collection_cb, cb); >> + collection = f_cb->collection; >> + >> + if (atomic_dec_and_test(&collection->num_pending_fences)) >> + fence_signal(&collection->base); >> +} >> + >> +void fence_collection_add(struct fence_collection *collection, >> + struct fence *fence) >> +{ >> + int n = collection->num_fences; >> + >> + collection->fences[n].collection = collection; >> + collection->fences[n].fence = fence; >> + >> + if (fence_add_callback(fence, &collection->fences[n].cb, >> + collection_check_cb_func)) >> + return; >> + >> + fence_get(fence); >> + >> + collection->num_fences++; >> + atomic_inc(&collection->num_pending_fences); >> +} > For the interface I think we should not split it into _init and _add - it > shouldn't be allowed to change a collection once it's created. So probably > cleaner if we add an array of fence pointers to _init. Amdgpu also has an implementation for a fence collection which uses a a hashtable to keep the fences grouped by context (e.g. only the latest fence is keept for each context). See amdgpu_sync.c for reference. We should either make the collection similar in a way that you can add as many fences as you want (like the amdgpu implementation) or make it static and only add a fixed number of fences right from the beginning. I can certainly see use cases for both, but if you want to stick with a static approach you should probably call the new object fence_array instead of fence_collection and do as Daniel suggested. > Other nitpick: Adding the callback should (I think) only be done in > ->enable_signalling. Yeah, I was about to complain on that as well. Enabling signaling can have a huge overhead for some fence implementations. So it should only be used when needed > > Finally: Have you looked into stitching together a few unit tests for > fence_collection? > > Fence collections also break the assumption that every fence is on a > timeline. fence_later and fence_is_later need to be adjusted. We also need > a special collection context to filter these out. This means > fence_collection isn't perfectly opaque abstraction. >> + >> +struct fence_collection *fence_collection_init(int num_fences) >> +{ >> + struct fence_collection *collection; >> + >> + collection = kzalloc(offsetof(struct fence_collection, >> + fences[num_fences]), GFP_KERNEL); >> + if (!collection) >> + return NULL; >> + >> + spin_lock_init(&collection->lock); >> + fence_init(&collection->base, &fence_collection_ops, &collection->lock, >> + FENCE_NO_CONTEXT, 0); >> + >> + return collection; >> +} >> +EXPORT_SYMBOL(fence_collection_init); >> + >> +void fence_collection_put(struct fence_collection *collection) >> +{ >> + fence_put(&collection->base); > Not sure a specialized _put function is useful, I'd leave it out. > >> +} >> +EXPORT_SYMBOL(fence_collection_put); >> diff --git a/drivers/dma-buf/fence.c b/drivers/dma-buf/fence.c >> index 7b05dbe..486e95c 100644 >> --- a/drivers/dma-buf/fence.c >> +++ b/drivers/dma-buf/fence.c >> @@ -35,7 +35,7 @@ EXPORT_TRACEPOINT_SYMBOL(fence_emit); >> * context or not. One device can have multiple separate contexts, >> * and they're used if some engine can run independently of another. >> */ >> -static atomic_t fence_context_counter = ATOMIC_INIT(0); >> +static atomic_t fence_context_counter = ATOMIC_INIT(1); >> >> /** >> * fence_context_alloc - allocate an array of fence contexts >> diff --git a/include/linux/fence-collection.h b/include/linux/fence-collection.h >> new file mode 100644 >> index 0000000..a798925 >> --- /dev/null >> +++ b/include/linux/fence-collection.h >> @@ -0,0 +1,56 @@ >> +/* >> + * fence-collection: aggregates fence to be waited together >> + * >> + * Copyright (C) 2016 Collabora Ltd >> + * Authors: >> + * Gustavo Padovan >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License version 2 as published by >> + * the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, but WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> + * more details. >> + */ >> + >> +#ifndef __LINUX_FENCE_COLLECTION_H >> +#define __LINUX_FENCE_COLLECTION_H >> + >> +#include >> + >> +struct fence_collection_cb { >> + struct fence_cb cb; >> + struct fence *fence; >> + struct fence_collection *collection; >> +}; >> + >> +struct fence_collection { >> + struct fence base; >> + >> + spinlock_t lock; >> + struct fence_cb fence_cb; >> + atomic_t num_pending_fences; >> + int num_fences; >> + struct fence_collection_cb fences[]; >> +}; >> + >> +/** >> + * to_fence_collection - cast a fence to a fence_collection >> + * @fence: fence to cast to a fence_collection >> + * >> + * Returns NULL if the fence is not a fence_collection, >> + * or the fence_collection otherwise. >> + */ >> +static inline struct fence_collection * to_fence_collection(struct fence *fence) >> +{ > Kerneldoc claims it, but you don't check that the fence is indeed a > fence_collection. That's usually done by comparing the ops pointer. > >> + return container_of(fence, struct fence_collection, base); >> +} >> + >> +struct fence_collection *fence_collection_init(int num_fences); >> +void fence_collection_add(struct fence_collection *collection, >> + struct fence *fence); >> +void fence_collection_put(struct fence_collection *collection); >> + >> +#endif /* __LINUX_FENCE_COLLECTION_H */ >> diff --git a/include/linux/fence.h b/include/linux/fence.h >> index 2b17698..02170dd 100644 >> --- a/include/linux/fence.h >> +++ b/include/linux/fence.h >> @@ -30,6 +30,8 @@ >> #include >> #include >> >> +#define FENCE_NO_CONTEXT 0 Might be that how amdgpu uses the fence context and sequence number is a bit questionable, but this will completely break it. So we need a fix for amdgpu as well before this can go upstream. Regards, Christian. >> + >> struct fence; >> struct fence_ops; >> struct fence_cb; >> -- >> 2.5.5 >>