Re: [PATCH 5/7] soc/tegra: pmc: Register sub-devices of PMC

From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: thierry.reding@gmail.com, linus.walleij@linaro.org,
	gnurou@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
	jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 5/7] soc/tegra: pmc: Register sub-devices of PMC
Date: Fri, 15 Apr 2016 10:31:23 -0600	[thread overview]
Message-ID: <5711175B.8000701@wwwdotorg.org> (raw)
In-Reply-To: <1460473007-11535-6-git-send-email-ldewangan@nvidia.com>

On 04/12/2016 08:56 AM, Laxman Dewangan wrote:
> Register sub devices of the PMC to support multiple functionalities
> of PMC.
> The sub devices are the subnode of PMC DT node with containing the
> compatible string of sub devices as follows:
>
>          pmc@0,7000e400 {
> 		pmc-pad-control {
> 			compatible = "nvidia,tegra210-io-pad";
> 			::
> 		};
> 	};
>
> In this pmc-pad-control is the sub device of PMC and the device
> compatibility is nvidia,tegra210-io-pad.

Since I don't think anyone has mentioned this point on the public lists, 
I'll echo the earlier internal discussion on this patch. I think the PMC 
driver should handle this all entirely internally. The PMC HW module 
doesn't have well-defined sub-modules, and hence we shouldn't represent 
sub-modules in DT. DT should represent HW structure, not Linux SW structure.