From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892AbcDRQxA (ORCPT ); Mon, 18 Apr 2016 12:53:00 -0400 Received: from lists.s-osg.org ([54.187.51.154]:60897 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbcDRQw6 (ORCPT ); Mon, 18 Apr 2016 12:52:58 -0400 Subject: Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards To: Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1460965453-5337-1-git-send-email-k.kozlowski@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: <571510D5.3090406@osg.samsung.com> Date: Mon, 18 Apr 2016 12:52:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1460965453-5337-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 04/18/2016 03:44 AM, Krzysztof Kozlowski wrote: > The bindings like s2mps11,buck6-ramp-enable or s2mps11,buck2-ramp-delay > where ignored. They were never parse by s2mps11 regulator driver. Also > the values used in these bindings were equal to default reset values of > S2MPS11 device. It is safe to remove them. > > Signed-off-by: Krzysztof Kozlowski > --- The patch looks good to me. Reviewed-by: Javier Martinez Canillas On a related note, the s5m8767 regulator driver parses similar DT properties ("s5m8767,pmic-buck-ramp-delay", "s5m8767,pmic-buck2-ramp-enable", etc) that are not in Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt. So those should either be added to the binding doc or removed from the driver if are not correct (I don't have documentation for the s5m8767 PMIC but the DT properties are not use by any DTS in mainline using the s5m8767 PMIC). Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America