From: Hans de Goede <hdegoede@redhat.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andy Shevchenko <andy@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Darren Hart <dvhart@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] software node: Introduce software_node_find_by_name()
Date: Mon, 19 Aug 2019 14:46:32 +0200 [thread overview]
Message-ID: <5717e1e8-ffd4-e97c-0837-70b30391020a@redhat.com> (raw)
In-Reply-To: <20190819100724.30051-1-heikki.krogerus@linux.intel.com>
Hi,
On 19-08-19 12:07, Heikki Krogerus wrote:
> Hi,
>
> There was still one bug spotted by Andy in v2. The role switch node
> was not removed in case of an error (patch 2/3). It is now fixed.
>
>
> The cover letter from v2:
>
> This is the second version of this series where I'm introducing that
> helper.
>
> Hans and Andy! Because of the changes I made to patch 2/3, I'm not
> carrying your reviewed-by tags in it. I would appreciate if you
> could take another look at that patch.
>
> I added a note to the kernel-doc comment in patch 1/3 that the caller
> of the helper function needs to release the ref count after use as
> proposed by Andy.
>
> In patch 2/3, since we have to now modify the role switch descriptor,
> I'm filling the structure in stack memory and removing the constant
> static version. The content of the descriptor is copied during switch
> registration in any case, so we don't need to store it in the driver.
>
> I also noticed a bug in 2/3. I never properly destroyed the software
> node when the mux was removed. That leak is now also fixed.
I've just given this series a try on a device with an ACPI
INT33FE node describing its TypeC connector and the mux is still
properly found and controlled.
So from my pov this series looks ready for merging.
Regards,
Hans
prev parent reply other threads:[~2019-08-19 12:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 10:07 [PATCH v3 0/3] software node: Introduce software_node_find_by_name() Heikki Krogerus
2019-08-19 10:07 ` [PATCH v3 1/3] software node: Add software_node_find_by_name() Heikki Krogerus
2019-09-04 12:37 ` Greg Kroah-Hartman
2019-08-19 10:07 ` [PATCH v3 2/3] usb: roles: intel_xhci: Supplying software node for the role mux Heikki Krogerus
2019-08-19 10:37 ` Andy Shevchenko
2019-09-04 12:37 ` Greg Kroah-Hartman
2019-08-19 10:07 ` [PATCH v3 3/3] platform/x86: intel_cht_int33fe: Use new API to gain access to the role switch Heikki Krogerus
2019-08-19 10:39 ` [PATCH v3 0/3] software node: Introduce software_node_find_by_name() Andy Shevchenko
2019-08-19 10:41 ` Rafael J. Wysocki
2019-08-19 12:46 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717e1e8-ffd4-e97c-0837-70b30391020a@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).