From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4896C4CEC6 for ; Thu, 12 Sep 2019 13:08:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C83792084D for ; Thu, 12 Sep 2019 13:08:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732043AbfILNIy (ORCPT ); Thu, 12 Sep 2019 09:08:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58168 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731283AbfILNIx (ORCPT ); Thu, 12 Sep 2019 09:08:53 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8B4CF8BA2DA; Thu, 12 Sep 2019 13:08:53 +0000 (UTC) Received: from [172.16.176.1] (ovpn-64-2.rdu2.redhat.com [10.10.64.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AE02600C4; Thu, 12 Sep 2019 13:08:52 +0000 (UTC) From: "Benjamin Coddington" To: "Trond Myklebust" Cc: chuck.lever@oracle.com, tibbs@math.uh.edu, bfields@fieldses.org, linux@stwm.de, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, km@cm4all.com Subject: Re: Regression in 5.1.20: Reading long directory fails Date: Thu, 12 Sep 2019 09:08:51 -0400 Message-ID: <57185A91-0AC8-4805-B6CE-67D629F814C2@redhat.com> In-Reply-To: References: <4418877.15LTP4gqqJ@stwm.de> <4198657.JbNDGbLXiX@h2o.as.studentenwerk.mhn.de> <20190906144837.GD17204@fieldses.org> <75F810C6-E99E-40C3-B5E1-34BA2CC42773@oracle.com> <0089DF80-3A1C-4F0B-A200-28FF7CFD0C65@oracle.com> <429B2B1F-FB55-46C5-8BC5-7644CE9A5894@redhat.com> <8D7EFCEB-4AE6-4963-B66F-4A8EEA5EA42A@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 12 Sep 2019 13:08:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12 Sep 2019, at 8:53, Trond Myklebust wrote: > Let's please just scrap this function and rewrite it as a generic > function for reading the MIC. It clearly is not a generic function for > reading arbitrary netobjs, and modifications like the above just make > the misnomer painfully obvious. > > Let's rewrite it as xdr_buf_read_mic() so that we can simplify it where > possible. Ok. I want to assume the mic will not land in the head, but I am not sure.. Is there a scenario where the mic might land in the head, or is that bit of the current function left over from other uses? Ben