From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net,
jgunthorpe@obsidianresearch.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core
Date: Mon, 25 Apr 2016 15:13:26 -0400 [thread overview]
Message-ID: <571E6C56.4080305@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160422150645.GA21128@intel.com>
On 04/22/2016 11:06 AM, Jarkko Sakkinen wrote:
> On Mon, Apr 18, 2016 at 01:26:13PM -0400, Stefan Berger wrote:
>> From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>>
>> The final thing preventing this was the way the sysfs files were
>> attached to the pdev. Follow the approach developed for ppi and move
>> the sysfs files to the chip->dev with symlinks from the pdev
>> for compatibility. Everything in the core now sanely uses container_of
>> to get the chip.
>>
>> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> Three configurations:
>
> * Haswell NUC with PTT (tpm_crb)
> * Another NUC with dTPM 2.0 chip
> * Dell E6420, which has TPM 1.2 chip
>
> Things seem to be unbroken.
>
> Stefan, have you verified that sysfs attributes work through routes:
>
> 1. From char device sysfs directory
> 2. Through link
Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>
> An also tried insmod/rmmod couple of rounds?
Works as-is in polling mode but requires Jason's patch "tpm: Fix IRQ
unwind ordering in TIS" for interrupt mode to not throw errors on 'rmmod'.
Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
next prev parent reply other threads:[~2016-04-25 19:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 17:26 [PATCH v11 0/4] Multi-instance vTPM proxy driver Stefan Berger
2016-04-18 17:26 ` [PATCH v11 1/4] tpm: Remove all uses of drvdata from the TPM Core Stefan Berger
2016-04-19 10:12 ` Jarkko Sakkinen
2016-04-19 10:36 ` Stefan Berger
2016-04-19 17:06 ` Jason Gunthorpe
2016-04-20 5:33 ` Jarkko Sakkinen
2016-04-19 17:21 ` Jarkko Sakkinen
2016-04-22 15:06 ` Jarkko Sakkinen
2016-04-25 19:13 ` Stefan Berger [this message]
2016-05-10 13:55 ` [BUG, bisect] " Jeremiah Mahler
2016-05-10 14:38 ` Jarkko Sakkinen
[not found] ` <201605101505.u4AF5nHd032349@d03av04.boulder.ibm.com>
2016-05-11 1:26 ` [tpmdd-devel] " Jeremiah Mahler
[not found] ` <201605111027.u4BARtQ4021061@d01av01.pok.ibm.com>
2016-05-11 14:29 ` Jeremiah Mahler
2016-05-11 15:20 ` Stefan Berger
2016-04-18 17:26 ` [PATCH v11 2/4] tpm: Introduce TPM_CHIP_FLAG_VIRTUAL Stefan Berger
2016-04-22 16:46 ` Jarkko Sakkinen
2016-04-18 17:26 ` [PATCH v11 3/4] tpm: Proxy driver for supporting multiple emulated TPMs Stefan Berger
2016-04-22 16:47 ` Jarkko Sakkinen
2016-04-18 17:26 ` [PATCH v11 4/4] tpm: Add documentation for the tpm_vtpm_proxy device driver Stefan Berger
2016-04-22 16:47 ` Jarkko Sakkinen
2016-04-22 16:54 ` [PATCH v11 0/4] Multi-instance vTPM proxy driver Jarkko Sakkinen
2016-04-26 9:28 ` [tpmdd-devel] " Jarkko Sakkinen
2016-04-26 11:30 ` Stefan Berger
2016-04-27 12:56 ` Jarkko Sakkinen
2016-04-27 16:27 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E6C56.4080305@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).