From: Tero Kristo <t-kristo@ti.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
Tony Lindgren <tony@atomide.com>,
"Ujfalusi, Peter" <peter.ujfalusi@ti.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>,
ldewangan@nvidia.com, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
marek@goldelico.com, kernel@pyra-handheld.com,
letux-kernel@openphoenux.org
Subject: Re: [PATCH v2 4/5] ARM: dts: omap5: describe control for ckobuffer
Date: Wed, 27 Apr 2016 15:31:03 +0300 [thread overview]
Message-ID: <5720B107.4000907@ti.com> (raw)
In-Reply-To: <70572DA1-BEB4-4681-BA6C-2E1C9002D730@goldelico.com>
On 27/04/16 09:04, H. Nikolaus Schaller wrote:
>
>> Am 26.04.2016 um 19:27 schrieb Tony Lindgren <tony@atomide.com>:
>>
>> Tero,
>>
>> * H. Nikolaus Schaller <hns@goldelico.com> [160418 11:23]:
>>> OMAP5 has a register to control if the ckobuffer is enabled
>>> and defines the polarity. ckobuffer is required to drive a twl6040
>>> with the system clock. Hence, add the pinctrl,single to the
>>> OMAP5 SoC description so that omap5-board-common can
>>> set up the ckobuffer as required.
>>
>> Is this really a mux or should it be a mux clock?
>
> It is a pinmux setting for the clock out buffer to choose what signal
> (and polarity) is presented on the fref_xtal_clk pad.
>
> The register is part of the CTRL_MODULE_WKUP.
> The clock signal is the xtal master clock of the whole SoC.
>
> Although there is a bit to choose an alternate clock, there is no
> alternate in the OMAP5 silicon.
>
> Therefore I would say it is about padconf and not clock or clock mux
> related.
>
> It just happens to be a clock signal which can be routed to this
> pad.
The two could very well be implemented as clock nodes, a mux and a gate.
This would describe the hardware functionality better imo, if the
assumptions made here are correct. Implementing the control as pinctrl
hacks looks rather weird to me.
I could not find any documentation related to the ckobuffer usage
though, maybe Peter can provide some insight? I think you spent some
considerable time bringing up twl6040 a few years back...
-Tero
>
> BR,
> Nikolaus
>
>>
>> Regards,
>>
>> Tony
>>
>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>>> ---
>>> arch/arm/boot/dts/omap5.dtsi | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
>>> index 120b6b8..1d9050f 100644
>>> --- a/arch/arm/boot/dts/omap5.dtsi
>>> +++ b/arch/arm/boot/dts/omap5.dtsi
>>> @@ -277,6 +277,16 @@
>>> pinctrl-single,register-width = <16>;
>>> pinctrl-single,function-mask = <0x7fff>;
>>> };
>>> +
>>> + omap5_control_ckobuffer: pinmux@cdb4 {
>>> + compatible = "ti,omap5-padconf",
>>> + "pinctrl-single";
>>> + reg = <0xcdb4 4>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + pinctrl-single,register-width = <32>;
>>> + pinctrl-single,function-mask = <0xf0000000>;
>>> + };
>>> };
>>>
>>> ocmcram: ocmcram@40300000 {
>>> --
>>> 2.7.3
>>>
>
next prev parent reply other threads:[~2016-04-27 12:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 18:20 [PATCH v2 0/5] DT Fixes for OMAP4 and OMAP5 boards H. Nikolaus Schaller
2016-04-18 18:20 ` [PATCH v2 1/5] ARM: dts: twl6030: describe gpadc H. Nikolaus Schaller
2016-04-26 17:26 ` Tony Lindgren
2016-04-18 18:20 ` [PATCH v2 2/5] ARM: dts: omap5-board-common: describe gpadc for Palmas H. Nikolaus Schaller
2016-04-18 18:20 ` [PATCH v2 3/5] ARM: dts: omap5: fix range of permitted wakeup pinmux registers H. Nikolaus Schaller
2016-04-26 17:23 ` Tony Lindgren
2016-04-18 18:21 ` [PATCH v2 4/5] ARM: dts: omap5: describe control for ckobuffer H. Nikolaus Schaller
2016-04-26 17:27 ` Tony Lindgren
2016-04-27 6:04 ` H. Nikolaus Schaller
2016-04-27 12:31 ` Tero Kristo [this message]
2016-04-27 13:10 ` H. Nikolaus Schaller
2016-04-27 14:10 ` Tero Kristo
2016-04-27 14:23 ` Peter Ujfalusi
2016-04-27 14:35 ` H. Nikolaus Schaller
2016-04-28 8:03 ` Tero Kristo
2016-04-28 9:12 ` H. Nikolaus Schaller
2016-04-28 13:23 ` Tero Kristo
2016-05-09 11:18 ` H. Nikolaus Schaller
2016-05-09 11:52 ` Tero Kristo
2016-05-09 12:10 ` Peter Ujfalusi
2016-05-09 12:32 ` [Kernel] " Peter Ujfalusi
2016-05-09 12:46 ` Peter Ujfalusi
2016-05-09 13:52 ` Peter Ujfalusi
2016-05-09 14:09 ` Tero Kristo
2016-05-09 15:28 ` Peter Ujfalusi
2016-05-09 19:44 ` Peter Ujfalusi
2016-05-10 5:45 ` H. Nikolaus Schaller
2016-04-18 18:21 ` [PATCH v2 5/5] ARM: dts: omap5-board-common: set up ckobuffer for twl6040 H. Nikolaus Schaller
2016-04-26 15:00 ` [PATCH v2 0/5] DT Fixes for OMAP4 and OMAP5 boards H. Nikolaus Schaller
2016-04-26 17:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720B107.4000907@ti.com \
--to=t-kristo@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hns@goldelico.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pyra-handheld.com \
--cc=ldewangan@nvidia.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marek@goldelico.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).