From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752685AbcD1LWJ (ORCPT ); Thu, 28 Apr 2016 07:22:09 -0400 Received: from foss.arm.com ([217.140.101.70]:42337 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbcD1LWG (ORCPT ); Thu, 28 Apr 2016 07:22:06 -0400 Subject: Re: [PATCH 1/2] PM / OPP: Remove OF dependency on dev_pm_opp_of_{cpumask_,}remove_table To: Viresh Kumar References: <1461839114-29857-1-git-send-email-sudeep.holla@arm.com> <20160428111221.GB2915@vireshk-i7> Cc: Sudeep Holla , linux-kernel@vger.kernel.org, Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org From: Sudeep Holla Organization: ARM Message-ID: <5721F25A.8050505@arm.com> Date: Thu, 28 Apr 2016 12:22:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160428111221.GB2915@vireshk-i7> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/16 12:12, Viresh Kumar wrote: > On 28-04-16, 11:25, Sudeep Holla wrote: >> + * dev_pm_opp_remove_table() - Free OPP table static entries associated with >> + * the device > > Its not about static entries anymore, right? We will end up removing everything > we had in the table. > No, not yet. I have not made that change yet. I just asked that question in patch 2. I still remove individually but wanted to know if removing dynamic opp is any issue ? The OPP added using dev_pm_opp_add are marked dynamic and are not deleted by dev_pm_opp_{,cpumask_}remove_table. If it does, then scpi_free_opp_table can be assigned that instead of what I have in patch 2/2. > Can you please update comments also in the same patch ? > Sure once you agree and I make that change ;) -- Regards, Sudeep