From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752367AbcD1TDp (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Apr 2016 15:03:45 -0400
Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:44246 "EHLO
	mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751513AbcD1TDn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Apr 2016 15:03:43 -0400
Subject: Re: [PATCH 7/8] wbt: add general throttling mechanism
To: Jan Kara <jack@suse.cz>
References: <1461686131-22999-1-git-send-email-axboe@fb.com>
 <1461686131-22999-8-git-send-email-axboe@fb.com>
 <20160428110559.GC17362@quack2.suse.cz> <57225C3E.7060504@fb.com>
CC: <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <linux-block@vger.kernel.org>, <dchinner@redhat.com>,
        <sedat.dilek@gmail.com>, Kaixu Xia <xiakaixu@huawei.com>
From: Jens Axboe <axboe@fb.com>
Message-ID: <57225E6E.70906@fb.com>
Date: Thu, 28 Apr 2016 13:03:10 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <57225C3E.7060504@fb.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [192.168.52.123]
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-28_08:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/28/2016 12:53 PM, Jens Axboe wrote:
>
>> Probably the comment could explain more of "why we do this?" than pure
>> "what we do".
>
> Agree, if you find it confusing, then it needs updating. I'll update the
> comment.

http://git.kernel.dk/cgit/linux-block/commit/?h=wb-buf-throttle

This should address your review comments, I believe.

-- 
Jens Axboe