From: Christopher Covington <cov@codeaurora.org>
To: Michal Marek <mmarek@suse.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Azriel Samson <asamson@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v1] builddeb: fix missing headers in linux-headers package
Date: Thu, 5 May 2016 10:42:12 -0400 [thread overview]
Message-ID: <572B5BC4.7080402@codeaurora.org> (raw)
In-Reply-To: <1459445479-10948-1-git-send-email-asamson@codeaurora.org>
On 03/31/2016 01:31 PM, Azriel Samson wrote:
> The kernel headers package (linux-headers) doesn't include
> header files from other architectures required to build
> out-of-tree modules.
>
> For e.g. on ARM64, opcodes.h includes the same file from ARM
> which causes the following error:
> ./arch/arm64/include/asm/opcodes.h:1:43: fatal error:
> ../../arm/include/asm/opcodes.h: No such file or directory
> compilation terminated.
>
> Signed-off-by: Azriel Samson <asamson@codeaurora.org>
> ---
> scripts/package/builddeb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index 6c3b038..06ba0d9 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -322,7 +322,7 @@ fi
>
> # Build kernel header package
> (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl) > "$objtree/debian/hdrsrcfiles"
> -(cd $srctree; find arch/$SRCARCH/include include scripts -type f) >> "$objtree/debian/hdrsrcfiles"
> +(cd $srctree; find arch/*/include include scripts -type f) >> "$objtree/debian/hdrsrcfiles"
> (cd $srctree; find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform) >> "$objtree/debian/hdrsrcfiles"
> (cd $srctree; find $(find arch/$SRCARCH -name include -o -name scripts -type d) -type f) >> "$objtree/debian/hdrsrcfiles"
> (cd $objtree; find arch/$SRCARCH/include Module.symvers include scripts -type f) >> "$objtree/debian/hdrobjfiles"
Any feedback on this? Michal, do you think this would be appropriate to
include in 4.7?
Thanks,
Christopher Covington
--
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-05-05 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 17:31 [PATCH v1] builddeb: fix missing headers in linux-headers package Azriel Samson
2016-05-05 14:42 ` Christopher Covington [this message]
2016-05-10 15:45 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572B5BC4.7080402@codeaurora.org \
--to=cov@codeaurora.org \
--cc=asamson@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).