From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758005AbcEFN6S (ORCPT ); Fri, 6 May 2016 09:58:18 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:48205 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755750AbcEFN6Q (ORCPT ); Fri, 6 May 2016 09:58:16 -0400 X-AuditID: cbfec7f4-f796c6d000001486-f2-572ca2f42396 Subject: Re: [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards To: Javier Martinez Canillas References: <1461871311-18344-1-git-send-email-javier@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, Russell King , Kukjin Kim , devicetree@vger.kernel.org, Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <572CA2F3.4050407@samsung.com> Date: Fri, 06 May 2016 15:58:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgkeLIzCtJLcpLzFFi42I5/e/4Zd0vi3TCDZ62GFvMP3KO1aL/zUJW i3OvVjJavHm7hsni9QtDi/7Hr5ktNj2+xmpxedccNosZ5/cxWdy+zGux9PpFJosJ09eyWLTu PcLuwOuxZt4aRo+W5h42j8t9vUweK5d/YfPYtKqTzWPzknqPLf132T36tqxi9Pi8SS6AM4rL JiU1J7MstUjfLoEr4/ylFUwF9wUrfiybx9bAeICvi5GTQ0LAROLv9lNsELaYxIV764FsLg4h gaWMEhvezWGEcJ4xSnRvaWLqYuTgEBbwkXh1xwakQUTAVOLX2hesILaQQL3E2WVbWUDqmQUm MEvMXLsdLMEmYCyxefkSNpBeXgEtifXHvEDCLAKqEv/WzGQEsUUFIiRWr7vGDGLzCghK/Jh8 jwXE5hRwlti8sI8dpJVZQE/i/kUtkDCzgLzE5jVvmScwCsxC0jELoWoWkqoFjMyrGEVTS5ML ipPScw31ihNzi0vz0vWS83M3MULi58sOxsXHrA4xCnAwKvHwZpzUDhdiTSwrrsw9xCjBwawk wnt+rk64EG9KYmVValF+fFFpTmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZODilGhjn RYepWJTvE26IO6aUrPy9fp4q64b21MorK0V7du0WzC+6KdQVxvF0+vSbz5VO8Vlx/3fq9Z4Z dS3OgC/CwWdq2ZIIi9VHjugJeqktftssfzL54A65HWnMf9ka3cQv//wU8+D8hfVfNrGdtmWZ GytumLVF/EOwT2vSunYfP693e0wU3IQO3VJiKc5INNRiLipOBADXEEM2mwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2016 03:44 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 04/28/2016 03:21 PM, Javier Martinez Canillas wrote: >> The MFC nodes with the memory regions reserved for memory allocations >> are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS. >> >> This causes the s5p-mfc driver probe to fail with the following error: >> >> [ 4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device >> [ 4.216163] s5p-mfc: probe of 11000000.codec failed with error -12 >> >> Add the missing nodes so the driver probes and the {en,de}coder video >> nodes are registered correctly: >> >> [ 4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4 >> [ 4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5 >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++ >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index b644858231b6..f9d2e4f1a0e0 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> @@ -694,6 +694,11 @@ >> status = "okay"; >> }; >> >> +&mfc { >> + samsung,mfc-r = <0x43000000 0x800000>; >> + samsung,mfc-l = <0x51000000 0x800000>; >> +}; >> + >> &mmc_0 { >> status = "okay"; >> num-slots = <1>; >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index 6ba9aec15485..62ceb89e073f 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -669,6 +669,11 @@ >> status = "okay"; >> }; >> >> +&mfc { >> + samsung,mfc-r = <0x43000000 0x800000>; >> + samsung,mfc-l = <0x51000000 0x800000>; >> +}; >> + >> &mmc_0 { >> status = "okay"; >> num-slots = <1>; >> > > Any comments about this patch? What is up with the rush now (a week for ping)? As I understand, this was broken for very long time on these boards (since adding DT support in 2012?). Best regards, Krzysztof