From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758826AbcEFVWh (ORCPT ); Fri, 6 May 2016 17:22:37 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:43312 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758557AbcEFVWf (ORCPT ); Fri, 6 May 2016 17:22:35 -0400 Message-ID: <572D0B10.60908@collabora.com> Date: Fri, 06 May 2016 23:22:24 +0200 From: Enric Balletbo i Serra User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Javier Martinez Canillas CC: Linux Kernel , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , Tony Lindgren , Ladislav Michl Subject: Re: [PATCH 1/2] ARM: dts: igep00x0: Add SD card-detect. References: <1462568554-7868-1-git-send-email-enric.balletbo@collabora.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On 06/05/16 23:07, Javier Martinez Canillas wrote: > Hello Enric, > > On Fri, May 6, 2016 at 5:02 PM, Enric Balletbo i Serra > wrote: >> Fix SD card remove/insert detection by adding the correct card-detect >> pin. All IGEP OMAP3 based boards use the same card-detect pin. >> >> Signed-off-by: Enric Balletbo i Serra >> Signed-off-by: Ladislav Michl > > Shouldn't his be Suggested-by: Ladislav Michl instead? > > Or if the patch was originally from Ladis, then he should remain the > author with your S-o-B after his. > Well Ladis sent the same patch as I had in my local repository for long time, so to be strict the correct is have two authors and two S-o-B. My bad is not send the patch before. > Patch looks good to me though. > > Reviewed-by: Javier Martinez Canillas > > Best regards, > Javier >