linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] intel: Simplify bool conversion
@ 2021-09-29  6:56 Yang Li
  2021-09-29 16:12 ` Nguyen, Anthony L
  2021-10-25 18:37 ` Brelinski, Tony
  0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2021-09-29  6:56 UTC (permalink / raw)
  To: kuba
  Cc: davem, jesse.brandeburg, anthony.l.nguyen, intel-wired-lan,
	netdev, linux-kernel, Yang Li

Fix the following coccicheck warning:
./drivers/net/ethernet/intel/i40e/i40e_xsk.c:229:35-40: WARNING:
conversion to bool not needed here
./drivers/net/ethernet/intel/ice/ice_xsk.c:399:35-40: WARNING:
conversion to bool not needed here

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
 drivers/net/ethernet/intel/ice/ice_xsk.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 6f85879..ea06e95 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -226,7 +226,7 @@ bool i40e_alloc_rx_buffers_zc(struct i40e_ring *rx_ring, u16 count)
 	rx_desc->wb.qword1.status_error_len = 0;
 	i40e_release_rx_desc(rx_ring, ntu);
 
-	return count == nb_buffs ? true : false;
+	return count == nb_buffs;
 }
 
 /**
diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c
index 7682eaa..35b6e81 100644
--- a/drivers/net/ethernet/intel/ice/ice_xsk.c
+++ b/drivers/net/ethernet/intel/ice/ice_xsk.c
@@ -396,7 +396,7 @@ bool ice_alloc_rx_bufs_zc(struct ice_ring *rx_ring, u16 count)
 	rx_desc->wb.status_error0 = 0;
 	ice_release_rx_desc(rx_ring, ntu);
 
-	return count == nb_buffs ? true : false;
+	return count == nb_buffs;
 }
 
 /**
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] intel: Simplify bool conversion
  2021-09-29  6:56 [PATCH -next] intel: Simplify bool conversion Yang Li
@ 2021-09-29 16:12 ` Nguyen, Anthony L
  2021-10-25 18:37 ` Brelinski, Tony
  1 sibling, 0 replies; 3+ messages in thread
From: Nguyen, Anthony L @ 2021-09-29 16:12 UTC (permalink / raw)
  To: Karlsson, Magnus, yang.lee, kuba, bpf
  Cc: linux-kernel, davem, Brandeburg, Jesse, intel-wired-lan, netdev

On Wed, 2021-09-29 at 14:56 +0800, Yang Li wrote:
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/intel/i40e/i40e_xsk.c:229:35-40: WARNING:
> conversion to bool not needed here
> ./drivers/net/ethernet/intel/ice/ice_xsk.c:399:35-40: WARNING:
> conversion to bool not needed here
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
>  drivers/net/ethernet/intel/ice/ice_xsk.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Tony Nguyen <anthony.l.nguyen@intel.com>

This applies to patches that went through BPF[1] and aren't on the
Intel wired LAN yet. BPF - did you want to pick this up?

[1]
https://patchwork.kernel.org/project/netdevbpf/list/?series=550775&stat
e=*

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 6f85879..ea06e95 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -226,7 +226,7 @@ bool i40e_alloc_rx_buffers_zc(struct i40e_ring
> *rx_ring, u16 count)
>  	rx_desc->wb.qword1.status_error_len = 0;
>  	i40e_release_rx_desc(rx_ring, ntu);
>  
> -	return count == nb_buffs ? true : false;
> +	return count == nb_buffs;
>  }
>  
>  /**
> diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c
> b/drivers/net/ethernet/intel/ice/ice_xsk.c
> index 7682eaa..35b6e81 100644
> --- a/drivers/net/ethernet/intel/ice/ice_xsk.c
> +++ b/drivers/net/ethernet/intel/ice/ice_xsk.c
> @@ -396,7 +396,7 @@ bool ice_alloc_rx_bufs_zc(struct ice_ring
> *rx_ring, u16 count)
>  	rx_desc->wb.status_error0 = 0;
>  	ice_release_rx_desc(rx_ring, ntu);
>  
> -	return count == nb_buffs ? true : false;
> +	return count == nb_buffs;
>  }
>  
>  /**

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH -next] intel: Simplify bool conversion
  2021-09-29  6:56 [PATCH -next] intel: Simplify bool conversion Yang Li
  2021-09-29 16:12 ` Nguyen, Anthony L
@ 2021-10-25 18:37 ` Brelinski, Tony
  1 sibling, 0 replies; 3+ messages in thread
From: Brelinski, Tony @ 2021-10-25 18:37 UTC (permalink / raw)
  To: Yang Li, kuba
  Cc: davem, Brandeburg, Jesse, Nguyen, Anthony L, intel-wired-lan,
	netdev, linux-kernel

> -----Original Message-----
> From: Yang Li <yang.lee@linux.alibaba.com>
> Sent: Tuesday, September 28, 2021 11:56 PM
> To: kuba@kernel.org
> Cc: davem@davemloft.net; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Yang Li
> <yang.lee@linux.alibaba.com>
> Subject: [PATCH -next] intel: Simplify bool conversion
> 
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/intel/i40e/i40e_xsk.c:229:35-40: WARNING:
> conversion to bool not needed here
> ./drivers/net/ethernet/intel/ice/ice_xsk.c:399:35-40: WARNING:
> conversion to bool not needed here
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
>  drivers/net/ethernet/intel/ice/ice_xsk.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Tested-by: Tony Brelinski <tony.brelinski@intel.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-25 18:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-29  6:56 [PATCH -next] intel: Simplify bool conversion Yang Li
2021-09-29 16:12 ` Nguyen, Anthony L
2021-10-25 18:37 ` Brelinski, Tony

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).