From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751602AbcEJFaq (ORCPT ); Tue, 10 May 2016 01:30:46 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:30817 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934AbcEJFao (ORCPT ); Tue, 10 May 2016 01:30:44 -0400 X-AuditID: cbfec7f5-f792a6d000001302-01-573172009bd5 Subject: Re: [PATCH v2 13/22] ARM: dts: exynos: Move common nodes to exynos5.dtsi To: Javier Martinez Canillas , Kukjin Kim , Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <1462734367-5619-1-git-send-email-krzk@kernel.org> <1462734367-5619-14-git-send-email-krzk@kernel.org> <1cee1acf-fb07-9a7f-5d18-b4824a10f5a2@osg.samsung.com> From: Krzysztof Kozlowski Message-id: <573171FE.6070309@kernel.org> Date: Tue, 10 May 2016 07:30:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: <1cee1acf-fb07-9a7f-5d18-b4824a10f5a2@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xK7oMRYbhBk/WqFjMP3KO1eLN2zVM Fq9fGFr0P37NbLHp8TVWi48991gtLu+aw2Yx4/w+JouLp1wtDr9pZ7X4caabxWLVrj+MDjwe 72+0sntc7utl8tg56y67x6ZVnWwem5fUe2zpB/L6tqxi9Pi8SS6AI4rLJiU1J7MstUjfLoEr 48KRNywFz9kqbp9tZm5g3MbaxcjJISFgInHz4kt2CFtM4sK99WxdjFwcQgJLGSWeHH7AApIQ EnjGKHFqjiOILSwQLHF24np2kCIRgcvMErPuv2GEKFrLKPHzi30XIwcHm4C2xL8txSBhXgFN ibUdS8EWsAioSjTvXwC2WFQgQmL1umvMEDWCEj8m3wPbxSngLNH05wA7yBhmAT2J+xe1QMLM AvISm9e8ZZ7AyD8LSccshKpZSKoWMDKvYhRNLU0uKE5KzzXSK07MLS7NS9dLzs/dxAiJia87 GJceszrEKMDBqMTDK8BrGC7EmlhWXJl7iFGCg1lJhPdMAVCINyWxsiq1KD++qDQntfgQozQH i5I478xd70OEBNITS1KzU1MLUotgskwcnFINjF65JckKRW7z1us/N3QSazDdNuurdslrgex+ 7WDx3jaL7qURQQLTZ637PTVKkt9yy9l7a7S2TZJ8LWhx5HRt+ebg/uUOC78Kr7SfuXBxCs/T X5/SfA9b/dY83KDmfDo0YssVrdq1ptX/tuvti/69dbqZtUtt90ux4zvCv58unW65/vD97/Mq dZVYijMSDbWYi4oTAfT01dOFAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2016 11:25 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/08/2016 03:05 PM, Krzysztof Kozlowski wrote: >> Exynos5420 and Exynos5250 share some nodes: the PWM and syscon >> (sysreg_system_controller). Move them to parent DTSI to avoid >> duplication. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > I see that the i2c_[0-3] nodes are also the same in both DTSI. Do you > think that makes sense to also move those to exynos5.dtsi as well? Thanks, that is a good suggestion. I didn't add the I2C and its children to Odroid XU yet but probably having the nodes defined won't hurt. Especially that they are disabled by default. Best regards, Krzysztof > In any case that can be made as a follow-up, so: > > Reviewed-by: Javier Martinez Canillas > > Best regards, >