From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370AbcEJKbu (ORCPT ); Tue, 10 May 2016 06:31:50 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36652 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbcEJKbs (ORCPT ); Tue, 10 May 2016 06:31:48 -0400 Subject: Re: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock To: Peng Fan References: <1461173177-11930-1-git-send-email-van.freenix@gmail.com> <1461173177-11930-3-git-send-email-van.freenix@gmail.com> <5730825E.5030101@linaro.org> <20160509124140.GA20259@linux-7smt.suse> Cc: shawnguo@kernel.org, maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Srinivas Kandagatla Message-ID: <5731B891.4040303@linaro.org> Date: Tue, 10 May 2016 11:31:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160509124140.GA20259@linux-7smt.suse> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/16 13:41, Peng Fan wrote: > Hi Srinivas, > > On Mon, May 09, 2016 at 01:28:14PM +0100, Srinivas Kandagatla wrote: >> Thanks for the Ping, I totally missed this thread. >> >> On 20/04/16 18:26, Peng Fan wrote: >>> Before access ocotp nvmem area, the clock should be enabled. >>> Or, `hexdump nvmem` will hang the system. So, use such flow: >>> " >>> 1. clock_enable_prepare >>> 2. read nvmem ocotp area >>> 3. clock_disable_unprepare >>> " >>> >>> Signed-off-by: Peng Fan >>> Cc: Srinivas Kandagatla >>> Cc: Maxime Ripard >>> Cc: Shawn Guo >>> --- >>> >>> V2: >>> Follow Fabio's comments, check return value of clk_prepare_enable >>> >>> drivers/nvmem/imx-ocotp.c | 16 +++++++++++++++- >>> 1 file changed, 15 insertions(+), 1 deletion(-) >> >> Changes to the driver looks good to me, >> Only one comment, As the clock property is now made mandatory, you should >> update the dt-bindings with this info too. > > In Documentation/devicetree/bindings/nvmem/imx-ocotp.txt, > the clock property is already marked Required properties: Ok, I can take this patch, dt patch should go via the dt maintainers. thanks, --srini