From: Jens Axboe <axboe@fb.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ming Lin <ming.l@ssi.samsung.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] skd_main: use %*ph to dump small buffers
Date: Tue, 10 May 2016 08:45:30 -0600 [thread overview]
Message-ID: <5731F40A.9010603@fb.com> (raw)
In-Reply-To: <1462562805-104173-1-git-send-email-andriy.shevchenko@linux.intel.com>
On 05/06/2016 01:26 PM, Andy Shevchenko wrote:
> Replace custom approach by %*ph specifier to dump small buffers in hex format.
>
> Unfortunately we can't use print_hex_dump_bytes() here since tha gap is
> present, though one familiar with the code may change this.
Did you test this?
CC [M] drivers/block/skd_main.o
In file included from include/linux/kernel.h:13:0,
from drivers/block/skd_main.c:19:
drivers/block/skd_main.c: In function ‘skd_send_fitmsg’:
include/linux/kern_levels.h:4:18: warning: format ‘%p’ expects argument
of type ‘void *’, but argument 6 has type ‘int’ [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/printk.h:114:10: note: in definition of macro ‘no_printk’
printk(fmt, ##__VA_ARGS__); \
^
include/linux/kern_levels.h:14:20: note: in expansion of macro
‘KERN_SOH’
#define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
^
include/linux/printk.h:289:12: note: in expansion of macro ‘KERN_DEBUG’
no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
^
drivers/block/skd_main.c:2141:4: note: in expansion of macro ‘pr_debug’
pr_debug("%s:%s:%d msg[%2d] %8ph\n",
^
drivers/block/skd_main.c: In function ‘skd_send_special_fitmsg’:
include/linux/kern_levels.h:4:18: warning: format ‘%p’ expects argument
of type ‘void *’, but argument 6 has type ‘int’ [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/printk.h:114:10: note: in definition of macro ‘no_printk’
printk(fmt, ##__VA_ARGS__); \
^
include/linux/kern_levels.h:14:20: note: in expansion of macro
‘KERN_SOH’
#define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
^
include/linux/printk.h:289:12: note: in expansion of macro ‘KERN_DEBUG’
no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
^
drivers/block/skd_main.c:2175:4: note: in expansion of macro ‘pr_debug’
pr_debug("%s:%s:%d spcl[%2d] %8ph\n",
^
--
Jens Axboe
next prev parent reply other threads:[~2016-05-10 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 19:26 [PATCH v1 1/1] skd_main: use %*ph to dump small buffers Andy Shevchenko
2016-05-10 14:45 ` Jens Axboe [this message]
2016-05-10 15:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731F40A.9010603@fb.com \
--to=axboe@fb.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.l@ssi.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).