From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751249AbcEJQpU (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 May 2016 12:45:20 -0400
Received: from smtp65.iad3a.emailsrvr.com ([173.203.187.65]:54625 "EHLO
	smtp65.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750954AbcEJQpS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 May 2016 12:45:18 -0400
X-Auth-ID: abbotti@mev.co.uk
X-Sender-Id: abbotti@mev.co.uk
Subject: Re: [PATCH 1/1] Staging: comedi: comedi_fops.c: Fixed coding style
 issue
To: Shyam Saini <mayhs11saini@gmail.com>
References: <1462895467-10917-1-git-send-email-mayhs11saini@gmail.com>
Cc: gregkh@linuxfoundation.org, hsweeten@visionengravers.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
From: Ian Abbott <abbotti@mev.co.uk>
Message-ID: <5732101A.5030304@mev.co.uk>
Date: Tue, 10 May 2016 17:45:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <1462895467-10917-1-git-send-email-mayhs11saini@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/05/16 16:51, Shyam Saini wrote:
> Fixed following checkpatch.pl warnings
> WARNING: Prefer WRITE_ONCE(<FOO>, <BAR>) over ACCESS_ONCE(<FOO>) = <BAR>
>
> WARNING: Prefer READ_ONCE(<FOO>) over ACCESS_ONCE(<FOO>)
>
> Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
> ---
>   drivers/staging/comedi/comedi_fops.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index 629080f..4d87596 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -312,8 +312,8 @@ static void comedi_file_reset(struct file *file)
>   	}
>   	cfp->last_attached = dev->attached;
>   	cfp->last_detach_count = dev->detach_count;
> -	ACCESS_ONCE(cfp->read_subdev) = read_s;
> -	ACCESS_ONCE(cfp->write_subdev) = write_s;
> +	WRITE_ONCE(cfp->read_subdev, read_s);
> +	WRITE_ONCE(cfp->write_subdev, write_s);
>   }
>
>   static void comedi_file_check(struct file *file)
> @@ -331,7 +331,7 @@ static struct comedi_subdevice *comedi_file_read_subdevice(struct file *file)
>   	struct comedi_file *cfp = file->private_data;
>
>   	comedi_file_check(file);
> -	return ACCESS_ONCE(cfp->read_subdev);
> +	return READ_ONCE(cfp->read_subdev);
>   }
>
>   static struct comedi_subdevice *comedi_file_write_subdevice(struct file *file)
> @@ -339,7 +339,7 @@ static struct comedi_subdevice *comedi_file_write_subdevice(struct file *file)
>   	struct comedi_file *cfp = file->private_data;
>
>   	comedi_file_check(file);
> -	return ACCESS_ONCE(cfp->write_subdev);
> +	return READ_ONCE(cfp->write_subdev);
>   }
>
>   static int resize_async_buffer(struct comedi_device *dev,
> @@ -1992,7 +1992,7 @@ static int do_setrsubd_ioctl(struct comedi_device *dev, unsigned long arg,
>   	    !(s_old->async->cmd.flags & CMDF_WRITE))
>   		return -EBUSY;
>
> -	ACCESS_ONCE(cfp->read_subdev) = s_new;
> +	WRITE_ONCE(cfp->read_subdev, s_new);
>   	return 0;
>   }
>
> @@ -2034,7 +2034,7 @@ static int do_setwsubd_ioctl(struct comedi_device *dev, unsigned long arg,
>   	    (s_old->async->cmd.flags & CMDF_WRITE))
>   		return -EBUSY;
>
> -	ACCESS_ONCE(cfp->write_subdev) = s_new;
> +	WRITE_ONCE(cfp->write_subdev, s_new);
>   	return 0;
>   }
>
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-