From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261AbcEJTNa (ORCPT ); Tue, 10 May 2016 15:13:30 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:35098 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbcEJTN2 (ORCPT ); Tue, 10 May 2016 15:13:28 -0400 Subject: Re: [PATCH RFT 1/2] phylib: add device reset GPIO support To: Sergei Shtylyov , grant.likely@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, frowand.list@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org References: <81129033.NXiOLTg1so@wasted.cogentembedded.com> <3641492.klKRrvS8tr@wasted.cogentembedded.com> <5732294F.3060606@gmail.com> <5732327A.6080203@cogentembedded.com> Cc: linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <573232D4.6000006@gmail.com> Date: Tue, 10 May 2016 12:13:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <5732327A.6080203@cogentembedded.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2016 12:11 PM, Sergei Shtylyov wrote: > Hello. > > On 05/10/2016 09:32 PM, Florian Fainelli wrote: > >>> The PHY devices sometimes do have their reset signal (maybe even power >>> supply?) tied to some GPIO and sometimes it also does happen that a boot >>> loader does not leave it deasserted. So far this issue has been attacked >>> from (as I believe) a wrong angle: by teaching the MAC driver to >>> manipulate >>> the GPIO in question; that solution, when applied to the device >>> trees, led >>> to adding the PHY reset GPIO properties to the MAC device node, with one >>> exception: Cadence MACB driver which could handle the "reset-gpios" prop >>> in a PHY device subnode. I believe that the correct approach is to teach >>> the 'phylib' to get the MDIO device reset GPIO from the device tree node >>> corresponding to this device -- which this patch is doing... >>> >>> Note that I had to modify the AT803x PHY driver as it would stop >>> working >>> otherwise as it made use of the reset GPIO for its own purposes... >>> >>> Signed-off-by: Sergei Shtylyov >> >> This looks good to me: >> >> Acked-by: Florian Fainelli > > Thank you! I'll send v3 without [RFT] then. > >> Can you follow up with changes in phy_{suspend,resume} > > I'm not sure what changes you mean -- powering down the PHYs? Yes, powering down, conversely up the PHY. The whole point of putting this in PHYLIB is to be able to perform things like that. We do not need this right now, but it would be nice if we saw that materialize at some point. -- Florian