From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751759AbcEKHjk (ORCPT ); Wed, 11 May 2016 03:39:40 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:36832 "EHLO mail-lf0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbcEKHji (ORCPT ); Wed, 11 May 2016 03:39:38 -0400 Subject: Re: [PATCH V7 05/11] acpi, pci: Support IO resources when parsing PCI host bridge resources. To: "Rafael J. Wysocki" References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-6-git-send-email-tn@semihalf.com> Cc: Bjorn Helgaas , Arnd Bergmann , Will Deacon , Catalin Marinas , Hanjun Guo , Lorenzo Pieralisi , Sinan Kaya , jchandra@broadcom.com, robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, David Daney , wangyijing@huawei.com, Suravee Suthikulanit , Mark Salter , Linux PCI , "linux-arm-kernel@lists.infradead.org" , ACPI Devel Maling List , Linux Kernel Mailing List , "linaro-acpi@lists.linaro.org" , Jon Masters , andrea.gallo@linaro.org, dhdang@apm.com, jeremy.linton@arm.com, liudongdong3@huawei.com, Christopher Covington From: Tomasz Nowicki Message-ID: <5732E1B6.1000709@semihalf.com> Date: Wed, 11 May 2016 09:39:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.05.2016 20:20, Rafael J. Wysocki wrote: > On Tue, May 10, 2016 at 5:19 PM, Tomasz Nowicki wrote: >> Platforms that have memory mapped IO port (such as ARM64) need special >> handling for PCI I/O resources. For host bridge's resource probing case >> these resources need to be fixed up with pci_register_io_range/pci_remap_iospace etc. >> >> The same I/O resources need to be released after hotplug >> removal so that it can be re-added back by the pci_remap_iospace >> function during insertion. As a consequence we unmap I/O resources >> with pci_unmap_iospace when we release host bridge resources. >> >> Signed-off-by: Jayachandran C >> Signed-off-by: Sinan Kaya >> Signed-off-by: Tomasz Nowicki >> --- >> drivers/acpi/pci_root.c | 33 +++++++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c >> index ae3fe4e..cb3071d 100644 >> --- a/drivers/acpi/pci_root.c >> +++ b/drivers/acpi/pci_root.c >> @@ -719,6 +719,34 @@ next: >> resource_list_add_tail(entry, resources); >> } >> } >> +static void acpi_pci_root_remap_iospace(struct resource_entry *entry) >> +{ >> +#ifdef PCI_IOBASE > > Same comment about the #ifdefs as in the other patch. OK > >> + struct resource *res = entry->res; >> + resource_size_t cpu_addr = res->start; >> + resource_size_t pci_addr = cpu_addr - entry->offset; >> + resource_size_t length = resource_size(res); >> + unsigned long port; >> + >> + if (pci_register_io_range(cpu_addr, length)) >> + goto err; >> + >> + port = pci_address_to_pio(cpu_addr); >> + if (port == (unsigned long)-1) >> + goto err; >> + >> + res->start = port; >> + res->end = port + length - 1; >> + entry->offset = port - pci_addr; >> + >> + if (pci_remap_iospace(res, cpu_addr) < 0) >> + goto err; > > An empty line here? yes, empty line would be nice here. Tomasz