From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932395AbcELP1V (ORCPT ); Thu, 12 May 2016 11:27:21 -0400 Received: from mail-bl2on0068.outbound.protection.outlook.com ([65.55.169.68]:41890 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932279AbcELP1R (ORCPT ); Thu, 12 May 2016 11:27:17 -0400 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <5734A0CC.8010600@caviumnetworks.com> Date: Thu, 12 May 2016 08:27:08 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Catalin Marinas , "Rafael J. Wysocki" , Will Deacon CC: David Daney , Mark Rutland , , David Daney , Lv Zheng , "H. Peter Anvin" , Frank Rowand , , Robert Moore , , Ingo Molnar , Grant Likely , Len Brown , Fenghua Yu , Marc Zyngier , Jon Masters , Robert Richter , Rob Herring , Thomas Gleixner , , , Tony Luck , , Hanjun Guo , Ganapatrao Kulkarni Subject: Re: [PATCH v6 13/14] arm64, acpi, numa: NUMA support based on SRAT and SLIT References: <1461780436-27182-1-git-send-email-ddaney.cavm@gmail.com> <1461780436-27182-14-git-send-email-ddaney.cavm@gmail.com> <20160511103929.GC3051@e104818-lin.cambridge.arm.com> <5733C8F5.6090206@caviumnetworks.com> <20160512094915.GD11226@e104818-lin.cambridge.arm.com> In-Reply-To: <20160512094915.GD11226@e104818-lin.cambridge.arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: SN1PR0701CA0004.namprd07.prod.outlook.com (10.162.96.14) To CY1PR07MB2135.namprd07.prod.outlook.com (10.164.112.13) X-MS-Office365-Filtering-Correlation-Id: b2b6c475-e7c5-41cf-e13e-08d37a79e4b1 X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2135;2:qIw8sijkFnBf0Q4lSUfb0TW/1wBZzF+Rpx39LH4yP+CfsJfRWAKU2BVernV57mWW1gTpG3i+Rnf7SzRHtSz65FMg6Aoo68PlTpGp/A4uLkXJ+IV+N7sEQfujMtUUClloL3gacEeYPlXbTJ8M50fHY69vgWMGu+LdWecGn8iuxe1WCNx5JaW9aqMmkSTpPMxO;3:MroaI5TC5DUSev2exI+oXpWKGD9/xS9ozESwDY+bbnUm+hailfIxJI6uKCKAub9CDCQ00+18xtfP+TpFKFoniLrPzCJHQYS5FryNhEgcFMPpuYn5hDJtMBwvRtZfQUJ/;25:bMLsoy/M515DPkkTd9cUCJKw0iGzAy1hRSLYwO6XRRZJK2+eNLFLf4aEl1RPDqZ4k5fvgzxua/VRND2pP6dnDHoc1U7ac1/OlDUVHwOQ4cK5qRfyH9rHXOt1dG7E8Y1aKwTLmxBKP2oiXepnbtqoGAZAuF7iy+4jF5IyPcBxvixVJKYYDV6yaDSPiKSM3V7inildVpFN0Z9aPItnV9FTdRuSuDy7wtgQ9EIyUfVTYFrv78yFQCo1f+8WezvH/1StLVreRYEsJ2lNyYKHYqCThx4tmzTj23qX+N4yHTYoAvVBNnXkRVMrToNS3U4c2b5jY6YPIntcF20n3jMUQ29ITsE0ssJUJ5fWm64PHhNkcNELdk0+UoaCkz9txoxTb/2vaq4wjMgiBx7K/lCjqo8+XQlMKI5Pf8WeMI+HPGATgtE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2135; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2135;20:z62GzgSorsq4UCfOLeGvZpMk13jWllQCPrDfNiiCvX92NstRDzy3PjVxH3YDdj3EvgeNwJ1WcIk2UsZIy7kIvPdaiucJLX3wGePZPGWgKSYmydNUdjH1PGVg4yc2LTHEiT5sDfTJpM0HtMMPyZ+Fw9cXLmUB4hQjXVYTjMlp9g3gRmQyQCSse1HMiiascXn+3KE5tHpwqYVcN7B39CiuMkBfH/JpMQ+VRkzJmRZnpKv49gTvKMMtas8n8wFUuww76p3MHNTsKuI95XujiHD68cxzoqismbrNLH7nKaMey7LTAffASkkuc+iEUjs9vgxqzzwNY3A2GWD3KF0wFAC1fO3se8Og0B7WOApRzgym0XuY/GDE9NRkm9xsWF94spyz0cj7qgrBi0oFVfqzOfXte0vxnXbbyuzC9IyJAIivz1wvtK/mMxb/qjWbATZl9irY1YBDZZRVRRGfw9uX7zZ4lgkh4dJ7xLoBdh7ZnV5pBFbMZSPMvb6vwijcSN37RzmyGKM7WJxotZXHB1XYKmQ6FX3xcH78GMETCj+dN2tiXrLp5LmknuTADInkuZ3F6X655S0acAWsoSJ64X0872NRG14dOIH8MFpqqn0VYS29K90= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY1PR07MB2135;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2135; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2135;4:rrP9YT4X1oTIuGLKTkl605rCdX9mWeBD0xWZQmRraLiIjgwKRacObFE62nnloIzfnzmXDqZUXTDSB5ZddtlRBR3JGBNaNbEuGwTaHbWB3+psIJueydH+n1DWpiVm5hnt4kCjkeLpjPWVA45cWvdhuf25nQtF2Ys3xJ4fjiGvmVt/ZQf1QdwuPdvYUY7xK5aG/OgwNZD5Ip+If13CXspXEY7r0bDjIGeSef2DdnNc5TF+oYujqw9pzBVGIS05Q7sc01cnLM4BTtTZCnAElq57LKd79mUYFTOWwXR8EBAXeADXuUEQTzGl3PfBQL4YwQAwdE3rjIgpKYO/0sPHdg4ViBH5/fWkY8WUb4hS2xu2d+XQ3Pug00nEN8t+ZRlEZWn5 X-Forefront-PRVS: 0940A19703 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(377454003)(24454002)(42186005)(586003)(2950100001)(6116002)(3846002)(81166006)(5004730100002)(4001430100002)(5008740100001)(47776003)(83506001)(77096005)(36756003)(93886004)(4326007)(5001770100001)(189998001)(107886002)(4001350100001)(59896002)(23756003)(33656002)(65816999)(92566002)(87266999)(76176999)(54356999)(65956001)(66066001)(230700001)(50986999)(64126003)(50466002)(2906002)(53416004);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2135;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CY1PR07MB2135;23:CjreiLRG84dfmWlefbmnvY1alT0nvZVIr0FmjU/?= =?iso-8859-1?Q?aZyELfhGSBQox+NifkjPU1iPXi1faFiYTkV5C9VTPJ0lkIhkJmJCVQvrX/?= =?iso-8859-1?Q?+3/khRThmDwjIrbZuOOX8XQ2gtpGEhtd1P0+X08SpTp0VutUVUUREJMARa?= =?iso-8859-1?Q?tgE9/5HAJT5EXP2lb7d9kYfQC5jVHbIke4Na0+6FEdlOhEzgYuSshcNZm2?= =?iso-8859-1?Q?2L6+4WTgHgW+nBCfpHl7yUDEJrOcn7LNSVXDdf5IhC8S1zlRLYebPq54Et?= =?iso-8859-1?Q?ssGJpWOW2vvVLH55JdFDbtJC5hQEqBmE2Omw/BqMsva0PtM5FDubYJF/oO?= =?iso-8859-1?Q?ZP9LSjOolmRwC6nqPOxHiXAmUSK2+2hiXCymMlwBiFPqOkuD7AiUV915a3?= =?iso-8859-1?Q?F6vFPgPPuHqIFcq/PZbohHvSpePN/iRSQq0p2dA8fa6qPQakFsXr5Hb/mP?= =?iso-8859-1?Q?BBUnX+JP7+x+JdF1F9FcGZ5ogH4SQCwcCQfLK+vZG6kyxxMVKTTochORtI?= =?iso-8859-1?Q?QF+vGZV+sEtUTzf9RmBcf8bztH7iCfrrExrR4sK+YlY1odg+0QrI27Ybbk?= =?iso-8859-1?Q?sOvpUOjTwJeTOt75UgS5iWPQ4KMkO/l1DzNUlCgD+NR7Vr1UGzw6RNLDgf?= =?iso-8859-1?Q?rHbY6mP2a43JpDqa32I0sFzLwuIrNy+znPQEfmy+E454roHac/G/uuz/PO?= =?iso-8859-1?Q?Nc2FX5LELsl/H1g6gh8vrYMhL83HymFoKOhwcKycy5jMLBzwaCdOocurb2?= =?iso-8859-1?Q?+Vo2W9dpoW5vDWwu8cuaq0WKjccMop75V8NhLlQf8LWnSaFdWyqYv0Nk9U?= =?iso-8859-1?Q?bShHLI5iMjPH7BCMgx8sk6MgaQGrg0Wb6Mojhf6qpwZP/ufUpKwALquumD?= =?iso-8859-1?Q?oNXyuU7r4GylqReTiJHaoyoYsbJ02IHFmVhbIOJ7H9OEfAHvyEP/ButMJO?= =?iso-8859-1?Q?OCWvW8sjuAXQmcjHJUXFkfULXS/mo1yNLClhqVZxTVAoX2aenJN9RBngoe?= =?iso-8859-1?Q?LZP6MBR9Y+c9QzyYfNXrQlthYXp6ievw3EHh//e8UoMj3JNlDlRjDk7ygf?= =?iso-8859-1?Q?jbVtRVgtOolgeWJhSX1O0pRkk3FaIpmSvkVzfw+a+A=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2135;5:1x+G3V/stLzvr3YK49y0XM8oz9WuNDyCQJC8y0Iaw1jV9+SiJDRz7wxIw4S0rD2aWrRTGtGSFYTq9p4YlZJN2Fxa9qZFoQD9LrTBFPjLJo21IjFlibK2ftlgXa0gNyClB3xvxN3vtp5NwJQms/I1pA==;24:l3dyPpMEBCdfNrS3gNO6RVDMeoEnhG/eW5jc2/XbZaeOnQmDgUuVGE0WGcRfNMI32M+5OIr4zHAfoDA3CnWf3IKD1akY1wCm7MD8wJuxuB4=;7:CzhNeJ2uWcRRNBUikxnyal6mx+TN/Gb26qZrC9aTtVIJPQpIwqpJ33l04ls4RTCpCMv58aDVVyeSiGFdAV8CyJFX2wxlhTFR9xPfZYxFWrk4cop9zZ9mN9biGb0diTCmqOrn7/7W8WquUsp5nGCZJyK+BKfvug+yUMEqssr+HGIYpUXVMlAuK23bsszzdCdx SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2016 15:27:11.4303 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2135 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2016 02:49 AM, Catalin Marinas wrote: > On Wed, May 11, 2016 at 05:06:13PM -0700, David Daney wrote: >> On 05/11/2016 03:39 AM, Catalin Marinas wrote: [...] >>> >>> I wonder whether you could replace the get_mpidr_in_madt() function with >>> something like acpi_get_phys_id(). It looks like get_mpidr_in_madt() >>> duplicates functionality already available elsewhere. >> >> I just tried that, and it doesn't work. >> >> The problem is that this code is being run very early in the boot, and >> kmalloc cannot be used. acpi_get_phys_id() and its ilk can only be used >> once we have working kmalloc. We need to extract the NUMA information early >> like this precisely because it is needed to initializing the slab system >> >> Notice that we are using early_acpi_os_unmap_memory() et al. in >> get_mpidr_in_madt() explicitly for this reason. >> >> In summary: I don't think we need another revision of this patch, it is like >> this for a good reason. > > Slightly confusing, in another reply you said you are going to address > my comment. So, is it doable? I don't think so. My previous reply, to the thread in 0/14, was prematurely made with the incorrect assumption that it was a simple change. Now, after really digging in to the code, and attempting to do as you suggested, I have changed my mind. As I indicated above, there are no remaining suggestions or requests for changes to this patch set pending action. Unless people find additional problems, I think it is ready for merging. I know that Will and Rafael were discussing the proper timing for merging this in the other thread, so I leave it in their hands at this point. Thanks, David Daney >