linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mfd: max77620: Fix FPS switch statements
@ 2016-05-12 17:45 Rhyland Klein
  2016-05-12 17:52 ` Laxman Dewangan
  2016-06-07  8:05 ` Lee Jones
  0 siblings, 2 replies; 9+ messages in thread
From: Rhyland Klein @ 2016-05-12 17:45 UTC (permalink / raw)
  To: Lee Jones; +Cc: Laxman Dewangan, linux-tegra, linux-kernel, Rhyland Klein

When configuring FPS during probe, assuming a DT node is present for
FPS, the code can run into a problem with the switch statements in
max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
in the case of chip->chip_id == MAX77620, it will set
fps_[mix|max]_period but then fall through to the default switch case
and return -EINVAL. Returning this from max77620_config_fps() will
cause probe to fail.

Signed-off-by: Rhyland Klein <rklein@nvidia.com>
---
 drivers/mfd/max77620.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
index 199d261990be..f32fbb8e8129 100644
--- a/drivers/mfd/max77620.c
+++ b/drivers/mfd/max77620.c
@@ -203,6 +203,7 @@ static int max77620_get_fps_period_reg_value(struct max77620_chip *chip,
 		break;
 	case MAX77620:
 		fps_min_period = MAX77620_FPS_PERIOD_MIN_US;
+		break;
 	default:
 		return -EINVAL;
 	}
@@ -236,6 +237,7 @@ static int max77620_config_fps(struct max77620_chip *chip,
 		break;
 	case MAX77620:
 		fps_max_period = MAX77620_FPS_PERIOD_MAX_US;
+		break;
 	default:
 		return -EINVAL;
 	}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-06-15  6:11 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-12 17:45 [PATCH] mfd: max77620: Fix FPS switch statements Rhyland Klein
2016-05-12 17:52 ` Laxman Dewangan
2016-05-27 20:31   ` Rhyland Klein
2016-05-31  7:30     ` Lee Jones
2016-06-01 15:29       ` Rhyland Klein
2016-06-06 15:32       ` Thierry Reding
2016-06-07  8:05 ` Lee Jones
2016-06-14 16:50   ` Rhyland Klein
2016-06-15  6:11     ` Alexandre Courbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).