From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932197AbcELSfc (ORCPT ); Thu, 12 May 2016 14:35:32 -0400 Received: from mail-bn1bon0064.outbound.protection.outlook.com ([157.56.111.64]:13888 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751693AbcELSf2 (ORCPT ); Thu, 12 May 2016 14:35:28 -0400 Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Subject: Re: [RFC PATCH v1 10/18] x86/efi: Access EFI related tables in the clear To: Borislav Petkov , Matt Fleming References: <20160426225553.13567.19459.stgit@tlendack-t1.amdoffice.net> <20160426225740.13567.85438.stgit@tlendack-t1.amdoffice.net> <20160510134358.GR2839@codeblueprint.co.uk> <20160510135758.GA16783@pd.tnic> CC: , , , , , , , , , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Arnd Bergmann , Jonathan Corbet , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Ingo Molnar , "H. Peter Anvin" , Andrey Ryabinin , Alexander Potapenko , Thomas Gleixner , Dmitry Vyukov From: Tom Lendacky Message-ID: <5734C97D.8060803@amd.com> Date: Thu, 12 May 2016 13:20:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160510135758.GA16783@pd.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY1PR13CA0035.namprd13.prod.outlook.com (10.162.30.173) To CY1PR1201MB1116.namprd12.prod.outlook.com (10.169.19.20) X-MS-Office365-Filtering-Correlation-Id: 0cb6b459-f909-4260-bbd0-08d37a9225fa X-Microsoft-Exchange-Diagnostics: 1;CY1PR1201MB1116;2:I+BPSkrboHXmVzISj8b7QYyJH7PxdsnphF8WDCKj9Kzud4sJHuPnWXhrWO7XMGoDkxcUKiJ/9oscZpGebQVBM+bqqCgixPswIZvPN6kPFvAVunasVPD5mUH3hNFsCU6k5cxvX3BGjS1JcyuXWgRVyvIDCthDS5ZcNvzCyBbLKUY5UZQGJ6ChAXyo4nTrToBR;3:DTLTuDyswtpeNAwki8Ox+vu5mZULHmisLlxfcA2akJVy9sGr3d0uR9argRt2DmcYFdfBh/vyc0gG0euc5ZJgKicJ787XtMexMV+T6DF0ibFS55IMYWRv9UoI8pnDENcO;25:oylNTH9ZcVk1eTMr8ao50zPrKgjjwmcxLIMrDe+puRj/lFmfD+MWc6jS+BZit6HKswMt8UFPxQ7m8qRr+AfmnUkT9xSVWkKd+kLcu+bKAGcRAodktUSa+qPyJ19Q8U2gfTxfBbnFM3/yUdu+20c5UmCylp+uyuXNjiHUoahChho7q8RTzA9xnD/hp9KPJuw/lz8iaRgWX+1YzdRx2xpkeoefjbNs26y+ogxSqPgDLpEAO8OA2K/Yf8iRqhq3oPTZ5gtVOcZe3fHQzHJsjj3qfNKXldbw+tH/p7xtTnlfJ/3ZZCvLw4r19tgoAkjVe/LRryz4sVr7wHm2tufrXOoc/HfDIOmk8oIK1bnQfSqW4LYwE0uGKHloQ5SYWxn64xsO9/I8mVs5iE4b4CoDzF+MQ6rJAm6e2Na2rxLKMJ42DSY= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR1201MB1116; X-Microsoft-Exchange-Diagnostics: 1;CY1PR1201MB1116;20:2CvmmeHauFeqMUUOkMBxEm24pUBQF+8nHZ7+e62y3MPYvkpKvnIrrmNVnk6JAoSxBfeYHikwEDx6Q7VKfAL4cSTdRq7J9+D+SACXM3sskJSQ6ALXzXIQ9q3jLg7K5yXNO3zyQJ9ZfnoJbmZmmNV4+duIWOB3T9yuilLYTl58zS9AjH5gcJrOY62k+woIj3Wu9/QhdBGk08d1YVro5uq6kXa3Bnj5seyKN43lwwZOX2s5tbUDD0S3eFOm9LaRF48cp1AfN9crIYt19aHoTTMHz1O6LTRHUMslY7Fe8ebV9YL2uN8j4bs7UUtUTG4pJcmumWBnoiOwgIk6UVP4Ngd/ndbp/IRUdtVg1fiqDQsOhtHVA9+xUgCtKH8ZGMseO0tbyJP/N4lLWwyWQhYHgY/h0S05REzuatay/ShbpzKF4aWrpXK5IJE7m51wIFZIruLNvanbqFi9l5ZQwDqNvn7qIV29S2bg/n3/C9dFzC1LQFvfqorSlMloMabaDXezLYy7;4:ooAyYrJhBCPOaFH7ko6uEKle/kCc/mJMGpIlE1k6idFQl75WTu8AxYMl3MUXzR1w6fcQKQn38fSVb9NtcuskO8TsIkp2D322ffrG3YyV2tz8cm0Od2gzDX00KmRVQbr9td5QUxivkZURcM4RWv68R78/WVmUwP8V+m1n7l2/T8HC+9n3X20WAgooxHsIgKjBLVP6UfedxNr/zelXQoPVs6AvLl0jDUrnBl0sudmfJttYAIgfvzdlejQ9wnQeFHP9zoyt2JsGV6wc67nNuOU0jtqS4qQWRcKLS5YmtHjzpvvAQxwL4qTTPhyX75FBPu8Qj8SQEQX/A0XJsFqbtYUyCFUqbX7ZvQwiAxPie7WIUG+7SrshWIvuPEinljtAtgYG5GD5y5qiORKKiC87x7wWWQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:CY1PR1201MB1116;BCL:0;PCL:0;RULEID:;SRVR:CY1PR1201MB1116; X-Forefront-PRVS: 0940A19703 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(24454002)(377454003)(83506001)(23676002)(81166006)(5001770100001)(65816999)(50986999)(76176999)(87266999)(54356999)(4001350100001)(92566002)(189998001)(59896002)(93886004)(2906002)(586003)(3846002)(6116002)(4326007)(86362001)(36756003)(42186005)(230700001)(2950100001)(5008740100001)(77096005)(5004730100002)(66066001)(47776003)(50466002)(64126003)(65956001)(33656002)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR1201MB1116;H:[10.236.18.82];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyMDFNQjExMTY7MjM6M3FNR3JMNnJkS3BUZ2gyaEZqNmJ4L1Vx?= =?utf-8?B?cUJvNTRONFY1QmJ6eVExeTNRcXY0eGFCVFZOSzV3dmJNK2tyNnp3SnU2SnFm?= =?utf-8?B?QXFaRUFsZmF3UXBMUWpXblU2YkVTNGl5d0ErbUdWdVdYOUorTmY5cGIwS0NG?= =?utf-8?B?MVU4UEVMcFhXSGRtOVR0R1VrQlZFT3FndzBxMnpTQmpMUjlnYkJ2WTdlNDZr?= =?utf-8?B?c0tabFY3dmI1RjBKYURFdFVrdDEyRlQ4bFU5dVR0OWUyYkVxUUFoTy9nVEU0?= =?utf-8?B?WVBVeGZKdVFJcXBRbEtaamVpcXhCbTdYd3Q5TlNXeDNySEhDeU1rWmg3ajZq?= =?utf-8?B?MnlPS25mcjJ5WW05NjlyVUVieWtkc1FkNlIyUFJOMnpVWStxOWpvSjdiVzhH?= =?utf-8?B?N3E0eFZxY0wvTng1WmtMaDVGM3AwS0VKSjY1eG9GWTlsNXJyY3hINnVVOFBm?= =?utf-8?B?TXpXbWhpSk0yak80VVlITmxaUmY4ayt0ZHA5empHbXN4MFlscWQwWUYzbTRn?= =?utf-8?B?VjJMdGk4TDdGNlJPYnNvSVNSb3dUOWdidEw4dDJTbTZUT2dCcUlzS1RZV3Bt?= =?utf-8?B?LzJOblZKSVVkbVo1VlN5UldFSVdpaE85UzhjbkVXNFRGdTMwNDJyQ3dDajgr?= =?utf-8?B?dlhUY1htTGU2TVgrRS9DOTBQR2oyNFJjeUtlbm5QbFNiZjQ0RFRxanUvdkNG?= =?utf-8?B?aG5wVTlEZURaTndydFBWRGpSRDQwMjB6SVNjSEtUY2pmSmp0ck5WL1BlRUdR?= =?utf-8?B?dXpkQjI4SUZsSjFSYmZlb3V2UlRINEhBaG5oKytJYjZNazNIWFNhdHdrYUlF?= =?utf-8?B?RHQwV05mdjNtMGJZV2ZQV3ZwMEg4SWt5ZjhScXRBNmZ3dEdoV1BQWW5BK0Ni?= =?utf-8?B?TmM2Rk01T05xb1dHZSt0bEoxWTQyaWoyZUJrMEszazJVaHdJdDFtMGJlQUZi?= =?utf-8?B?LytnaWtlVUxUQUlGaVhveFhKRThVczhZc3QzbHRCb3FITnUrMER1L3Nsd0Fy?= =?utf-8?B?SnZuV1JkN0NuckRGZFRXYnhrT2dJQmxvZmRlTjR0Vk9iNUFpcGV5S1orRWdt?= =?utf-8?B?bE9GcEUwVlJPU0JCRW9MeUpOOUZYa0RZbHRCejFmSG9qLzlKNmZLSG8ySGxL?= =?utf-8?B?N0VxRDBlaUFVMzJ0eVJuTm9yUEN1RlU5c09xZGpLelRmNEFSTFhMMzlweXBC?= =?utf-8?B?RTdRM3dIMHh3Qkl6TG51UzRYMC9WTkVFa0VYYXVSa0ZJVmZ2dWE3cFNQdncy?= =?utf-8?B?azQ4djVrNjdtYzJUVXlvUHNVUk9LSjJTMHZ1WDV2MFJKOWp6Y1VzNllLUHEy?= =?utf-8?B?RVdrUmpQT0tZSEhCV3MxeUttVXBnMmF6MW15M3R1RDhEUHN5TDRjSjkzcjh0?= =?utf-8?B?MldKcGM0M2paRUg3UGttSmF2Z3NnYTVNb0dhZWo0eVNPZ1J2UGpTYXZSZGx3?= =?utf-8?Q?d3EZO7zA=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR1201MB1116;5:DAHTRKnoJt1druFX7K1YyHvRJeXU+E/CQmC17gn2Wy7ialN7roGaf1X1vW4j/BoB0mc6Jh632UGuaKy+fhlL2BvFgArHXYxymHJDmb/ceHpZsSS4MfpQXBgYWdbZk7h/Jgz3FBEBn2l6slht6xqG6w==;24:2Ab54/iQc7D9P8EEYAn40kA4FCfSAVLWSRzOMnM8irUrENiII03Dx81mPx0I5WZyE9BIawKTmiZ+VvhNDHTgpJa0YI2gstzEXNUUNEzlZkQ=;7:mXY+3fjIzOtE3vpVm3/M/1+36Rs1Jwqugurh09FPg5NfnkSDY2zFmYltOxObYK/8OwAecSDKpIG7cC4B51SHbgyk5IAwAOePvuul8UJgzgQQSGPJCXG61ryJXaKSmGvTo/5R5pm/U3MrOEYuFvCPFm/OxEZK8mS8vmqUkK85SvDJrwuEtb/Q8a7DGUzeMDAv;20:PvHbG1rAnUeDiv8CSzcQBn60eTYj/Flz1+aIR9MQTU6N0YtcC5IRatYcTI0cQp4vOEwerzy7JGLr/F5Fsc1gw+1SwAmos7n1pr2ykt7I3uSngFXlK3E4FU0z1+HE/PJWAxo3gg/W5hhyMIFBCFVJFICJZDORwjUoFRCCCjDFekIoXSKCCMnaMwHxxutVzvAEKB8BFEmgMgQmiZ/eJROcu5My2Z31vyHqzbtfS1oqd36qfvYOo50AazxEwpk6ujIw SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2016 18:20:49.6780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR1201MB1116 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2016 08:57 AM, Borislav Petkov wrote: > On Tue, May 10, 2016 at 02:43:58PM +0100, Matt Fleming wrote: >> Is it not possible to maintain some kind of kernel virtual address >> mapping so memremap*() and friends can figure out when to twiddle the >> mapping attributes and map with/without encryption? > > I guess we can move the sme_* specific stuff one indirection layer > below, i.e., in the *memremap() routines so that callers don't have to > care... That should keep the churn down... > We could do that, but we'll have to generate that list of addresses so that it can be checked against the range being mapped. Since this is part of early memmap support searching that list every time might not be too bad. I'll have to look into that and see what that looks like. Thanks, Tom