linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Duggan <aduggan@synaptics.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Christopher Heiny <cheiny@synaptics.com>,
	<linux-input@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH v2 0/3] input: rmi4: Regulator supply support
Date: Thu, 12 May 2016 17:52:06 -0700	[thread overview]
Message-ID: <57352536.7040909@synaptics.com> (raw)
In-Reply-To: <20160512030524.GA1256@tuxbot>

On 05/11/2016 08:05 PM, Bjorn Andersson wrote:
> On Wed 11 May 16:30 PDT 2016, Andrew Duggan wrote:
>
>> Hi Bjorn,
>>
>> On 05/10/2016 08:49 AM, Bjorn Andersson wrote:
> [..]
>>> So either we duplicate the regulator support in spi/i2c or we make them
>>> optional in the core driver. Sounds like you prefer the prior, i.e. v1
>>> of my patch.
>> Yes, after all this I think it makes sense to put regulator support in the
>> spi/i2c transports like in your v1 patch. I essentially duplicated the irq
>> handling code in both transports so I would be ok with duplicating regulator
>> support too. It doesn't seem like that much code. But, if this is too much
>> duplication we could create some sort of common file and put the common irq
>> and regulator support functions which could be called in the transports.
>> Similar to how rmi_2d_sensor.c defines some common functions shared between
>> rmi_f11 and rmi_f12.
>>
> Sounds reasonable, I'm okay with this. Did you have any comments on the
> implementation I had in v1?

I tested on a device which has an always on regulators so I didn't add 
anything to device tree for the device. But, it returned 0 when it 
didn't find anything which seems to be the correct behavior. Is there an 
easy way to avoid sleeping for 10ms when there are no regulators? Maybe 
check if both the supplies .consumer pointer is null?

Andrew

> @Dmitry, do you want me to resend v1?
>
> Regards,
> Bjorn

  reply	other threads:[~2016-05-13  0:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 16:57 [PATCH] Input: synaptics-rmi4: Support regulator supplies Bjorn Andersson
2016-03-31 18:19 ` Dmitry Torokhov
2016-03-31 19:14   ` Bjorn Andersson
2016-04-01  1:47     ` Andrew Duggan
2016-04-21 22:37       ` Bjorn Andersson
2016-05-05 20:55         ` Andrew Duggan
2016-05-06  0:58           ` Bjorn Andersson
2016-05-07  4:40             ` [PATCH v2 0/3] input: rmi4: Regulator supply support Bjorn Andersson
2016-05-07  4:40               ` [PATCH v2 1/3] input: rmi4: Move IRQ handling to rmi_driver Bjorn Andersson
2016-05-07  4:40               ` [PATCH v2 2/3] input: rmi4: Acquire and enable VDD and VIO supplies Bjorn Andersson
2016-05-09 19:58                 ` Rob Herring
2016-05-07  4:40               ` [PATCH v2 3/3] input: rmi4: Remove set_page() call before core is initialized Bjorn Andersson
2016-05-10  0:36               ` [PATCH v2 0/3] input: rmi4: Regulator supply support Andrew Duggan
2016-05-10 15:49                 ` Bjorn Andersson
2016-05-11 23:30                   ` Andrew Duggan
2016-05-12  3:05                     ` Bjorn Andersson
2016-05-13  0:52                       ` Andrew Duggan [this message]
2016-05-13 22:29                         ` Bjorn Andersson
2016-05-16 23:55                           ` Andrew Duggan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57352536.7040909@synaptics.com \
    --to=aduggan@synaptics.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=cheiny@synaptics.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).