From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753091AbcEMBq2 (ORCPT ); Thu, 12 May 2016 21:46:28 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:27454 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbcEMBq1 (ORCPT ); Thu, 12 May 2016 21:46:27 -0400 Subject: Re: [PATCH v4 10/18] sh: Remove unnecessary of_platform_populate with default match table To: Rich Felker References: <1463054775-18170-1-git-send-email-wangkefeng.wang@huawei.com> <1463054775-18170-11-git-send-email-wangkefeng.wang@huawei.com> <20160512183822.GL21636@brightrain.aerifal.cx> CC: , , , , , , , , , , , Yoshinori Sato From: Kefeng Wang Message-ID: <57353191.7020609@huawei.com> Date: Fri, 13 May 2016 09:44:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160512183822.GL21636@brightrain.aerifal.cx> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.573531E2.0015,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ae41cdc732526efb11c9a13ca81fa816 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/5/13 2:38, Rich Felker wrote: > On Thu, May 12, 2016 at 08:06:07PM +0800, Kefeng Wang wrote: >> After patch "of/platform: Add common method to populate default bus", >> it is possible for arch code to remove unnecessary callers about the >> of_platform_populate with default match table. > > s/about the/of/ ? Ok, will update. > >> Cc: Yoshinori Sato >> Cc: Rich Felker >> Signed-off-by: Kefeng Wang >> --- >> arch/sh/boards/of-generic.c | 14 -------------- >> 1 file changed, 14 deletions(-) >> >> diff --git a/arch/sh/boards/of-generic.c b/arch/sh/boards/of-generic.c >> index b4d4313..911ffb9 100644 >> --- a/arch/sh/boards/of-generic.c >> +++ b/arch/sh/boards/of-generic.c >> @@ -9,7 +9,6 @@ >> */ >> >> #include >> -#include >> #include >> #include >> #include >> @@ -179,16 +178,3 @@ void __init arch_init_clk_ops(struct sh_clk_ops **ops, int idx) >> void __init plat_irq_setup(void) >> { >> } >> - >> -static int __init sh_of_device_init(void) >> -{ >> - pr_info("SH generic board support: populating platform devices\n"); >> - if (of_have_populated_dt()) { >> - of_platform_populate(NULL, of_default_bus_match_table, >> - NULL, NULL); >> - } else { >> - pr_crit("Device tree not populated\n"); >> - } >> - return 0; >> -} >> -arch_initcall_sync(sh_of_device_init); >> -- >> 1.7.12.4 > > I have not tested this, but as long as the new arch-generic code takes > place at the same point in the init sequence (arch_initcall_sync), as > it seems to, I don't expect any sh-specific breakage. In general I'm > happy to see this kind of change. Hope no breakage in all archs, but I can only test this in few arm/arm64 boards :( Thanks, Kefeng > > Rich > > . >