From: Jon Hunter <jonathanh@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH V2 1/4] dt-bindings: bus: Add documentation for Tegra210 ACONNECT
Date: Mon, 16 May 2016 09:12:32 +0100 [thread overview]
Message-ID: <573980F0.2040301@nvidia.com> (raw)
In-Reply-To: <20160514142208.GA1462@rob-hp-laptop>
On 14/05/16 15:22, Rob Herring wrote:
> On Tue, May 10, 2016 at 12:35:37PM +0100, Jon Hunter wrote:
>> Add binding documentation for the Tegra ACONNECT bus that is part of the
>> Audio Processing Engine (APE) on Tegra210. The ACONNECT bus is used to
>> access devices within the APE subsystem. The APE is located in a
>> separate power domain and so accesses made to the ACONNECT require the
>> power domain to be enabled as well as some platform specific clocks.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> .../bindings/bus/nvidia,tegra210-aconnect.txt | 45 ++++++++++++++++++++++
>> 1 file changed, 45 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/bus/nvidia,tegra210-aconnect.txt
>>
>> diff --git a/Documentation/devicetree/bindings/bus/nvidia,tegra210-aconnect.txt b/Documentation/devicetree/bindings/bus/nvidia,tegra210-aconnect.txt
>> new file mode 100644
>> index 000000000000..81668f588eca
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/bus/nvidia,tegra210-aconnect.txt
>> @@ -0,0 +1,45 @@
>> +NVIDIA Tegra ACONNECT Bus
>> +
>> +The Tegra ACONNECT bus is an AXI switch which is used to connnect various
>> +components inside the Audio Processing Engine (APE). All CPU accesses to
>> +the APE subsystem go through the ACONNECT via an APB to AXI wrapper.
>> +
>> +Required properties:
>> +- compatible: Must be "nvidia,tegra210-aconnect".
>> +- clocks: Must contain the entries for the APE clock (TEGRA210_CLK_APE),
>> + and APE interface clock (TEGRA210_CLK_APB2APE).
>> +- clock-names: Must contain the names "ape" and "apb2ape" for the corresponding
>> + 'clocks' entries.
>> +- power-domains: Must contain a phandle that points to the audio powergate
>> + (namely 'aud') for Tegra210.
>> +- #address-cells: The number of cells used to represent physical base addresses
>> + in the aconnect address space. Should be 2.
>> +- #size-cells: The number of cells used to represent the size of an address
>> + range in the aconnect address space. Should be 2.
>
> You forgot to update these. With that,
Darn it, yes.
> Acked-by: Rob Herring <robh@kernel.org>
Thanks!
Jon
next prev parent reply other threads:[~2016-05-16 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 11:35 [PATCH V2 0/4] Add support for Tegra210 ACONNECT bus Jon Hunter
2016-05-10 11:35 ` [PATCH V2 1/4] dt-bindings: bus: Add documentation for Tegra210 ACONNECT Jon Hunter
2016-05-14 14:22 ` Rob Herring
2016-05-16 8:12 ` Jon Hunter [this message]
2016-05-10 11:35 ` [PATCH V2 2/4] bus: Add support for Tegra ACONNECT Jon Hunter
2016-05-10 11:35 ` [PATCH V2 3/4] ARM64: tegra: Add audio PM domain device node for Tegra210 Jon Hunter
2016-05-10 11:35 ` [PATCH V2 4/4] arm64: tegra: Add ACONNECT bus " Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573980F0.2040301@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).