From: Florian Fainelli <f.fainelli@gmail.com>
To: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"jim2101024@gmail.com" <jim2101024@gmail.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH v2 2/2] pci: host: Add Broadcom STB PCIE RC controller
Date: Mon, 16 May 2016 18:50:08 -0700 [thread overview]
Message-ID: <573A78D0.9090000@gmail.com> (raw)
In-Reply-To: <8520D5D51A55D047800579B094147198258955D9@XAP-PVEXMBX01.xlnx.xilinx.com>
On 05/11/2016 07:47 AM, Bharat Kumar Gogada wrote:
[snip]
>> + /* Get the value for the log2 of the scb sizes. Subtract 15 from
>> + * each because the target register field has 0==disabled and 1==6KB.
>> + */
>> + log2_scb_sizes = of_get_property(dn, "brcm,log2-scb-sizes", &rlen);
>> + if (log2_scb_sizes) {
>> + for (i = 0; i < rlen / sizeof(u32); i++) {
>> + pcie->scb_size_vals[i]
>> + = (int)of_read_number(log2_scb_sizes + i, 1)
>> + - 15;
>> + pcie->num_memc++;
>> + }
>> + }
> In your device tree documentation this is required property, what if this property
> is missing ?
If you look at the driver, you will see that it assumes a 1GB SCB window
size if this property is absent.
PS: Do you mind trimming your replies in the future just to quote the
relevant part? Pretty much like I just did, this greatly improves the
ability to jump right to where the comments are. Thanks
--
Florian
next prev parent reply other threads:[~2016-05-17 1:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 19:14 [PATCH v2 0/2] pci: host: Broadcom STB PCIE RC controller support Florian Fainelli
2016-05-05 19:14 ` [PATCH v2 1/2] Documentation: DT: bindings: Add Broadcom STB PCIe bindings Florian Fainelli
2016-05-05 21:15 ` Arnd Bergmann
2016-05-05 21:46 ` Florian Fainelli
2016-05-09 13:12 ` Arnd Bergmann
2016-05-10 17:00 ` Florian Fainelli
2016-05-10 19:51 ` Arnd Bergmann
2016-05-09 19:26 ` Rob Herring
2016-05-09 23:15 ` Florian Fainelli
2016-05-09 23:15 ` Florian Fainelli
2016-05-11 14:45 ` Bharat Kumar Gogada
2016-05-17 1:52 ` Florian Fainelli
2016-05-05 19:15 ` [PATCH v2 2/2] pci: host: Add Broadcom STB PCIE RC controller Florian Fainelli
2016-05-11 14:47 ` Bharat Kumar Gogada
2016-05-17 1:50 ` Florian Fainelli [this message]
2016-06-09 22:31 ` [PATCH v2 0/2] pci: host: Broadcom STB PCIE RC controller support Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573A78D0.9090000@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jim2101024@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).