From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbcERLHL (ORCPT ); Wed, 18 May 2016 07:07:11 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:36312 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbcERLHI convert rfc822-to-8bit (ORCPT ); Wed, 18 May 2016 07:07:08 -0400 X-AuditID: cbfee690-f79056d000001327-80-573c4cd94838 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <573C4CD9.5050200@samsung.com> Date: Wed, 18 May 2016 20:07:05 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Caizhiyong , Andrew Morton , "linux-pm@vger.kernel.org" , "kyungmin.park@samsung.com" , "myungjoo.ham@samsung.com" , lkml Cc: "Wanli (welly)" , "Wangming (Wonder)" , Quyaxin Subject: Re: [PATCH] devfreq: fix double call put_device References: In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsWyRsSkWPemj024wZwDohZz1q9hszj0Ywez xdmmN+wWl3fNYbP43HuE0WLtl05mi9uNK9gsPs5fwW7RdeIIqwOnx+O5G9k9Tsz4zeLRt2UV o8fnTXIBLFFcNimpOZllqUX6dglcGYffPWIquMVd8fXWcZYGxvWcXYycHBICJhLHXl5ih7DF JC7cW8/WxcjFISSwglFi8pK5zDBFHa37mUBsIYGljBJTT+uD2LwCghI/Jt9jAbGZBdQlJs1b BFTPAWSLSDSf5oIIa0ssW/iaGWLmA0aJTzv2sYDU8ApoSWy5ngBisgioSizdnwxSzgYU3f/i BhtIWFQgQqL7RCVIp4jAKiaJtfensoM4zALtjBJ/bh9kBSkSFrCQ6H5pDnFZuMSns6/BruQE 6r05YycjSL2EwD12iemzfrCCJFgEBCS+TT4EdoKEgKzEpgNQH0pKHFxxg2UCo/gsJI/NQvLY LITHZiF5bAEjyypG0dSC5ILipPQiE73ixNzi0rx0veT83E2MwEg9/e/ZhB2M9w5YH2IU4GBU 4uGN6LUOF2JNLCuuzD3EaAp00ERmKdHkfGA6yCuJNzQ2M7IwNTE1NjK3NFMS530t9TNYSCA9 sSQ1OzW1ILUovqg0J7X4ECMTB6dUA2PWJR6bAp9Yvve9p9ufOtupvucL5Vv8aZuKBPcf/c3W XXZXorl/HN6vm1VuqHCZ2az2ovHvNz9mxr3bt3oh35acWC9J08Q/zZuXrloT9ULiZ/vMNwds FExmhP589G5+QX+aHGNzhqvhvpWKXHq+V+JO7D/q8WJq6vbrT38e12l+cKpv+/kwrgwlluKM REMt5qLiRAB/UR0UzwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsVy+t9jAd2bPjbhBs+aeS3mrF/DZnHoxw5m i7NNb9gtLu+aw2bxufcIo8XaL53MFrcbV7BZfJy/gt2i68QRVgdOj8dzN7J7nJjxm8Wjb8sq Ro/Pm+QCWKIaGG0yUhNTUosUUvOS81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ0 3TJzgI5RUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesbEgTXY2SABhLWMGZ07r7DXHCCu+L9 jV/MDYxzObsYOTkkBEwkOlr3M0HYYhIX7q1nA7GFBJYySkw9rQ9i8woISvyYfI+li5GDg1lA XuLIpWyQMLOAusSkeYuYuxi5gMofMEp82rEPrIZXQEtiy/UEEJNFQFVi6f5kkHI2oOj+FzfY QMKiAhES3ScqQTpFBFYxSay9P5UdxGEWaGeU+HP7ICtIkbCAhUT3S3OIa8IlPp19DXYlJ1Dv zRk7GScwCsxCctwshONmITluASPzKkaJ1ILkguKk9FzDvNRyveLE3OLSvHS95PzcTYzg6H4m tYPx4C73Q4wCHIxKPLwb+q3DhVgTy4orcw8xSnAwK4nw/vW2CRfiTUmsrEotyo8vKs1JLT7E aAr03kRmKdHkfGDiySuJNzQ2MTOyNDI3tDAyNlcS5338f12YkEB6YklqdmpqQWoRTB8TB6dU A2Ov9ozXW/Nur3/202jjlXjXfdXeG9c7Py1yaXvLLM3Kc0KtKu74g+PzPWdW3S119e7tNjNh ZPh7aKZU+IXi5Wlf7XQPctWtlvv//G9+zaNpv+X21K39MaszV2l/aJbOp7WJy1iTI9qmH53x ZNfdRJfG041/6jKtXyQbLdw+416J4P/w/G7Lf/OUWIozEg21mIuKEwFkEAQzBAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cai, On 2016년 05월 14일 15:28, Caizhiyong wrote: > From: Cai Zhiyong > Date: Sat, 14 May 2016 14:13:30 +0800 > Subject: [PATCH] devfreq: fix double call put_device The patch description don't need to include the 'Date/Subject'. You need to delete them. > > 1295 */ > 1296 void device_unregister(struct device *dev) > 1297 { > 1298 pr_debug("device: '%s': %s\n", dev_name(dev), __func__); > 1299 device_del(dev); > 1300 put_device(dev); > 1301 } > 1302 EXPORT_SYMBOL_GPL(device_unregister); > 1303 Also, you don't need to include the source code of device_unregister() because below description explains the why this patch is needed. > > device_unregister is called put_device, there is no need to call > put_device(&devfreq->dev) again. > > Signed-off-by: Cai Zhiyong > --- > drivers/devfreq/devfreq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index 1d6c803..8de22c0 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -621,7 +621,6 @@ int devfreq_remove_device(struct devfreq *devfreq) > return -EINVAL; > > device_unregister(&devfreq->dev); > - put_device(&devfreq->dev); > > return 0; > } > If you modify the patch description, Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi