From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754556AbcESKHh (ORCPT ); Thu, 19 May 2016 06:07:37 -0400 Received: from smtp137.dfw.emailsrvr.com ([67.192.241.137]:35745 "EHLO smtp137.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753960AbcESKHf (ORCPT ); Thu, 19 May 2016 06:07:35 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH v3 12/14] staging: comedi: daqboard2000: rename reference DACs register macros To: devel@driverdev.osuosl.org References: <1463575029-12089-13-git-send-email-abbotti@mev.co.uk> <1463651889-7297-1-git-send-email-abbotti@mev.co.uk> Cc: Greg Kroah-Hartman , H Hartley Sweeten , linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <573D9064.2050009@mev.co.uk> Date: Thu, 19 May 2016 11:07:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1463651889-7297-1-git-send-email-abbotti@mev.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/16 10:58, Ian Abbott wrote: > Rename the macros that define values for the reference DACs register to > avoid CamelCase, and to make it clearer which register they are > associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value > `0x0080` that triggers setting one of the references. > > Signed-off-by: Ian Abbott > Reviewed-by: H Hartley Sweeten > --- > v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`. > v3: Corrected typo in commit: 0x80 --> 0x0080. > --- > drivers/staging/comedi/drivers/daqboard2000.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Dammit! I missed the other, glaring typo in the commit. `DAQBOARD2000_REF_DACS_SET` should be `DB2K_REQ_DACS_SET`. I'll post a v4 of this patch. Sorry for the bother. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-