From: Caesar Wang <wxt@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Mark Brown <broonie@kernel.org>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Xu Jianqun <jay.xu@rock-chips.com>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document
Date: Fri, 20 May 2016 00:04:07 +0800 [thread overview]
Message-ID: <573DE3F7.6070300@rock-chips.com> (raw)
In-Reply-To: <3685935.dKdIbE8hXb@phil>
在 2016年05月19日 23:51, Heiko Stuebner 写道:
> Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang:
>> We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3399
>> family SoCs in linux kernel.
>>
>> Let's add the other SoCs, in order to a better understanding from the
>> rockchip spi document.
>>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Mark Brown <broonie@kernel.org>
>> Cc: Heiko Stuebner <heiko@sntech.de>
>> Cc: linux-rockchip@lists.infradead.org
>> ---
>>
>> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt
>> b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index
>> 1b14d69..305b542 100644
>> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt
>> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt
>> @@ -6,9 +6,12 @@ and display controllers using the SPI communication
>> interface. Required Properties:
>>
>> - compatible: should be one of the following.
>> + "rockchip,rk3036-spi" for rk3036.
> shouldn't the rk3036 also get the rk3066 fallback. Looking at the driver
> part (patch2) the rk3036 still is the same IP as for every other soc in
> here.
Yep, the same IP.
Do you think we should keep the below style?
1)
"rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036.
"rockchip,rk3066-spi" for rk3066.
"rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188.
...
or
2)
"rockchip,rk3066-spi" for rk3066.
"rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036.
"rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188
..
or
3)
"rockchip, rockchip-spi" for rk3036 rk3066.......
Think about the 1) will be googd select.
-Caesar
>> "rockchip,rk3066-spi" for rk3066.
>> "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188.
>> + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228.
>> "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288.
>> + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368.
>> "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399.
>> - reg: physical base address of the controller and length of memory
>> mapped region.
>
>
>
next prev parent reply other threads:[~2016-05-19 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 15:47 [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document Caesar Wang
2016-05-19 15:47 ` [PATCH 2/3] spi/rockchip: add the rk3036/rk3228/rk3368 to match for driver Caesar Wang
2016-05-31 17:46 ` Applied "spi/rockchip: add the rk3036/rk3228/rk3368 to match for driver" to the spi tree Mark Brown
2016-05-19 15:47 ` [PATCH 3/3] ARM: dts: rockchip: fixes the spi compatible for rk3036 Caesar Wang
2016-05-19 15:51 ` [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document Heiko Stuebner
2016-05-19 16:04 ` Caesar Wang [this message]
2016-05-19 16:20 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573DE3F7.6070300@rock-chips.com \
--to=wxt@rock-chips.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jay.xu@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).