[PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

[PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

[Ravishankar Karkala Mallikarjunayya]

This is a patch to the s626.c file that fixes up a  line over
80 characters issues found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
---
Changes since V1:
- No change
---
 drivers/staging/comedi/drivers/s626.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 1d663a0..b37ba87 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -2520,7 +2520,8 @@ static int s626_initialize(struct comedi_device *dev)
 	for (i = 0; i < 2; i++) {
 		writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
 		s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
-		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
+		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+				     0);
 		if (ret)
 			return ret;
 	}
-- 
1.9.1

Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

[Ian Abbott]

On 20/05/16 07:22, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a  line over
> 80 characters issues found by the checkpatch.pl tool.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> ---
> Changes since V1:
> - No change
> ---
>   drivers/staging/comedi/drivers/s626.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

[Luis de Bethencourt]

On 18/06/16 04:51, Greg KH wrote:
> On Mon, May 30, 2016 at 03:21:27PM +0100, Luis de Bethencourt wrote:
>> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
>>> This is a patch to the s626.c file that fixes up a  line over 80
>>> characters issues found by the checkpatch.pl tool.
>>>
>>> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
>>
>> Looks good :)
>>
>> This is the only instance of the line over 80 characters Warning in that file.
>>
>> Like previous patches, no need to mention the file being fixed in the commit
>> message. It isn't a big deal though.
>>
>> +1
> 
> Not much I can do with at "+1", please respond with a:
> 	Acked-by:
> or even better:
> 	Reviewed-by:
> 
> with the proper info, so I can add it to the patch and give you credit
> for reviewing it.
> 
> thanks,
> 
> greg k-h
> 

Reviewed-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Sorry, sometimes I am not sure if my comments warrant an Acked-by/Reviewed-by.

Will always add one from now on.

Thanks :)
Luis

Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

[Greg KH]

On Mon, May 30, 2016 at 03:21:27PM +0100, Luis de Bethencourt wrote:
> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> > This is a patch to the s626.c file that fixes up a  line over 80
> > characters issues found by the checkpatch.pl tool.
> > 
> > Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> 
> Looks good :)
> 
> This is the only instance of the line over 80 characters Warning in that file.
> 
> Like previous patches, no need to mention the file being fixed in the commit
> message. It isn't a big deal though.
> 
> +1

Not much I can do with at "+1", please respond with a:
	Acked-by:
or even better:
	Reviewed-by:

with the proper info, so I can add it to the patch and give you credit
for reviewing it.

thanks,

greg k-h

Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

[Ian Abbott]

On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a  line over 80
> characters issues found by the checkpatch.pl tool.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
> ---
> changes since v1: No change
> ---
>   drivers/staging/comedi/drivers/s626.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

[Luis de Bethencourt]

On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a  line over 80
> characters issues found by the checkpatch.pl tool.
> 
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>

Looks good :)

This is the only instance of the line over 80 characters Warning in that file.

Like previous patches, no need to mention the file being fixed in the commit
message. It isn't a big deal though.

+1

Luis

[PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c

[Ravishankar Karkala Mallikarjunayya]

This is a patch to the s626.c file that fixes up a  line over 80
characters issues found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
---
changes since v1: No change
---
 drivers/staging/comedi/drivers/s626.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 790ca41..b5cd946 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -2520,7 +2520,8 @@ static int s626_initialize(struct comedi_device *dev)
 	for (i = 0; i < 2; i++) {
 		writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
 		s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
-		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
+		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+				     0);
 		if (ret)
 			return ret;
 	}
-- 
1.9.1