From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754462AbcETOLT (ORCPT ); Fri, 20 May 2016 10:11:19 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:7253 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbcETOLS (ORCPT ); Fri, 20 May 2016 10:11:18 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Fri, 20 May 2016 07:09:07 -0700 Subject: Re: [PATCH V6 3/3] soc/tegra: pmc: Add support for IO pads power state and voltage To: Laxman Dewangan , , , References: <1463745564-19297-1-git-send-email-ldewangan@nvidia.com> <1463745564-19297-4-git-send-email-ldewangan@nvidia.com> <573F11F5.7010702@nvidia.com> <573F125A.20102@nvidia.com> CC: , , , From: Jon Hunter Message-ID: <573F1AFE.3080906@nvidia.com> Date: Fri, 20 May 2016 15:11:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <573F125A.20102@nvidia.com> X-Originating-IP: [10.21.132.103] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL102.nvidia.com (10.26.138.15) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/16 14:34, Laxman Dewangan wrote: > > On Friday 20 May 2016 07:02 PM, Jon Hunter wrote: >> On 20/05/16 12:59, Laxman Dewangan wrote: >>> +/* tegra_io_pads_config_info: Tegra IO pads bit config info. >>> + * @dpd_config_bit: DPD configuration bit position. -1 if not >>> supported. >>> + * @voltage_config_bit: Voltage configuration bit position. -1 if >>> not supported. >>> + * @soc_mask: Bitwise OR of SoC masks if IO pads supported on that SoC. >>> + */ >> Comment coding style :-( > > I saw this style multiple places and so intentionally left here. > If comment is inside the code then > /* > * first-line comment > * second line > */ > > but for function, it can have in single line. > > Anyhow, I will correct in next cycle. Actually, this should be in kernel-doc format [0]. Jon [0] Documentation/kernel-doc-nano-HOWTO.txt