From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756000AbcETQap (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 May 2016 12:30:45 -0400
Received: from smtp89.iad3a.emailsrvr.com ([173.203.187.89]:55244 "EHLO
	smtp89.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754340AbcETQao (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 May 2016 12:30:44 -0400
X-Auth-ID: abbotti@mev.co.uk
X-Sender-Id: abbotti@mev.co.uk
Subject: Re: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080
 register offsets
To: Hartley Sweeten <HartleyS@visionengravers.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
References: <1463752162-15181-1-git-send-email-abbotti@mev.co.uk>
 <1463752162-15181-4-git-send-email-abbotti@mev.co.uk>
 <CO2PR01MB2088DC6A7EF083E9E3AF0B78D04B0@CO2PR01MB2088.prod.exchangelabs.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: Ian Abbott <abbotti@mev.co.uk>
Message-ID: <573F3BB2.6020601@mev.co.uk>
Date: Fri, 20 May 2016 17:30:42 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <CO2PR01MB2088DC6A7EF083E9E3AF0B78D04B0@CO2PR01MB2088.prod.exchangelabs.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/05/16 17:21, Hartley Sweeten wrote:
> On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
>> Rename the macros in "plx9080.h" that define the offsets of registers,
>> following the pattern `PLX_REG_<NAME>`, where `<NAME>` is the register
>> name from the PLX PCI 9080 Data Book.
>>
>> Add defines for the "Mailbox" registers, and add parameterized macros
>> for the mailbox registers and the DMA control registers.  Make use of
>> the parameterized versions of the macros where it seems appropriate.
>>
>> The registers for supporting the I2O (Intelligent Input/Output) feature
>> are largely left undefined, just defining enough to allow the I2O
>> feature to be disabled.
>>
>> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
>
> Ian,
>
> Just an comment on your renaming.
>
> You also renamed the registers in the daqbook2000 driver in the
> <driver>_REG_<name> format. Personally I prefer the format to be
> <driver>_<name>_REG. That way a grep for <driver>_<name> will
> return both the register and bit uses.
>
> Currently the <driver>_REG_<name> form is not as common in comedi.
> Looks like it's only used in amcc_35933.h and will be in daqboard2000.c.
>
> The <driver>_<name>_REG form is used a lot.
>
> Not a big deal, just a comment.

It makes it easier to distinguish the register offsets from the register 
values, imho.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-