From: Shuah Khan <shuahkh@osg.samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
mchehab@osg.samsung.com, laurent.pinchart@ideasonboard.com,
sakari.ailus@iki.fi, hans.verkuil@cisco.com,
chehabrafael@gmail.com, javier@osg.samsung.com,
inki.dae@samsung.com, g.liakhovetski@gmx.de,
jh1009.sung@samsung.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH 2/3] media: add media_device_unregister_put() interface
Date: Tue, 24 May 2016 11:13:11 -0600 [thread overview]
Message-ID: <57448BA7.3040107@osg.samsung.com> (raw)
In-Reply-To: <5742EBDA.1010902@xs4all.nl>
On 05/23/2016 05:39 AM, Hans Verkuil wrote:
> On 05/13/2016 07:09 PM, Shuah Khan wrote:
>> Add media_device_unregister_put() interface to release reference to a media
>> device allocated using the Media Device Allocator API. The media device is
>> unregistered and freed when the last driver that holds the reference to the
>> media device releases the reference. The media device is unregistered and
>> freed in the kref put handler.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> drivers/media/media-device.c | 11 +++++++++++
>> include/media/media-device.h | 15 +++++++++++++++
>> 2 files changed, 26 insertions(+)
>>
>> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
>> index 33a9952..b5c279a 100644
>> --- a/drivers/media/media-device.c
>> +++ b/drivers/media/media-device.c
>> @@ -36,6 +36,7 @@
>> #include <media/media-device.h>
>> #include <media/media-devnode.h>
>> #include <media/media-entity.h>
>> +#include <media/media-dev-allocator.h>
>>
>> #ifdef CONFIG_MEDIA_CONTROLLER
>>
>> @@ -818,6 +819,16 @@ void media_device_unregister(struct media_device *mdev)
>> }
>> EXPORT_SYMBOL_GPL(media_device_unregister);
>>
>> +void media_device_unregister_put(struct media_device *mdev)
>> +{
>> + if (mdev == NULL)
>> + return;
>> +
>> + dev_dbg(mdev->dev, "%s: mdev %p\n", __func__, mdev);
>> + media_device_put(mdev);
>> +}
>> +EXPORT_SYMBOL_GPL(media_device_unregister_put);
>> +
>
> I don't really see the need for a new unregister_put function. The only thing
> it adds compared to media_device_put is the 'if (mdev == NULL)' check.
>
> Is that check needed at all?
Yeah. My reasoning for keeping this for symmetry in drivers
with _register() and _unregister(). However, drivers already
required to call media_device_put() in _register error legs.
>
> I would probably go for an API like this:
>
> <brainstorm mode on>
>
> /* Not sure if there should be a void *priv as the last argument */
> int (*mdev_init_fnc)(struct media_device *mdev, struct device *dev);
>
> /* Perhaps a void *priv is needed to pass to mdev_init_fnc?
> The callback is there to initialize the media_device and it's called
> with the lock held.
> */
> struct media_device *media_device_allocate(struct device *dev, mdev_init_fnc fnc);
>
> /* Helper function for usb devices */
> struct media_device *media_device_usb_allocate(struct usb_device *udev,
> char *driver_name);
>
> /* counterpart of media_device_allocate, that makes more sense than allocate/put IMHO */
> void media_device_release(struct media_device *mdev);
We already have a media_device_release() that gets used as devnode->release
back. I will use a different name, media_device_usb_free() or something
similar.
>
> <brainstorm mode off>
>
> Regards,
>
> Hans
>
>> static void media_device_release_devres(struct device *dev, void *res)
>> {
>> }
>> diff --git a/include/media/media-device.h b/include/media/media-device.h
>> index f743ae2..8bd836e 100644
>> --- a/include/media/media-device.h
>> +++ b/include/media/media-device.h
>> @@ -499,6 +499,18 @@ int __must_check __media_device_register(struct media_device *mdev,
>> void media_device_unregister(struct media_device *mdev);
>>
>> /**
>> + * media_device_unregister_put() - Unregisters a media device element
>> + *
>> + * @mdev: pointer to struct &media_device
>> + *
>> + * Should be called to unregister media device allocated with Media Device
>> + * Allocator API media_device_get() interface.
>> + * It is safe to call this function on an unregistered (but initialised)
>> + * media device.
>> + */
>> +void media_device_unregister_put(struct media_device *mdev);
>> +
>> +/**
>> * media_device_register_entity() - registers a media entity inside a
>> * previously registered media device.
>> *
>> @@ -658,6 +670,9 @@ static inline int media_device_register(struct media_device *mdev)
>> static inline void media_device_unregister(struct media_device *mdev)
>> {
>> }
>> +static inline void media_device_unregister_put(struct media_device *mdev)
>> +{
>> +}
>> static inline int media_device_register_entity(struct media_device *mdev,
>> struct media_entity *entity)
>> {
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-05-24 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 17:09 [PATCH 0/3] Media Device Allocator API Shuah Khan
2016-05-13 17:09 ` [PATCH 1/3] media: " Shuah Khan
2016-05-23 11:26 ` Hans Verkuil
2016-05-24 17:05 ` Shuah Khan
2016-05-13 17:09 ` [PATCH 2/3] media: add media_device_unregister_put() interface Shuah Khan
2016-05-23 11:39 ` Hans Verkuil
2016-05-24 17:13 ` Shuah Khan [this message]
2016-05-13 17:09 ` [PATCH 3/3] media: change au0828 to use Media Device Allocator API Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57448BA7.3040107@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=chehabrafael@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jh1009.sung@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).