From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755132AbcEXSPJ (ORCPT ); Tue, 24 May 2016 14:15:09 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:35738 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbcEXSPH (ORCPT ); Tue, 24 May 2016 14:15:07 -0400 Message-ID: <57449A28.3020901@gmail.com> Date: Tue, 24 May 2016 11:15:04 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Anna-Maria Gleixner CC: linux-kernel@vger.kernel.org, rt@linutronix.de, Ralf Baechle , linux-mips@linux-mips.org Subject: Re: [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions References: <1464095327-55194-1-git-send-email-anna-maria@linutronix.de> In-Reply-To: <1464095327-55194-1-git-send-email-anna-maria@linutronix.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/24/2016 06:08 AM, Anna-Maria Gleixner wrote: > The corresponding FROZEN hotplug notifier transitions used on > suspend/resume are ignored. Therefore the switch case action argument > is masked with the frozen hotplug notifier transition mask. > > Cc: Ralf Baechle > Cc: linux-mips@linux-mips.org > Signed-off-by: Anna-Maria Gleixner This seems sane, and I don't object, but can you tell us how this was tested? Thanks, David Daney > --- > arch/mips/cavium-octeon/smp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -384,7 +384,7 @@ static int octeon_cpu_callback(struct no > { > unsigned int cpu = (unsigned long)hcpu; > > - switch (action) { > + switch (action & ~CPU_TASKS_FROZEN) { > case CPU_UP_PREPARE: > octeon_update_boot_vector(cpu); > break; > >