From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Kukjin Kim <kgene@kernel.org>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks
Date: Wed, 25 May 2016 10:19:40 +0200 [thread overview]
Message-ID: <5745601C.6000806@samsung.com> (raw)
In-Reply-To: <1464095957-25851-2-git-send-email-b.zolnierkie@samsung.com>
On 05/24/2016 03:19 PM, Bartlomiej Zolnierkiewicz wrote:
> Open-code samsung_cmu_register_one() calls for CMU_APOLLO and
> CMU_ATLAS setup code as a preparation for adding CPU clocks
> support for Exynos5433.
>
> There should be no functional change resulting from this patch.
>
> Cc: Kukjin Kim <kgene@kernel.org>
> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/clk/samsung/clk-exynos5433.c | 85 +++++++++++++++++++++++-------------
> drivers/clk/samsung/clk.c | 12 ++---
> drivers/clk/samsung/clk.h | 4 ++
> 3 files changed, 65 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index 128527b..6dd81ed 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -11,6 +11,7 @@
>
> #include <linux/clk-provider.h>
> #include <linux/of.h>
> +#include <linux/of_address.h>
>
> #include <dt-bindings/clock/exynos5433.h>
>
> @@ -3594,23 +3595,35 @@ static struct samsung_gate_clock apollo_gate_clks[] __initdata = {
> CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0),
> };
>
> -static struct samsung_cmu_info apollo_cmu_info __initdata = {
> - .pll_clks = apollo_pll_clks,
> - .nr_pll_clks = ARRAY_SIZE(apollo_pll_clks),
> - .mux_clks = apollo_mux_clks,
> - .nr_mux_clks = ARRAY_SIZE(apollo_mux_clks),
> - .div_clks = apollo_div_clks,
> - .nr_div_clks = ARRAY_SIZE(apollo_div_clks),
> - .gate_clks = apollo_gate_clks,
> - .nr_gate_clks = ARRAY_SIZE(apollo_gate_clks),
> - .nr_clk_ids = APOLLO_NR_CLK,
> - .clk_regs = apollo_clk_regs,
> - .nr_clk_regs = ARRAY_SIZE(apollo_clk_regs),
> -};
> -
> static void __init exynos5433_cmu_apollo_init(struct device_node *np)
> {
> - samsung_cmu_register_one(np, &apollo_cmu_info);
> + void __iomem *reg_base;
> + struct samsung_clk_provider *ctx;
> +
> + reg_base = of_iomap(np, 0);
> + if (!reg_base) {
> + panic("%s: failed to map registers\n", __func__);
> + return;
> + }
> +
> + ctx = samsung_clk_init(np, reg_base, APOLLO_NR_CLK);
> + if (!ctx) {
> + panic("%s: unable to allocate ctx\n", __func__);
> + return;
> + }
> +
> + samsung_clk_register_pll(ctx, apollo_pll_clks,
> + ARRAY_SIZE(apollo_pll_clks), reg_base);
> + samsung_clk_register_mux(ctx, apollo_mux_clks,
> + ARRAY_SIZE(apollo_mux_clks));
> + samsung_clk_register_div(ctx, apollo_div_clks,
> + ARRAY_SIZE(apollo_div_clks));
> + samsung_clk_register_gate(ctx, apollo_gate_clks,
> + ARRAY_SIZE(apollo_gate_clks));
> + samsung_clk_sleep_init(reg_base, apollo_clk_regs,
> + ARRAY_SIZE(apollo_clk_regs));
> +
> + samsung_clk_of_add_provider(np, ctx);
> }
> CLK_OF_DECLARE(exynos5433_cmu_apollo, "samsung,exynos5433-cmu-apollo",
> exynos5433_cmu_apollo_init);
> @@ -3806,23 +3819,35 @@ static struct samsung_gate_clock atlas_gate_clks[] __initdata = {
> CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0),
> };
>
> -static struct samsung_cmu_info atlas_cmu_info __initdata = {
> - .pll_clks = atlas_pll_clks,
> - .nr_pll_clks = ARRAY_SIZE(atlas_pll_clks),
> - .mux_clks = atlas_mux_clks,
> - .nr_mux_clks = ARRAY_SIZE(atlas_mux_clks),
> - .div_clks = atlas_div_clks,
> - .nr_div_clks = ARRAY_SIZE(atlas_div_clks),
> - .gate_clks = atlas_gate_clks,
> - .nr_gate_clks = ARRAY_SIZE(atlas_gate_clks),
> - .nr_clk_ids = ATLAS_NR_CLK,
> - .clk_regs = atlas_clk_regs,
> - .nr_clk_regs = ARRAY_SIZE(atlas_clk_regs),
> -};
> -
> static void __init exynos5433_cmu_atlas_init(struct device_node *np)
> {
> - samsung_cmu_register_one(np, &atlas_cmu_info);
> + void __iomem *reg_base;
> + struct samsung_clk_provider *ctx;
> +
> + reg_base = of_iomap(np, 0);
> + if (!reg_base) {
> + panic("%s: failed to map registers\n", __func__);
> + return;
Return is useless here.
> + }
> +
> + ctx = samsung_clk_init(np, reg_base, ATLAS_NR_CLK);
> + if (!ctx) {
> + panic("%s: unable to allocate ctx\n", __func__);
> + return;
> + }
This entire if() is useless. The samsung_clk_init() already panics. I
recently tried to make it consistent across our drivers:
http://www.spinics.net/lists/arm-kernel/msg503014.html
Beside that, looks fine.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-05-25 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 13:19 [PATCH 0/3] clk: samsung: add Exynos5433 CPU clocks Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` [PATCH 1/3] clk: samsung: exynos5433: prepare for adding " Bartlomiej Zolnierkiewicz
2016-05-25 8:19 ` Krzysztof Kozlowski [this message]
2016-06-18 14:40 ` Tomasz Figa
2016-06-20 13:35 ` Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` [PATCH 2/3] clk: samsung: cpu: prepare for adding Exynos5433 " Bartlomiej Zolnierkiewicz
2016-05-25 8:31 ` Krzysztof Kozlowski
2016-06-18 14:53 ` Tomasz Figa
2016-06-20 13:54 ` Bartlomiej Zolnierkiewicz
2016-05-24 13:19 ` [PATCH 3/3] clk: samsung: exynos5433: add CPU clocks configuration data and instantiate " Bartlomiej Zolnierkiewicz
2016-05-25 9:34 ` Krzysztof Kozlowski
2016-06-18 14:57 ` Tomasz Figa
2016-06-20 13:57 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5745601C.6000806@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).