From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754048AbcEYKt1 (ORCPT ); Wed, 25 May 2016 06:49:27 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:58964 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753884AbcEYKtZ (ORCPT ); Wed, 25 May 2016 06:49:25 -0400 Subject: Re: [PATCH 3/4 v7] ASoC: dwc: Add PIO PCM extension To: Mark Brown , Jose Abreu References: <20160524164151.GM8206@sirena.org.uk> <57448A42.9050606@synopsys.com> <20160524175144.GO8206@sirena.org.uk> <57457A63.5060702@synopsys.com> <20160525101801.GT8206@sirena.org.uk> CC: , Carlos Palminha , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "Rob Herring" , Alexey Brodkin , , , From: Jose Abreu Message-ID: <57458328.8080900@synopsys.com> Date: Wed, 25 May 2016 11:49:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160525101801.GT8206@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.39] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 25-05-2016 11:18, Mark Brown wrote: > On Wed, May 25, 2016 at 11:11:47AM +0100, Jose Abreu wrote: > >> I think I will take the second option. Something like this: >> " >> ret = snd_dmaengine_pcm_register(...) >> if (ret == -EPROBE_DEFER) >> return ret; >> else >> pio_register(...); >> "? > Sure. You should print a diagnostic if you fail to get the DMA, for any > real system it's going to be a bug. Ok, will do that. I noticed the last I2S patch that you merged ("ASoC: dwc: Add helper functions to disable/enable irqs") is not in for-next yet. Should I base my work on 'topic/dwc' branch? Best regards, Jose Miguel Abreu