From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753722AbcEZLHP (ORCPT ); Thu, 26 May 2016 07:07:15 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:34511 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627AbcEZLHO (ORCPT ); Thu, 26 May 2016 07:07:14 -0400 Message-ID: <5746D8DB.8000305@collabora.com> Date: Thu, 26 May 2016 13:07:07 +0200 From: Enric Balletbo i Serra User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Benson Leung , olof@lixom.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "platform/chrome: chromeos_laptop: Add Leon Touch" References: <1464227951-19689-1-git-send-email-bleung@chromium.org> In-Reply-To: <1464227951-19689-1-git-send-email-bleung@chromium.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Benson, Olof On 26/05/16 03:59, Benson Leung wrote: > This reverts commit bff3c624dc7261a084a4d25a0b09c3fb0fec872a. > > Board "Leon" is otherwise known as "Toshiba CB35" and we already have > the entry that supports that board as of this commit : > 963cb6f platform/chrome: chromeos_laptop - Add Toshiba CB35 Touch > > Remove this duplicate. > > Signed-off-by: Benson Leung > --- > drivers/platform/chrome/chromeos_laptop.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c > index 8398a7d..e8a44a9 100644 > --- a/drivers/platform/chrome/chromeos_laptop.c > +++ b/drivers/platform/chrome/chromeos_laptop.c > @@ -514,13 +514,6 @@ static struct chromeos_laptop cr48 = { > }, > }; > > -static struct chromeos_laptop leon = { > - .i2c_peripherals = { > - /* Touchpad. */ > - { .add = setup_cyapa_tp, I2C_ADAPTER_DESIGNWARE_0 }, > - }, > -}; > - > #define _CBDD(board_) \ > .callback = chromeos_laptop_dmi_matched, \ > .driver_data = (void *)&board_ > @@ -608,14 +601,6 @@ static struct dmi_system_id chromeos_laptop_dmi_table[] __initdata = { > }, > _CBDD(cr48), > }, > - { > - .ident = "Leon", > - .matches = { > - DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"), > - DMI_MATCH(DMI_PRODUCT_NAME, "Leon"), > - }, > - _CBDD(leon), > - }, > { } > }; > MODULE_DEVICE_TABLE(dmi, chromeos_laptop_dmi_table); > I think my patch is not applied in mainline yet, I'm not sure if Olof has the patch in his working tree but in such case maybe he can simply remove the patch instead of apply and then revert it? Just an opinion, thanks. Enric