From: Yunlong Song <yunlong.song@huawei.com>
To: <jaegeuk@kernel.org>, <cm224.lee@samsung.com>,
<yuchao0@huawei.com>, <chao@kernel.org>, <sylinux@163.com>
Cc: <bintian.wang@huawei.com>, <houpengyang@huawei.com>,
<heyunlei@huawei.com>, <liushuoran@huawei.com>,
<shiguojun@huawei.com>, <linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] f2fs: Return the errno to the caller to avoid using a wrong page
Date: Thu, 26 May 2016 19:30:44 +0800 [thread overview]
Message-ID: <5746DE64.2040908@huawei.com> (raw)
In-Reply-To: <1464237511-2181-1-git-send-email-yunlong.song@huawei.com>
> page_hit:
> - f2fs_bug_on(sbi, nid != nid_of_node(page));
> + if(nid != nid_of_node(page)) {
should add "unlikely" here, will fix this in v3 patch.
> + f2fs_bug_on(sbi, 1);
> + ClearPageUptodate(page);
> +out_err:
> + f2fs_put_page(page, 1);
> + return ERR_PTR(-EIO);
> + }
> return page;
> }
>
>
--
Thanks,
Yunlong Song
next prev parent reply other threads:[~2016-05-26 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 13:01 [PATCH] f2fs: Return the errno to the caller to avoid using a wrong page Yunlong Song
2016-05-25 16:54 ` Jaegeuk Kim
2016-05-27 12:22 ` Yunlong Song
2016-05-26 4:38 ` [PATCH v2] " Yunlong Song
2016-05-26 11:30 ` Yunlong Song [this message]
2016-05-26 11:40 ` [PATCH v3] " Yunlong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5746DE64.2040908@huawei.com \
--to=yunlong.song@huawei.com \
--cc=bintian.wang@huawei.com \
--cc=chao@kernel.org \
--cc=cm224.lee@samsung.com \
--cc=heyunlei@huawei.com \
--cc=houpengyang@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=liushuoran@huawei.com \
--cc=shiguojun@huawei.com \
--cc=sylinux@163.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).