From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Daeseok Youn <daeseok.youn@gmail.com>, lidza.louina@gmail.com
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] staging: dgnc: remove unused variable 'intr_modem'
Date: Fri, 27 May 2016 12:54:42 +0100 [thread overview]
Message-ID: <57483582.2080307@osg.samsung.com> (raw)
In-Reply-To: <20160527065317.GA2966@SEL-JYOUN-D1>
On 27/05/16 07:53, Daeseok Youn wrote:
> The 'intr_modem' variable was used only for increasing.
> So the 'intr_modem' variable is not useful for this driver.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_cls.c | 1 -
> drivers/staging/dgnc/dgnc_driver.h | 1 -
> drivers/staging/dgnc/dgnc_neo.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index dcb808f..8cb7361 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -406,7 +406,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, uint port)
>
> /* CTS/RTS change of state */
> if (isr & UART_IIR_CTSRTS) {
> - brd->intr_modem++;
> ch->ch_intr_modem++;
> /*
> * Don't need to do anything, the cls_parse_modem
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 7ac33ed..2caeff7 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -183,7 +183,6 @@ struct dgnc_board {
> uint nasync; /* Number of ports on card */
>
> uint irq; /* Interrupt request number */
> - ulong intr_modem; /* Count of interrupts */
> ulong intr_tx; /* Count of interrupts */
> ulong intr_rx; /* Count of interrupts */
>
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 3f8bbb3..a3e100b 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -452,7 +452,6 @@ static inline void neo_parse_isr(struct dgnc_board *brd, uint port)
> * If we get here, this means the hardware is doing auto flow control.
> * Check to see whether RTS/DTR or CTS/DSR caused this interrupt.
> */
> - brd->intr_modem++;
> ch->ch_intr_modem++;
> cause = readb(&ch->ch_neo_uart->mcr);
> /* Which pin is doing auto flow? RTS or DTR? */
>
Looks good.
Luis
prev parent reply other threads:[~2016-05-27 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 6:53 [PATCH 2/7] staging: dgnc: remove unused variable 'intr_modem' Daeseok Youn
2016-05-27 11:54 ` Luis de Bethencourt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57483582.2080307@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).