From: Kieran Bingham <kieran@ksquared.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Kieran Bingham <kieran@ksquared.org.uk>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding
Date: Mon, 30 May 2016 11:04:03 +0100 [thread overview]
Message-ID: <574C1013.7000804@bingham.xyz> (raw)
In-Reply-To: <CAMuHMdUhv24QWE44k-nHTAkfy_EnDv76toUuOoD46pKNNR3r3w@mail.gmail.com>
Hi Geert!
On 28/05/16 20:06, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kieran@ksquared.org.uk> wrote:
>> The FCP driver, can also support the FCPF variant for FDP1 compatible
>> processing.
>>
>> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
>
> Thanks for your patch!
>
>> ---
>> Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> Cc: devicetree@vger.kernel.org
>>
>> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> index 6a12960609d8..1c0718b501ef 100644
>> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
>> @@ -7,11 +7,12 @@ conversion of AXI transactions in order to reduce the memory bandwidth.
>>
>> There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
>> for FDP (FCPF). Their configuration and behaviour depend on the module they
>> -are paired with. These DT bindings currently support the FCPV only.
>> +are paired with. These DT bindings currently support the FCPV and FCPF.
>>
>> - compatible: Must be one or more of the following
>>
>> - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP'
>> + - "renesas,r8a7795-fcpf" for R8A7795 (R-Car H3) compatible 'FCP for FDP'
>> - "renesas,fcpv" for generic compatible 'FCP for VSP'
>
> I guess checkpatch complained about your dtsi additions because you forgot
> to add "renesas,fcpf" here?
Yes. Looks quite obvious doesn't it :)
I thought CP.pl was complaining because the file was renesas,fcp.txt,
and I was adding in fcpf!.
I was clearly a bit too keen to get those patches out on a friday
evening. I must remember that I'm not smarter than checkpatch!
I'll add the missing line :)
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
--
Regards
Kieran Bingham
next prev parent reply other threads:[~2016-05-30 10:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 17:19 [PATCH 0/4] RCar r8a7795 FCPF support Kieran Bingham
2016-05-27 17:19 ` [PATCH 1/4] fcp: Extend FCP compatible list to support the FDP Kieran Bingham
2016-05-27 17:21 ` Kieran Bingham
2016-05-27 17:19 ` [PATCH 1/4] v4l: " Kieran Bingham
2016-05-27 17:19 ` [PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding Kieran Bingham
2016-05-28 19:06 ` Geert Uytterhoeven
2016-05-30 10:04 ` Kieran Bingham [this message]
2016-05-27 17:19 ` [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage Kieran Bingham
2016-05-28 19:03 ` Geert Uytterhoeven
2016-05-30 10:09 ` Kieran Bingham
2016-05-27 17:19 ` [PATCH 4/4] arm64: dts: r8a7795: add FCPF device nodes Kieran Bingham
2016-05-31 9:10 ` [PATCH 0/4] RCar r8a7795 FCPF support Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574C1013.7000804@bingham.xyz \
--to=kieran@ksquared.org.uk \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).