From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932996AbcE3LDY (ORCPT ); Mon, 30 May 2016 07:03:24 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:17787 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932192AbcE3LDX (ORCPT ); Mon, 30 May 2016 07:03:23 -0400 Subject: Re: [PATCH v6 10/11] perf callchain: Support x86 target platform To: Jiri Olsa References: <1464436800-39860-1-git-send-email-hekuang@huawei.com> <1464436800-39860-11-git-send-email-hekuang@huawei.com> <20160530085317.GF25607@krava> <574C03C7.9030807@huawei.com> <20160530093034.GA9298@krava> CC: , , , , , , , , , , , , , , , , From: Hekuang Message-ID: <574C1CE0.1050309@huawei.com> Date: Mon, 30 May 2016 18:58:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160530093034.GA9298@krava> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.110.55.166] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.574C1CEC.00AD,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 5df3781a9436c28b3c58c07734b4b0c6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/5/30 17:30, Jiri Olsa 写道: > On Mon, May 30, 2016 at 05:11:35PM +0800, Hekuang wrote: >> hi >> >> 在 2016/5/30 16:53, Jiri Olsa 写道: >>> On Sat, May 28, 2016 at 11:59:59AM +0000, He Kuang wrote: >>>> Support x86(32-bit) cross platform callchain unwind. >>>> >>>> Signed-off-by: He Kuang >>>> --- >>>> tools/perf/arch/Build | 1 + >>>> tools/perf/arch/x86/util/unwind-libunwind.c | 7 ++++--- >>>> tools/perf/arch/x86/util/unwind-libunwind_x86_32.c | 21 +++++++++++++++++++++ >>>> tools/perf/util/unwind-libunwind-local.c | 4 ++++ >>>> tools/perf/util/unwind-libunwind.c | 19 +++++++++++++------ >>>> tools/perf/util/unwind.h | 10 ++++++++++ >>>> 6 files changed, 53 insertions(+), 9 deletions(-) >>>> create mode 100644 tools/perf/arch/x86/util/unwind-libunwind_x86_32.c >>>> >>>> diff --git a/tools/perf/arch/Build b/tools/perf/arch/Build >>>> index 109eb75..3fc4af1 100644 >>>> --- a/tools/perf/arch/Build >>>> +++ b/tools/perf/arch/Build >>>> @@ -1,2 +1,3 @@ >>>> libperf-y += common.o >>>> libperf-y += $(ARCH)/ >>>> +libperf-$(CONFIG_LIBUNWIND_X86) += x86/util/unwind-libunwind_x86_32.o >>> we have Build file directly in arch/x86/util/ >>> >>> if you do it like this to include generic file easily >>> we better fix the include then >> This is because "libperf-y += $(ARCH)" will only sink into $(ARCH) folder, >> for example on x86_64, only tools/perf/arch/x86 will be built. But for >> remote libunwind, we also need >> 'tools/perf/arch/arm64/util/unwind-libunwind.o', while arm64 folder is >> not added to libperf-y. Is there a gracefull to deal with this? > you just need to include the file, right? > > I think it's ok to include arch/arm/....c > from arch/x86/util/unwind-libunwind-arm64.c > > jirka By following your advise, if ARCH=x86, the file tree will be like this: arch/x86 - arch/x86/util/unwind-libunwind-arm64.c - arch/x86/util/unwind-libunwind-x86_32.c - arch/x86/util/unwind-libunwind-x86_64.c - arch/x86/util/unwind-libunwind-arm.c And for ARCH=arm （host machine is arm, it should be considered) arch/arm - arch/arm/util/unwind-libunwind-arm64.c - arch/arm/util/unwind-libunwind-x86_32.c - arch/arm/util/unwind-libunwind-x86_64.c - arch/arm/util/unwind-libunwind-arm.c For arm64: arch/arm64 - arch/arm64/util/unwind-libunwind-arm64.c - arch/arm64/util/unwind-libunwind-x86_32.c - arch/arm64/util/unwind-libunwind-x86_64.c - arch/arm64/util/unwind-libunwind-arm.c But in my patch, the file tree is like this: arch - arch/arm64/util/unwind-libunwind-arm64.c - arch/x86/util/unwind-libunwind-x86_64.c - arch/x86/util/unwind-libunwind-x86_32.c - arch/arm/util/unwind-libunwind-arm.c I admit that +libperf-$(CONFIG_LIBUNWIND_X86) += x86/util/unwind-libunwind_x86_32.o is not so good, but do you think the above file tree is too redunctant? Thank you. >